diff mbox series

[v3,3/3] HID: appletb-kbd: Fix inconsistent indentation and pass -ENODEV to dev_err_probe

Message ID 21F8BD96-7E20-463A-A997-4FBCF0934D87@live.com (mailing list archive)
State Superseded
Delegated to: Jiri Kosina
Headers show
Series [v3,1/3] HID: hid-appletb-kbd: simplify logic used to switch between media and function keys on pressing fn key | expand

Commit Message

Aditya Garg Feb. 15, 2025, 6:40 p.m. UTC 
From: Aditya Garg <gargaditya08@live.com>

The following warnings were flagged by the kernel test robot:

drivers/hid/hid-appletb-kbd.c:405 appletb_kbd_probe() warn: inconsistent indenting
drivers/hid/hid-appletb-kbd.c:406 appletb_kbd_probe() warn: passing zero to 'dev_err_probe'

This patch aims at fixing those warnings.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202502152006.fBBCdEr3-lkp@intel.com/
Signed-off-by: Aditya Garg <gargaditya08@live.com>
---
 drivers/hid/hid-appletb-kbd.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/drivers/hid/hid-appletb-kbd.c b/drivers/hid/hid-appletb-kbd.c
index e45cc3ac4..200db518a 100644
--- a/drivers/hid/hid-appletb-kbd.c
+++ b/drivers/hid/hid-appletb-kbd.c
@@ -402,9 +402,9 @@  static int appletb_kbd_probe(struct hid_device *hdev, const struct hid_device_id
 	}
 
 	kbd->backlight_dev = backlight_device_get_by_name("appletb_backlight");
-		if (!kbd->backlight_dev)
-			dev_err_probe(dev, ret, "Failed to get backlight device\n");
-		else {
+		if (!kbd->backlight_dev) {
+			dev_err_probe(dev, -ENODEV, "Failed to get backlight device\n");
+		} else {
 			backlight_device_set_brightness(kbd->backlight_dev, 2);
 			timer_setup(&kbd->inactivity_timer, appletb_inactivity_timer, 0);
 			mod_timer(&kbd->inactivity_timer, jiffies + msecs_to_jiffies(appletb_tb_dim_timeout * 1000));