diff mbox

[v2] hid: Fix Logitech Driving Force Pro wheel

Message ID 2b85316d7925dad6c55672d7d9738e18.squirrel@host171.canaca.com (mailing list archive)
State New, archived
Delegated to: Jiri Kosina
Headers show

Commit Message

simon@mungewell.org June 2, 2011, 4:35 p.m. UTC
> Changes from initial patch:
> - shorten comment (removed original descriptor)
> - optimized new descriptor (simpler and shorter)

Concept looks go to me, but I'm getting
--
simon@ubuntu:~/linux-2.6$ patch -p 1 <
../Downloads/v2-hid-Fix-Logitech-Driving-Force-Pro-wheel.patch
patching file drivers/hid/hid-lg.c
patch: **** malformed patch at line 91: USB_DEVICE_ID_LOGITECH_G25_WHEEL), --

Looks like word wrap has been applied to the patch.

It also fails to patch chunk 3 against 3.0rc1 as the G27 wheel has been
added.
--

--
    { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
USB_DEVICE_ID_LOGITECH_G25_WHEEL),
        .driver_data = LG_FF },
    { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
USB_DEVICE_ID_LOGITECH_G27_WHEEL),
        .driver_data = LG_FF },
    { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
USB_DEVICE_ID_LOGITECH_DFP_WHEEL),
        .driver_data = LG_FF },
--

All that said it appears to build (don't have this wheel to test) and have
it in a git archive if you'd like be to spin a fixed patch for you.

Simon




--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Michael Bauer June 3, 2011, 9:25 a.m. UTC | #1
>> Changes from initial patch:
>> - shorten comment (removed original descriptor)
>> - optimized new descriptor (simpler and shorter)
>
> Concept looks go to me, but I'm getting
> --
> simon@ubuntu:~/linux-2.6$ patch -p 1 <
> ../Downloads/v2-hid-Fix-Logitech-Driving-Force-Pro-wheel.patch
> patching file drivers/hid/hid-lg.c
> patch: **** malformed patch at line 91: USB_DEVICE_ID_LOGITECH_G25_WHEEL), --
>
> Looks like word wrap has been applied to the patch.
>
> It also fails to patch chunk 3 against 3.0rc1 as the G27 wheel has been
> added.
> [...]

Ouch, seems i messed that up :-/

> All that said it appears to build (don't have this wheel to test) and have
> it in a git archive if you'd like be to spin a fixed patch for you.

Simon, it would be great if you could do this - I am quite busy at work
atm :-( If not let me know, then I'll try to squeeze it in on my side.

Thank you and best regards
Michael




--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- drivers/hid/hid-lg.c    2011-05-19 06:06:34.000000000 +0200
+++ drivers/hid/hid-lg.c    2011-05-30 21:49:51.535184784 +0200
@@ -450,7 +522,7 @@ 
    { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
USB_DEVICE_ID_LOGITECH_G25_WHEEL),
        .driver_data = LG_FF },
    { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
USB_DEVICE_ID_LOGITECH_DFP_WHEEL),
-       .driver_data = LG_FF },
+       .driver_data = LG_NOGET | LG_FF },
    { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,