diff mbox

tsc40: remove wrong announcement of pressure support

Message ID 3551576.vuikKUmT5K@devpool02 (mailing list archive)
State New, archived
Headers show

Commit Message

Rolf Eike Beer Oct. 26, 2012, 7:35 a.m. UTC
The tsc40 driver announces it supports the pressure event, but will never send
one. The announcement will cause tslib to wait for such events and sending all
touch events with a pressure of 0. Removing the announcement will make tslib
fall back to emulating the pressure on touch events so everything works as
expected.

Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: stable@vger.kernel.org
---
 drivers/input/touchscreen/tsc40.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Dmitry Torokhov Oct. 31, 2012, 6:41 a.m. UTC | #1
On Fri, Oct 26, 2012 at 09:35:57AM +0200, Rolf Eike Beer wrote:
> The tsc40 driver announces it supports the pressure event, but will never send
> one. The announcement will cause tslib to wait for such events and sending all
> touch events with a pressure of 0. Removing the announcement will make tslib
> fall back to emulating the pressure on touch events so everything works as
> expected.
> 
> Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
> Cc: stable@vger.kernel.org

Applied, thank you Rolf. 

> ---
>  drivers/input/touchscreen/tsc40.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/tsc40.c b/drivers/input/touchscreen/tsc40.c
> index 63209aa..eb96f16 100644
> --- a/drivers/input/touchscreen/tsc40.c
> +++ b/drivers/input/touchscreen/tsc40.c
> @@ -107,7 +107,6 @@ static int tsc_connect(struct serio *serio, struct serio_driver *drv)
>  	__set_bit(BTN_TOUCH, input_dev->keybit);
>  	input_set_abs_params(ptsc->dev, ABS_X, 0, 0x3ff, 0, 0);
>  	input_set_abs_params(ptsc->dev, ABS_Y, 0, 0x3ff, 0, 0);
> -	input_set_abs_params(ptsc->dev, ABS_PRESSURE, 0, 0, 0, 0);
>  
>  	serio_set_drvdata(serio, ptsc);
>  
> -- 
> 1.7.11.5
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/input/touchscreen/tsc40.c b/drivers/input/touchscreen/tsc40.c
index 63209aa..eb96f16 100644
--- a/drivers/input/touchscreen/tsc40.c
+++ b/drivers/input/touchscreen/tsc40.c
@@ -107,7 +107,6 @@  static int tsc_connect(struct serio *serio, struct serio_driver *drv)
 	__set_bit(BTN_TOUCH, input_dev->keybit);
 	input_set_abs_params(ptsc->dev, ABS_X, 0, 0x3ff, 0, 0);
 	input_set_abs_params(ptsc->dev, ABS_Y, 0, 0x3ff, 0, 0);
-	input_set_abs_params(ptsc->dev, ABS_PRESSURE, 0, 0, 0, 0);
 
 	serio_set_drvdata(serio, ptsc);