| Message ID | 37443a675ca07c91c5f0118ce255406e6e3c08f5.1715502304.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | ae7620b2839365e23a88dc2953e071ff2f260868 |
| Headers | show |
| Series | Input: chipone_icn8505 - remove an unused field in struct icn8505_data | expand |
Hi, On 5/12/24 10:25 AM, Christophe JAILLET wrote: > In "struct icn8505_data", the 'wake_gpio' field is unused. > There is also nothing about gpio neither in this driver nor in the > data-sheet. > > So, remove it. > > Found with cppcheck, unusedStructMember. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > Compile tested only. > > It was added in the initial commit e7330fa032bb ("Input: add support for > ChipOne icn8505 based touchscreens") but was never used. > --- > drivers/input/touchscreen/chipone_icn8505.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/input/touchscreen/chipone_icn8505.c b/drivers/input/touchscreen/chipone_icn8505.c > index b56954830b33..c1b4fc28fa8d 100644 > --- a/drivers/input/touchscreen/chipone_icn8505.c > +++ b/drivers/input/touchscreen/chipone_icn8505.c > @@ -68,7 +68,6 @@ struct icn8505_touch_data { > struct icn8505_data { > struct i2c_client *client; > struct input_dev *input; > - struct gpio_desc *wake_gpio; > struct touchscreen_properties prop; > char firmware_name[32]; > };
On Sun, May 12, 2024 at 10:25:17AM +0200, Christophe JAILLET wrote: > In "struct icn8505_data", the 'wake_gpio' field is unused. > There is also nothing about gpio neither in this driver nor in the > data-sheet. > > So, remove it. > > Found with cppcheck, unusedStructMember. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Applied, thank you.
diff --git a/drivers/input/touchscreen/chipone_icn8505.c b/drivers/input/touchscreen/chipone_icn8505.c index b56954830b33..c1b4fc28fa8d 100644 --- a/drivers/input/touchscreen/chipone_icn8505.c +++ b/drivers/input/touchscreen/chipone_icn8505.c @@ -68,7 +68,6 @@ struct icn8505_touch_data { struct icn8505_data { struct i2c_client *client; struct input_dev *input; - struct gpio_desc *wake_gpio; struct touchscreen_properties prop; char firmware_name[32]; };
In "struct icn8505_data", the 'wake_gpio' field is unused. There is also nothing about gpio neither in this driver nor in the data-sheet. So, remove it. Found with cppcheck, unusedStructMember. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- Compile tested only. It was added in the initial commit e7330fa032bb ("Input: add support for ChipOne icn8505 based touchscreens") but was never used. --- drivers/input/touchscreen/chipone_icn8505.c | 1 - 1 file changed, 1 deletion(-)