From patchwork Sun Mar 12 01:55:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cameron Gutman X-Patchwork-Id: 9619201 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3445F604A9 for ; Sun, 12 Mar 2017 01:56:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1F562285B9 for ; Sun, 12 Mar 2017 01:56:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 114A3285BE; Sun, 12 Mar 2017 01:56:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A7D7F28552 for ; Sun, 12 Mar 2017 01:56:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755619AbdCLB4C (ORCPT ); Sat, 11 Mar 2017 20:56:02 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:34195 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753782AbdCLB4B (ORCPT ); Sat, 11 Mar 2017 20:56:01 -0500 Received: by mail-pf0-f195.google.com with SMTP id o126so15114259pfb.1; Sat, 11 Mar 2017 17:56:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:cc:message-id:date:user-agent:mime-version :content-transfer-encoding; bh=8TuaRzdbikVjMRf9EztdbKfaGR4piwXZN5T1/Ex/wFE=; b=HY+oxRAJYLHUj4stz0v5lk0CA48zai1F8GD0eN0qXi6NXQi4k2+b5M2wKUMsgKcQR7 rIeQlnac5C+uRO9m7F1ZpI2Xe1gu2MtHTYqoHnBhjye5SKoTYR/jgMV9Qqn3W+xIQoMQ 53sBkmx7RuKlS9n7e/7N8tg6sU35TijQVsNLUaWlkwOU/k/YZAP7FVys4N+Lxls6bKa+ FlBH/gluJhe+ad6a8H50DlC+pY9yi2AlsbQRCzy+YQw9LrYYGWZ9qME1gWEBnGGxTsz9 QV3j0Lcf/Kaz9WGKRTsptodxmhWa2fN2imN3h71+KOk1LehL7GVBcA8L5sEEPh4ZRPk7 aeXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:message-id:date:user-agent :mime-version:content-transfer-encoding; bh=8TuaRzdbikVjMRf9EztdbKfaGR4piwXZN5T1/Ex/wFE=; b=hEK5OkJ/7BmiTDlpMcko9jd1NE/0V/5n94JwL/UT9a7ViIW2K3Wj5a08Qq8SpK3TXS tgioe2adnZm8LS1C/7YW7RjkzvY/JGjSvzLll1htL8vjId2R/u2AU7MYmlC7zDf79z3e vRI3RGi2snLG+vx7xvTYSrh3dT1k7dvBKJoTchZkhYrRadHAjLy3P1gvTvKNt/wBAY64 rY7+970mBsjc4hob9ZwYuZRUKhY9FBhaS8f/5mJ1tn0BPGsWiovKNWxQ/4E3QmH5fs8g U7eiSWyeYTsI5AUD0Z+2PZ3TtWm7Dsax3YXKtOKdYdpyFY6lttZHCz7GORsaQkhLtg3w xP+g== X-Gm-Message-State: AMke39m8R1ho9puPFNaNh2A0GUUyijGHBUa19CPoOmHORdMTYGtM/6V9awHajVmAxcjhbw== X-Received: by 10.84.143.195 with SMTP id 61mr37120211plz.46.1489283759713; Sat, 11 Mar 2017 17:55:59 -0800 (PST) Received: from [192.168.1.139] ([174.127.240.168]) by smtp.gmail.com with ESMTPSA id z7sm26098992pfz.128.2017.03.11.17.55.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 11 Mar 2017 17:55:58 -0800 (PST) From: Cameron Gutman Subject: Synaptics RMI4 touchpad regression in 4.11-rc1 To: benjamin.tissoires@redhat.com, aduggan@synaptics.com, nick@shmanahar.org, cheiny@synaptics.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <375e67b5-2cb8-3491-1d71-d8650d6e9451@gmail.com> Date: Sat, 11 Mar 2017 17:55:58 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, Beginning in 4.11-rc1, it looks like RMI4 is binding to my XPS 13 9443's Synaptics touchpad and dropping some errors into dmesg. Here are the messages that seem RMI-related: rmi4_f34 rmi4-00.fn34: rmi_f34v7_probe: Unrecognized bootloader version rmi4_f34: probe of rmi4-00.fn34 failed with error -22 rmi4_f01 rmi4-00.fn01: found RMI device, manufacturer: Synaptics, product: TM3038-001, fw id: 1832324 input: Synaptics TM3038-001 as /devices/pci0000:00/INT3433:00/i2c-7/i2c-DLL0665:01/0018:06CB:76AD.0001/input/input19 hid-rmi 0018:06CB:76AD.0001: input,hidraw0: I2C HID v1.00 Mouse [DLL0665:01 06CB:76AD] on i2c-DLL0665:01 Since "Unrecognized bootloader version" isn't a really helpful message, I applied the attached patch to print the bootloader version which gave me the following: rmi4_f34 rmi4-00.fn34: rmi_f34v7_probe: Unrecognized bootloader version: 16 I don't really know what to make of that. It seem very different than the values the existing code expects. Compared to hid-multitouch, the RMI stack seems to have completely broken palm rejection and introduced some random jumpiness during fine pointing motions. I don't know if these issues are caused by the above errors or are a separate issue. The affected machine is an XPS 13 9443 running Fedora 25 with 4.11-rc1 and libinput 1.6.3-3.fc25 (latest in F25). Let me know any additional info you'd like. Regards, Cameron ---- the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/input/rmi4/rmi_f34v7.c b/drivers/input/rmi4/rmi_f34v7.c index 56c6c39..b458cb3 100644 --- a/drivers/input/rmi4/rmi_f34v7.c +++ b/drivers/input/rmi4/rmi_f34v7.c @@ -1369,8 +1369,8 @@ int rmi_f34v7_probe(struct f34_data *f34) } else if (f34->bootloader_id[1] == 7) { f34->bl_version = 7; } else { - dev_err(&f34->fn->dev, "%s: Unrecognized bootloader version\n", - __func__); + dev_err(&f34->fn->dev, "%s: Unrecognized bootloader version: %u\n", + __func__, f34->bootloader_id[1]); return -EINVAL; } -- To unsubscribe from this list: send the line "unsubscribe linux-input" in