diff mbox series

[1/3] dt-bindings: input: gpio-keys: Fix interrupts in example

Message ID 47ecd2d8efcf09f8ab47de87a7bcfafc82208776.1638538079.git.geert+renesas@glider.be (mailing list archive)
State New, archived
Headers show
Series Input: gpio-keys - Interrupt-related fixes | expand

Commit Message

Geert Uytterhoeven Dec. 3, 2021, 1:35 p.m. UTC
The "interrupts" property in the example looks weird:
  - The type is not in the last cell,
  - Level interrupts don't work well with gpio-keys, as they keep the
    interrupt asserted as long as the key is pressed, causing an
    interrupt storm.

Use a more realistic falling-edge interrupt instead.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 Documentation/devicetree/bindings/input/gpio-keys.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rob Herring Dec. 6, 2021, 8:17 p.m. UTC | #1
On Fri, 03 Dec 2021 14:35:06 +0100, Geert Uytterhoeven wrote:
> The "interrupts" property in the example looks weird:
>   - The type is not in the last cell,
>   - Level interrupts don't work well with gpio-keys, as they keep the
>     interrupt asserted as long as the key is pressed, causing an
>     interrupt storm.
> 
> Use a more realistic falling-edge interrupt instead.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  Documentation/devicetree/bindings/input/gpio-keys.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied, thanks!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/input/gpio-keys.yaml b/Documentation/devicetree/bindings/input/gpio-keys.yaml
index 060a309ff8e7c757..dbe7ecc19ccb9423 100644
--- a/Documentation/devicetree/bindings/input/gpio-keys.yaml
+++ b/Documentation/devicetree/bindings/input/gpio-keys.yaml
@@ -142,7 +142,7 @@  examples:
         down {
             label = "GPIO Key DOWN";
             linux,code = <108>;
-            interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
+            interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
         };
     };