diff mbox series

[1/6] media: videodev2.h: add V4L2_CAP_EDID

Message ID 485324508040defc0ba0fb211a6596dc65f2d994.1723190258.git.hverkuil-cisco@xs4all.nl (mailing list archive)
State New
Headers show
Series media: cec: add support for the Extron DA HD 4K Plus HDMI Splitter | expand

Commit Message

Hans Verkuil Aug. 9, 2024, 7:57 a.m. UTC 
From: Erling Ljunggren <hljunggr@cisco.com>

Add capability flag to indicate that the device is an EDID-only device.

Signed-off-by: Erling Ljunggren <hljunggr@cisco.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---
 include/uapi/linux/videodev2.h | 1 +
 1 file changed, 1 insertion(+)

Comments

sebastian.fricke@collabora.com Aug. 28, 2024, 12:37 p.m. UTC | #1 
Hello,

On 09.08.2024 09:57, Hans Verkuil wrote:
>From: Erling Ljunggren <hljunggr@cisco.com>
>
>Add capability flag to indicate that the device is an EDID-only device.
>
>Signed-off-by: Erling Ljunggren <hljunggr@cisco.com>
>Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

Reviewed-by: Sebastian Fricke <sebastian.fricke@collabora.com>

Regards,
Sebastian
>---
> include/uapi/linux/videodev2.h | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
>index 4e91362da6da..987c821aed79 100644
>--- a/include/uapi/linux/videodev2.h
>+++ b/include/uapi/linux/videodev2.h
>@@ -502,6 +502,7 @@ struct v4l2_capability {
> #define V4L2_CAP_META_CAPTURE		0x00800000  /* Is a metadata capture device */
>
> #define V4L2_CAP_READWRITE              0x01000000  /* read/write systemcalls */
>+#define V4L2_CAP_EDID			0x02000000  /* Is an EDID-only device */
> #define V4L2_CAP_STREAMING              0x04000000  /* streaming I/O ioctls */
> #define V4L2_CAP_META_OUTPUT		0x08000000  /* Is a metadata output device */
>
>-- 
>2.43.0
>
>
Ricardo Ribalda Delgado Aug. 28, 2024, 12:51 p.m. UTC | #2 
Hi Hans

On Fri, Aug 9, 2024 at 10:14 AM Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote:
>
> From: Erling Ljunggren <hljunggr@cisco.com>
>
> Add capability flag to indicate that the device is an EDID-only device.
>
> Signed-off-by: Erling Ljunggren <hljunggr@cisco.com>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> ---
>  include/uapi/linux/videodev2.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index 4e91362da6da..987c821aed79 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -502,6 +502,7 @@ struct v4l2_capability {
>  #define V4L2_CAP_META_CAPTURE          0x00800000  /* Is a metadata capture device */
>
>  #define V4L2_CAP_READWRITE              0x01000000  /* read/write systemcalls */
> +#define V4L2_CAP_EDID                  0x02000000  /* Is an EDID-only device */

Would it make sense to add a check for "EDID-only", I mean, if the
driver sets this cap, then it should not set V4L2_CAP_STREAMING or others.

The test could be in the core or even in v4l2-compliance.

Regards!


>  #define V4L2_CAP_STREAMING              0x04000000  /* streaming I/O ioctls */
>  #define V4L2_CAP_META_OUTPUT           0x08000000  /* Is a metadata output device */
>
> --
> 2.43.0
>
>


--
Ricardo Ribalda
Hans Verkuil Aug. 29, 2024, 7:11 a.m. UTC | #3 
On 28/08/2024 14:51, Ricardo Ribalda Delgado wrote:
> Hi Hans
> 
> On Fri, Aug 9, 2024 at 10:14 AM Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote:
>>
>> From: Erling Ljunggren <hljunggr@cisco.com>
>>
>> Add capability flag to indicate that the device is an EDID-only device.
>>
>> Signed-off-by: Erling Ljunggren <hljunggr@cisco.com>
>> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
>> ---
>>  include/uapi/linux/videodev2.h | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
>> index 4e91362da6da..987c821aed79 100644
>> --- a/include/uapi/linux/videodev2.h
>> +++ b/include/uapi/linux/videodev2.h
>> @@ -502,6 +502,7 @@ struct v4l2_capability {
>>  #define V4L2_CAP_META_CAPTURE          0x00800000  /* Is a metadata capture device */
>>
>>  #define V4L2_CAP_READWRITE              0x01000000  /* read/write systemcalls */
>> +#define V4L2_CAP_EDID                  0x02000000  /* Is an EDID-only device */
> 
> Would it make sense to add a check for "EDID-only", I mean, if the
> driver sets this cap, then it should not set V4L2_CAP_STREAMING or others.
> 
> The test could be in the core or even in v4l2-compliance.

Good point. It is easy to add this to v4l2-compliance.

I noticed that the v4l2 core doesn't check for invalid caps combinations. It is
left to v4l2-compliance to check that. So I think I'll keep the check there.

Regards,

	Hans

> 
> Regards!
> 
> 
>>  #define V4L2_CAP_STREAMING              0x04000000  /* streaming I/O ioctls */
>>  #define V4L2_CAP_META_OUTPUT           0x08000000  /* Is a metadata output device */
>>
>> --
>> 2.43.0
>>
>>
> 
> 
> --
> Ricardo Ribalda
>
Ricardo Ribalda Delgado Aug. 29, 2024, 7:25 a.m. UTC | #4 
On Thu, Aug 29, 2024 at 9:11 AM Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote:
>
> On 28/08/2024 14:51, Ricardo Ribalda Delgado wrote:
> > Hi Hans
> >
> > On Fri, Aug 9, 2024 at 10:14 AM Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote:
> >>
> >> From: Erling Ljunggren <hljunggr@cisco.com>
> >>
> >> Add capability flag to indicate that the device is an EDID-only device.
> >>
> >> Signed-off-by: Erling Ljunggren <hljunggr@cisco.com>
> >> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> >> ---
> >>  include/uapi/linux/videodev2.h | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> >> index 4e91362da6da..987c821aed79 100644
> >> --- a/include/uapi/linux/videodev2.h
> >> +++ b/include/uapi/linux/videodev2.h
> >> @@ -502,6 +502,7 @@ struct v4l2_capability {
> >>  #define V4L2_CAP_META_CAPTURE          0x00800000  /* Is a metadata capture device */
> >>
> >>  #define V4L2_CAP_READWRITE              0x01000000  /* read/write systemcalls */
> >> +#define V4L2_CAP_EDID                  0x02000000  /* Is an EDID-only device */
> >
> > Would it make sense to add a check for "EDID-only", I mean, if the
> > driver sets this cap, then it should not set V4L2_CAP_STREAMING or others.
> >
> > The test could be in the core or even in v4l2-compliance.
>
> Good point. It is easy to add this to v4l2-compliance.
>
> I noticed that the v4l2 core doesn't check for invalid caps combinations. It is
> left to v4l2-compliance to check that. So I think I'll keep the check there.

cool! Thanks

Reviewed-by: Ricardo Ribalda <ribalda@chromium.org>


>
> Regards,
>
>         Hans
>
> >
> > Regards!
> >
> >
> >>  #define V4L2_CAP_STREAMING              0x04000000  /* streaming I/O ioctls */
> >>  #define V4L2_CAP_META_OUTPUT           0x08000000  /* Is a metadata output device */
> >>
> >> --
> >> 2.43.0
> >>
> >>
> >
> >
> > --
> > Ricardo Ribalda
> >
>
diff mbox series

Patch

diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
index 4e91362da6da..987c821aed79 100644
--- a/include/uapi/linux/videodev2.h
+++ b/include/uapi/linux/videodev2.h
@@ -502,6 +502,7 @@  struct v4l2_capability {
 #define V4L2_CAP_META_CAPTURE		0x00800000  /* Is a metadata capture device */
 
 #define V4L2_CAP_READWRITE              0x01000000  /* read/write systemcalls */
+#define V4L2_CAP_EDID			0x02000000  /* Is an EDID-only device */
 #define V4L2_CAP_STREAMING              0x04000000  /* streaming I/O ioctls */
 #define V4L2_CAP_META_OUTPUT		0x08000000  /* Is a metadata output device */