diff mbox

Input: TPS6507X - define MFD dependencies for touch and regulator unit

Message ID 4E1AECB3.3080607@visionsystems.de (mailing list archive)
State New, archived
Headers show

Commit Message

Yegor Yefremov July 11, 2011, 12:29 p.m. UTC 
Am 11.07.2011 14:20, schrieb Mark Brown:
> On Mon, Jul 11, 2011 at 12:50:19PM +0200, Yegor Yefremov wrote:
>> both touchscreen and regulator units are only working if
>> mfd device is activated. So if mfd support is enabled,
>> select TPS6507X mfd support automatically.
>>
>> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> This should be split into separate patches and sent to *all* the
> relevant maintainers.
>
>>  config TOUCHSCREEN_TPS6507X
>>  	tristate "TPS6507x based touchscreens"
>> -	depends on I2C
>> +	depends on I2C && MFD_SUPPORT
>> +	select TPS6507X
> This isn't a good fix, the driver should depend on the MFD core not
> select it.

Thanks for reviewing. Should I change the patch like this:

touchscreen unit is only working if mfd device is activated.
So if mfd support is enabled, select TPS6507X mfd support
automatically.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 drivers/input/touchscreen/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Mark Brown July 11, 2011, 2:08 p.m. UTC | #1 
On Mon, Jul 11, 2011 at 02:29:39PM +0200, Yegor Yefremov wrote:
> Am 11.07.2011 14:20, schrieb Mark Brown:

>         tristate "TPS6507x based touchscreens"
> -       depends on I2C
> +       depends on I2C && TPS6507X

You can just remove the I2C dependency, the core won't be enabled if teh
control bus isn't there.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

Index: b/drivers/input/touchscreen/Kconfig
===================================================================
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -716,7 +716,7 @@ 

 config TOUCHSCREEN_TPS6507X
        tristate "TPS6507x based touchscreens"
-       depends on I2C
+       depends on I2C && TPS6507X
        help
          Say Y here if you have a TPS6507x based touchscreen
          controller.