| Message ID | 5299B520.9060200@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Jiri Kosina |
| Headers | show |
On Sat, 30 Nov 2013, Zawullon wrote: > Issue description: I have two Logitech Dual Action gamepads, both have > same Vendor/Device id pair. Newest gamepad (A) can switch between old mode (HID) > and XBox gamepad emulation mode. Old gamepad (B) can only work in HID mode. > In HID mode gamepad A sends many EPIPE errors during initialization and was > disconnected immediately after connect to usb port. It works fine in Win and > Mac. After adding NOGET quirk in driver, it was working properly. > Gamepad B works fine before and after changes. I tested both gamepads > with 3.8.0 and 3.11.6 kernels with modified driver. Follow patch can apply > for current git kernel version. I can send pcap log from usb bus with both > gamepads or any other additional information if it is needed > Please provide your Signed-off-by: line so that I could apply the patch. Thanks. > diff -uprN -X linux-git/Documentation/dontdiff linux-git/drivers/hid/hid-ids.h linux-my/drivers/hid/hid-ids.h > --- linux-git/drivers/hid/hid-ids.h 2013-11-30 13:29:27.937351968 +0400 > +++ linux-my/drivers/hid/hid-ids.h 2013-11-30 13:46:05.201378674 +0400 > @@ -552,6 +552,7 @@ > #define USB_DEVICE_ID_LOGITECH_RUMBLEPAD_CORD 0xc20a > #define USB_DEVICE_ID_LOGITECH_RUMBLEPAD 0xc211 > #define USB_DEVICE_ID_LOGITECH_EXTREME_3D 0xc215 > +#define USB_DEVICE_ID_LOGITECH_DUAL_ACTION 0xc216 > #define USB_DEVICE_ID_LOGITECH_RUMBLEPAD2 0xc218 > #define USB_DEVICE_ID_LOGITECH_RUMBLEPAD2_2 0xc219 > #define USB_DEVICE_ID_LOGITECH_WINGMAN_F3D 0xc283 > diff -uprN -X linux-git/Documentation/dontdiff linux-git/drivers/hid/hid-lg.c linux-my/drivers/hid/hid-lg.c > --- linux-git/drivers/hid/hid-lg.c 2013-11-30 13:29:27.937351968 +0400 > +++ linux-my/drivers/hid/hid-lg.c 2013-11-30 13:46:05.201378674 +0400 > @@ -758,6 +758,8 @@ static const struct hid_device_id lg_dev > > { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_EXTREME_3D), > .driver_data = LG_NOGET }, > + { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_DUAL_ACTION), > + .driver_data = LG_NOGET }, > { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_WHEEL), > .driver_data = LG_NOGET | LG_FF4 }, > >
02.12.2013 18:13, Jiri Kosina wrote: > Please provide your Signed-off-by: line so that I could apply the patch. > Thanks. Oh, of course. Sorry. Signed-off-by: Vitaly Katraew <zawullon@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2 Dec 2013, Zawullon wrote: > > Please provide your Signed-off-by: line so that I could apply the patch. > > Thanks. > > Oh, of course. Sorry. > > Signed-off-by: Vitaly Katraew <zawullon@gmail.com> Now applied (with the name above as authorship as well). Thanks,
diff -uprN -X linux-git/Documentation/dontdiff linux-git/drivers/hid/hid-ids.h linux-my/drivers/hid/hid-ids.h --- linux-git/drivers/hid/hid-ids.h 2013-11-30 13:29:27.937351968 +0400 +++ linux-my/drivers/hid/hid-ids.h 2013-11-30 13:46:05.201378674 +0400 @@ -552,6 +552,7 @@ #define USB_DEVICE_ID_LOGITECH_RUMBLEPAD_CORD 0xc20a #define USB_DEVICE_ID_LOGITECH_RUMBLEPAD 0xc211 #define USB_DEVICE_ID_LOGITECH_EXTREME_3D 0xc215 +#define USB_DEVICE_ID_LOGITECH_DUAL_ACTION 0xc216 #define USB_DEVICE_ID_LOGITECH_RUMBLEPAD2 0xc218 #define USB_DEVICE_ID_LOGITECH_RUMBLEPAD2_2 0xc219 #define USB_DEVICE_ID_LOGITECH_WINGMAN_F3D 0xc283 diff -uprN -X linux-git/Documentation/dontdiff linux-git/drivers/hid/hid-lg.c linux-my/drivers/hid/hid-lg.c --- linux-git/drivers/hid/hid-lg.c 2013-11-30 13:29:27.937351968 +0400 +++ linux-my/drivers/hid/hid-lg.c 2013-11-30 13:46:05.201378674 +0400 @@ -758,6 +758,8 @@ static const struct hid_device_id lg_dev { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_EXTREME_3D), .driver_data = LG_NOGET }, + { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_DUAL_ACTION), + .driver_data = LG_NOGET }, { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_WHEEL), .driver_data = LG_NOGET | LG_FF4 },