| Message ID | 550725D9.20805@dell.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Mar 16, 2015 at 11:50 AM, Mario Limonciello <mario_limonciello@dell.com> wrote: > > On 03/16/2015 12:10 PM, Jason Ekstrand wrote: >> >> On Mon, Mar 16, 2015 at 7:29 AM, Mario Limonciello >> <mario_limonciello@dell.com> wrote: >> It's nothing about the wireless. I swapped it out for an intel card >> on day 3 or so. >> >> Yes, I am almost 100% sure that this affects suspend/resume. Prior to >> the _REV hack, my laptop *never* suspended correctly. Now it >> regularly suspends just fine. I also double-checked that rebasing on >> Linus' master didn't affect it. With the _REV hack it doesn't >> suspend. Without it, it's just fine. >> >> I don't know much about suspend/resume but is it possible that the >> problem is the kernel not being able to properly shut down the sound >> card? > > Thanks for that confirmation. That does sound like a very likely candidate > that it was because the audio device was in the wrong state. > >> That matches what I've seen. With the _REV hack, I see nothing about >> HDA in dmesg and I get different audio messages than with an _OSI of >> Windows 2009. >> >> I look forward to seeing the update. Thanks for working on this! >> --Jason Ekstrand > > Sure. In in the interim, here is the patch you can apply to your local DSDT > and put in the initramfs to see what it will look like w/ A02. This will > leave the touchpad in I2C and audio in HDA. > > --- DSDT.A01 2015-02-18 18:12:44.891286890 -0600 > +++ DSDT.A02 2015-03-03 23:17:24.075746660 -0600 > @@ -21567,6 +21567,7 @@ > { > ACOS = 0x80 > ACSE = Zero > + OSTP = One > } > } > } > Thanks, I'm now running a hacked up kernel that's Torvalds' tree from Saturday morning (same as before) + a patch from Benjamin to fix the touchpad + the DSDT hack given above. With that, I have HDA audio (not I2S) which is working. Also, suspend/resume now works properly with this new cocktail. --Jason -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/16/2015 03:42 PM, Jason Ekstrand wrote: > On Mon, Mar 16, 2015 at 11:50 AM, Mario Limonciello > <mario_limonciello@dell.com> wrote: > Thanks, > I'm now running a hacked up kernel that's Torvalds' tree from Saturday > morning (same as before) + a patch from Benjamin to fix the touchpad + > the DSDT hack given above. With that, I have HDA audio (not I2S) > which is working. Also, suspend/resume now works properly with this > new cocktail. > --Jason That's great to hear and definitely confirms that it was the sound card in the funky state causing the suspend/resume issues. Testing is ongoing with that BIOS and if no issues crop up should be around soon. Is this the patch from Benjamin that you're running? http://pkgs.fedoraproject.org/cgit/kernel.git/commit/?h=f21&id=d75cb059558345e47a13881512a1600e3e17ba21 I haven't yet run it myself. I'm curious, what sort of behavior change do you see with it? -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Mar 16, 2015 at 1:50 PM, Mario Limonciello <mario_limonciello@dell.com> wrote: > > On 03/16/2015 03:42 PM, Jason Ekstrand wrote: >> >> On Mon, Mar 16, 2015 at 11:50 AM, Mario Limonciello >> <mario_limonciello@dell.com> wrote: >> Thanks, >> I'm now running a hacked up kernel that's Torvalds' tree from Saturday >> morning (same as before) + a patch from Benjamin to fix the touchpad + >> the DSDT hack given above. With that, I have HDA audio (not I2S) >> which is working. Also, suspend/resume now works properly with this >> new cocktail. >> --Jason > > That's great to hear and definitely confirms that it was the sound card in > the funky state causing the suspend/resume issues. Testing is ongoing with > that BIOS and if no issues crop up should be around soon. Thanks! I look forwarding to *not* running a hacked-up kernel soon. > Is this the patch from Benjamin that you're running? > http://pkgs.fedoraproject.org/cgit/kernel.git/commit/?h=f21&id=d75cb059558345e47a13881512a1600e3e17ba21 > I haven't yet run it myself. I'm curious, what sort of behavior change do > you see with it? It reports as touchpad with a single button. This makes the kernel report it as a "clickpad". In particular, this means that libinput knows to make clicking in the lower-right turn into a right-click. With out that, there was no way to right-click since it reports as having a single button. Benjamin could tell you more than me. --Jason -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Mar 16, 2015 at 4:57 PM, Jason Ekstrand <jason@jlekstrand.net> wrote: > On Mon, Mar 16, 2015 at 1:50 PM, Mario Limonciello > <mario_limonciello@dell.com> wrote: >> >> On 03/16/2015 03:42 PM, Jason Ekstrand wrote: >>> >>> On Mon, Mar 16, 2015 at 11:50 AM, Mario Limonciello >>> <mario_limonciello@dell.com> wrote: >>> Thanks, >>> I'm now running a hacked up kernel that's Torvalds' tree from Saturday >>> morning (same as before) + a patch from Benjamin to fix the touchpad + >>> the DSDT hack given above. With that, I have HDA audio (not I2S) >>> which is working. Also, suspend/resume now works properly with this >>> new cocktail. >>> --Jason >> >> That's great to hear and definitely confirms that it was the sound card in >> the funky state causing the suspend/resume issues. Testing is ongoing with >> that BIOS and if no issues crop up should be around soon. > > Thanks! I look forwarding to *not* running a hacked-up kernel soon. > >> Is this the patch from Benjamin that you're running? >> http://pkgs.fedoraproject.org/cgit/kernel.git/commit/?h=f21&id=d75cb059558345e47a13881512a1600e3e17ba21 >> I haven't yet run it myself. I'm curious, what sort of behavior change do >> you see with it? > > It reports as touchpad with a single button. This makes the kernel > report it as a "clickpad". In particular, this means that libinput > knows to make clicking in the lower-right turn into a right-click. > With out that, there was no way to right-click since it reports as > having a single button. Benjamin could tell you more than me. Yes, that's the gist of it. Mario, you might not have seen the problem because you are not running wayland and/or libinput. The xorg synaptics driver is much more relaxed concerning what it received from the kernel and I think it sets most of the time the right software button area if it sees only one button. Cheers, Benjamin -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/16/2015 04:07 PM, Benjamin Tissoires wrote: > On Mon, Mar 16, 2015 at 4:57 PM, Jason Ekstrand <jason@jlekstrand.net> wrote: > Yes, that's the gist of it. > Mario, you might not have seen the problem because you are not running > wayland and/or libinput. The xorg synaptics driver is much more > relaxed concerning what it received from the kernel and I think it > sets most of the time the right software button area if it sees only > one button. > > Cheers, > Benjamin Ah thanks. That explains why I haven't noticed it yet. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- DSDT.A01 2015-02-18 18:12:44.891286890 -0600 +++ DSDT.A02 2015-03-03 23:17:24.075746660 -0600 @@ -21567,6 +21567,7 @@ { ACOS = 0x80 ACSE = Zero + OSTP = One } } }