From patchwork Thu Apr 30 08:38:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 6300561 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 20015BEEE1 for ; Thu, 30 Apr 2015 08:38:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4F387201D3 for ; Thu, 30 Apr 2015 08:38:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3D69201CE for ; Thu, 30 Apr 2015 08:38:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750779AbbD3Iid (ORCPT ); Thu, 30 Apr 2015 04:38:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44192 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750729AbbD3Iic (ORCPT ); Thu, 30 Apr 2015 04:38:32 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3U8cDIx011477 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 30 Apr 2015 04:38:15 -0400 Received: from shalem.localdomain (vpn1-7-115.ams2.redhat.com [10.36.7.115]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3U8c9Qe011538 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 30 Apr 2015 04:38:10 -0400 Message-ID: <5541E9F1.5090902@redhat.com> Date: Thu, 30 Apr 2015 10:38:09 +0200 From: Hans de Goede User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: =?UTF-8?B?RGF2aWQgWmFmcmEgR8OzbWV6?= , Benjamin Tissoires CC: linux-input , Dmitry Torokhov , Duson Lin , Jiri Kosina Subject: Re: PROBLEM: Touchpad works just like a mouse References: <552C4E6C.4070102@klo.es> <552F6AC9.6020005@klo.es> <55320164.5010905@klo.es> <553D5E91.2080704@klo.es> <553F2EF1.9000106@redhat.com> <553FFB10.6010005@klo.es> <554089DF.7040803@redhat.com> <5541BEEC.70905@klo.es> In-Reply-To: <5541BEEC.70905@klo.es> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, On 30-04-15 07:34, David Zafra Gómez wrote: > Hi everyone > > El 29/04/15 a las 09:35, Hans de Goede escribió: >> Hi, >> >> On 28-04-15 23:26, David Zafra Gómez wrote: >>> [ 0.257439] pnp 00:06: Plug and Play ACPI device, IDs ETD0108 >>> SYN0a00 SYN0002 PNP0f03 PNP0f13 PNP0f12 (active) >> >> Ok, so the "ETD0108" here means that you have an elantech ps/2 touchpad. > Great! You got it. >> >> This also stands out in the log: >> >> > [ 0.958323] i8042: [49] MUX error, status is 75, data is fe >> >> So the first thing to try is to boot with i8042.nomux=1 on the kernel >> commandline. > I have done it. The touchpad issue hasn't been solved. Do you want me to send dmesg output? I've taken another look at the traces you've posted before and I think that I've found the problem. Can you build a kernel with the attached patch and let us know if that fixes things ? Regards, Hans From 0b0bf8fd125b0925166470cf8cf9f7b2f310efd4 Mon Sep 17 00:00:00 2001 From: Hans de Goede Date: Thu, 30 Apr 2015 10:29:38 +0200 Subject: [PATCH] elantech: Fix detection of touchpads where the revision matches a known rate MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Make the check to skip the rate check more lax, so that it applies to all hw_version 4 models. This fixes the touchpad not being detected properly on Asus PU551LA laptops. Reported-and-tested-by: David Zafra Gómez Signed-off-by: Hans de Goede --- drivers/input/mouse/elantech.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c index 991dc6b..e30286f 100644 --- a/drivers/input/mouse/elantech.c +++ b/drivers/input/mouse/elantech.c @@ -1379,7 +1379,8 @@ static bool elantech_is_signature_valid(const unsigned char *param) * Some models have a revision higher then 20. Meaning param[2] may * be 10 or 20, skip the rates check for these. */ - if (param[0] == 0x46 && (param[1] & 0xef) == 0x0f && param[2] < 40) + if ((param[0] & 0x0f) >= 0x06 && (param[1] & 0xaf) == 0x0f && + param[2] < 40) return true; for (i = 0; i < ARRAY_SIZE(rates); i++) -- 2.3.6