| Message ID | 573D2900.6090903@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Jiri Kosina |
| Headers | show |
On Thu, May 19, 2016 at 10:46:24AM +0800, Fu, Zhonghui wrote: > i2c-hid devices' suspend/resume are usually time-consuming process. > For example, the touch controller(i2c-ATML1000:00) on ASUS T100 tablet > takes about 160ms for suspending and 120ms for resuming. This patch > enables i2c-hid devices to suspend/resume asynchronously. This will > take advantage of multicore and speed up system suspend/resume process. > > Signed-off-by: Zhonghui Fu <zhonghui.fu@linux.intel.com> Looks reasonable to me, Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 19 May 2016, Fu, Zhonghui wrote: > i2c-hid devices' suspend/resume are usually time-consuming process. > For example, the touch controller(i2c-ATML1000:00) on ASUS T100 tablet > takes about 160ms for suspending and 120ms for resuming. This patch > enables i2c-hid devices to suspend/resume asynchronously. This will > take advantage of multicore and speed up system suspend/resume process. Umm, why do we need this in the first place, given the fact that we are enabling async suspend for each and every HID device allocated via hid_allocate_device() already?
On 5/25/2016 1:31 AM, Dmitry Torokhov wrote: > On Tue, May 24, 2016 at 3:24 AM, Jiri Kosina <jikos@kernel.org> wrote: > >> On Thu, 19 May 2016, Fu, Zhonghui wrote: >> >>> i2c-hid devices' suspend/resume are usually time-consuming process. >>> For example, the touch controller(i2c-ATML1000:00) on ASUS T100 tablet >>> takes about 160ms for suspending and 120ms for resuming. This patch >>> enables i2c-hid devices to suspend/resume asynchronously. This will >>> take advantage of multicore and speed up system suspend/resume process. >> Umm, why do we need this in the first place, given the fact that we are >> enabling async suspend for each and every HID device allocated via >> hid_allocate_device() already? >> > i2c-hid is not a HID but I2C device on I2C bus and is currently resumed > synchronously, in-line. Since it tries to reset device as part of resume it > may take a while for the device to respond. Sorry for late reply. Yes, the devices driven by i2c-hid driver are I2C devices, not HID devices. > > BTW, I am not quite sure what async suspend enabled > in hid_allocate_device() does for us, given that I do not see HID bus > implementing the suspend/resume support for its devices (as far as I > remember we rely on underlying transports - USB or I2C - to resume the > devices properly). Even if HID bus does not implement the suspend/resume support for its devices, the power domain, device type, device class or device driver subsystem related to HID devices can still implement the suspend/resume support for HID devices. Thanks, Zhonghui > > Thanks, > Dmitry > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On May 19 2016 or thereabouts, Fu, Zhonghui wrote: > i2c-hid devices' suspend/resume are usually time-consuming process. > For example, the touch controller(i2c-ATML1000:00) on ASUS T100 tablet > takes about 160ms for suspending and 120ms for resuming. This patch > enables i2c-hid devices to suspend/resume asynchronously. This will > take advantage of multicore and speed up system suspend/resume process. > > Signed-off-by: Zhonghui Fu <zhonghui.fu@linux.intel.com> > --- In regard with the discussion: Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > drivers/hid/i2c-hid/i2c-hid.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c > index 2e021ba..cc41e1e 100644 > --- a/drivers/hid/i2c-hid/i2c-hid.c > +++ b/drivers/hid/i2c-hid/i2c-hid.c > @@ -1020,6 +1020,7 @@ static int i2c_hid_probe(struct i2c_client *client, > pm_runtime_get_noresume(&client->dev); > pm_runtime_set_active(&client->dev); > pm_runtime_enable(&client->dev); > + device_enable_async_suspend(&client->dev); > > ret = i2c_hid_fetch_hid_descriptor(ihid); > if (ret < 0) > -- 1.7.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 19 May 2016, Fu, Zhonghui wrote: > i2c-hid devices' suspend/resume are usually time-consuming process. > For example, the touch controller(i2c-ATML1000:00) on ASUS T100 tablet > takes about 160ms for suspending and 120ms for resuming. This patch > enables i2c-hid devices to suspend/resume asynchronously. This will > take advantage of multicore and speed up system suspend/resume process. > > Signed-off-by: Zhonghui Fu <zhonghui.fu@linux.intel.com> > --- > drivers/hid/i2c-hid/i2c-hid.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c > index 2e021ba..cc41e1e 100644 > --- a/drivers/hid/i2c-hid/i2c-hid.c > +++ b/drivers/hid/i2c-hid/i2c-hid.c > @@ -1020,6 +1020,7 @@ static int i2c_hid_probe(struct i2c_client *client, > pm_runtime_get_noresume(&client->dev); > pm_runtime_set_active(&client->dev); > pm_runtime_enable(&client->dev); > + device_enable_async_suspend(&client->dev); > > ret = i2c_hid_fetch_hid_descriptor(ihid); > if (ret < 0) Applied to hid.git#for-4.8/i2c-hid.
diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c index 2e021ba..cc41e1e 100644 --- a/drivers/hid/i2c-hid/i2c-hid.c +++ b/drivers/hid/i2c-hid/i2c-hid.c @@ -1020,6 +1020,7 @@ static int i2c_hid_probe(struct i2c_client *client, pm_runtime_get_noresume(&client->dev); pm_runtime_set_active(&client->dev); pm_runtime_enable(&client->dev); + device_enable_async_suspend(&client->dev); ret = i2c_hid_fetch_hid_descriptor(ihid); if (ret < 0)
i2c-hid devices' suspend/resume are usually time-consuming process. For example, the touch controller(i2c-ATML1000:00) on ASUS T100 tablet takes about 160ms for suspending and 120ms for resuming. This patch enables i2c-hid devices to suspend/resume asynchronously. This will take advantage of multicore and speed up system suspend/resume process. Signed-off-by: Zhonghui Fu <zhonghui.fu@linux.intel.com> --- drivers/hid/i2c-hid/i2c-hid.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html