HID: quirks: Always poll Anne Pro 2(C15) Keyboard

Commit Message

Kortan Dec. 11, 2021, 6:16 a.m. UTC

From: Kortan <[e-mail]>

According to https://openannepro.github.io/ap2_revisionas, Anne Pro 2
keyboard has two hardware revisions, C15(04d9:a292) and C18(04d9:a293).

Previous patch submitted by Sebastian only fix the C18 revision. This
patch add missing C15 revision support.

Fixes: ca28aff0e1dc ("HID: quirks: Always poll Obins Anne Pro 2 keyboard")
Signed-off-by: Kortan <[e-mail]>
---
 drivers/hid/hid-ids.h    | 1 +
 drivers/hid/hid-quirks.c | 1 +
 2 files changed, 2 insertions(+)

Comments

Sebastian Parschauer Jan. 6, 2022, 9:33 p.m. UTC | #1

> Am 11.12.2021 um 07:16 schrieb [e-mail]:
> 
> From: Kortan <[e-mail]>
> 
> According to https://openannepro.github.io/ap2_revisionas, Anne Pro 2
> keyboard has two hardware revisions, C15(04d9:a292) and C18(04d9:a293).
> 
> Previous patch submitted by Sebastian only fix the C18 revision. This
> patch add missing C15 revision support.
> 
> Fixes: ca28aff0e1dc ("HID: quirks: Always poll Obins Anne Pro 2 keyboard")
> Signed-off-by: Kortan <[e-mail]>

Thanks for the patch. I was actually the first one reporting the bug to them. They replied with something like „Why do you do a kernel patch? Nobody reported this bug before. We will fix our firmware.“ That reaction actually surprised me. Does this mean they didn’t?

They didn’t say anything about a second hardware revision which might be affected.

Patch

diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 19da07777d62..3b1335cd19ba 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -644,6 +644,7 @@ 
 #define USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A081	0xa081
 #define USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A0C2	0xa0c2
 #define USB_DEVICE_ID_HOLTEK_ALT_KEYBOARD_A096	0xa096
+#define USB_DEVICE_ID_HOLTEK_ALT_KEYBOARD_A292	0xa292
 #define USB_DEVICE_ID_HOLTEK_ALT_KEYBOARD_A293	0xa293
 
 #define USB_VENDOR_ID_IMATION		0x0718
diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c
index ee7e504e7279..2952ce3aa560 100644
--- a/drivers/hid/hid-quirks.c
+++ b/drivers/hid/hid-quirks.c
@@ -94,6 +94,7 @@  static const struct hid_device_id hid_quirks[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_HAPP, USB_DEVICE_ID_UGCI_FIGHTING), HID_QUIRK_BADPAD | HID_QUIRK_MULTI_INPUT },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_HAPP, USB_DEVICE_ID_UGCI_FLYING), HID_QUIRK_BADPAD | HID_QUIRK_MULTI_INPUT },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_HOLTEK_ALT, USB_DEVICE_ID_HOLTEK_ALT_KEYBOARD_A096), HID_QUIRK_NO_INIT_REPORTS },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_HOLTEK_ALT, USB_DEVICE_ID_HOLTEK_ALT_KEYBOARD_A292), HID_QUIRK_ALWAYS_POLL },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_HOLTEK_ALT, USB_DEVICE_ID_HOLTEK_ALT_KEYBOARD_A293), HID_QUIRK_ALWAYS_POLL },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_HP, USB_PRODUCT_ID_HP_LOGITECH_OEM_USB_OPTICAL_MOUSE_0A4A), HID_QUIRK_ALWAYS_POLL },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_HP, USB_PRODUCT_ID_HP_LOGITECH_OEM_USB_OPTICAL_MOUSE_0B4A), HID_QUIRK_ALWAYS_POLL },