From patchwork Fri Nov 17 20:58:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 10063953 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2C9596037E for ; Fri, 17 Nov 2017 21:00:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1F8DC2ADE9 for ; Fri, 17 Nov 2017 21:00:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 11D7A2ADF5; Fri, 17 Nov 2017 21:00:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BAA082ADE9 for ; Fri, 17 Nov 2017 21:00:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761937AbdKQU7i (ORCPT ); Fri, 17 Nov 2017 15:59:38 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:34461 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761905AbdKQU72 (ORCPT ); Fri, 17 Nov 2017 15:59:28 -0500 Received: by mail-pg0-f66.google.com with SMTP id 4so2800316pge.1; Fri, 17 Nov 2017 12:59:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=vxpOS8PLcNe+jmXIP+9QWAUopOfZBzCDoZVRFKo3uYg=; b=fICt1+hESnsABnSOSyu+/uO1k4dYFagPSuRORNqOI8+zXgYcVyDVZjsD80m798syxp mEJhCRn9d/0hNWHudGrQXnC0EGd4tEW8Nm7rZy4SqK1sYBDmjzGuLR4UJ57fnqKEtzuF AZ4jWZ9uNZ++NMRXIdMbisTr5U1U2IRTdyOLccebRFkBUw/s0NTw22E3zPjp3ehLGLKq D9ouu4xvTob69IqafftQ+GZkUth12NcxYU+U99NBeRHqKuww73SNGACDlozCkxI9EYb0 LYhR4+h7TP+qdNztdHCGweZlEjkVviNgC/5gV0LLyQ2p3MFp4hYXdSgvKiKG/GuXmcgI WWtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=vxpOS8PLcNe+jmXIP+9QWAUopOfZBzCDoZVRFKo3uYg=; b=jkwBQX8gOsJ58FrT5Xf/n+HhBTJVw9Th83d6tAD641SzYkqDhEOErWQCp3Key9zrN3 i1LGc10MKMNxxVEvKUldn6k84x2nFD7U1uWn+qBme98KnmuqzBkuL8hCPlO4tlxOfWXL jyOVFx+0cTn/03I19Nlj4Slw3t+G5BhULPZzowuBz+CKULujSf37N3Qq/a4ZYaKr71B7 0rIAusQowrOelPJI8dASH16Bw61G59hOhGu39IAY7iKIZuATTGjkfNzZz+HHTuO9lqR4 gamJ5uGYJ30LlTv6R7IXi1pkqkzVar01E6uZsYohO7wHyTANYxJ/ID+Pa6U1O1s3+87r Y3Lw== X-Gm-Message-State: AJaThX68TSS++oojdfAqm0gtMF12hROHdgIbB0I8VkYoGF2/YdFhDchy zGQbzHRn88tony4+sFu+9/FoPq8f X-Google-Smtp-Source: AGs4zMY/hiyi4AkTLg8lLrhAC4OcaIk2oNe0fuAX1bTe6Cdl93zDSlLkaAfjk3E47u4/cqh3k7SSIw== X-Received: by 10.84.175.3 with SMTP id s3mr6395895plb.440.1510952368266; Fri, 17 Nov 2017 12:59:28 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id f12sm7650857pga.7.2017.11.17.12.59.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 17 Nov 2017 12:59:27 -0800 (PST) From: Arvind Yadav To: dmitry.torokhov@gmail.com, maxime.ripard@free-electrons.com, wens@csie.org, linux@roeck-us.net, wsa@the-dreams.de, daniel.thompson@linaro.org, mcuos.com@gmail.com Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/10 v2] Input: serio: Fix platform_get_irq's error checking Date: Sat, 18 Nov 2017 02:28:50 +0530 Message-Id: <8104ffc3b7bedee525c0cba9144cedaf04087fd4.1510951446.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct Signed-off-by: Arvind Yadav --- changes in v2 : irq is unsigned. used struct sun4i_ps2data int variable drvdata->irq. drivers/input/serio/sun4i-ps2.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/input/serio/sun4i-ps2.c b/drivers/input/serio/sun4i-ps2.c index 04b96fe..38bb163 100644 --- a/drivers/input/serio/sun4i-ps2.c +++ b/drivers/input/serio/sun4i-ps2.c @@ -210,7 +210,6 @@ static int sun4i_ps2_probe(struct platform_device *pdev) struct sun4i_ps2data *drvdata; struct serio *serio; struct device *dev = &pdev->dev; - unsigned int irq; int error; drvdata = kzalloc(sizeof(struct sun4i_ps2data), GFP_KERNEL); @@ -263,14 +262,13 @@ static int sun4i_ps2_probe(struct platform_device *pdev) writel(0, drvdata->reg_base + PS2_REG_GCTL); /* Get IRQ for the device */ - irq = platform_get_irq(pdev, 0); - if (!irq) { + drvdata->irq = platform_get_irq(pdev, 0); + if (drvdata->irq < 0) { dev_err(dev, "no IRQ found\n"); - error = -ENXIO; + error = drvdata->irq; goto err_disable_clk; } - drvdata->irq = irq; drvdata->serio = serio; drvdata->dev = dev;