From patchwork Mon Mar 10 09:13:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 14009432 X-Patchwork-Delegate: jikos@jikos.cz Received: from PNYPR01CU001.outbound.protection.outlook.com (mail-centralindiaazolkn19010010.outbound.protection.outlook.com [52.103.68.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 234692248BE; Mon, 10 Mar 2025 09:13:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.103.68.10 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741598037; cv=fail; b=mzLezebv89qxxhNRzBOuOGOBtRmBfOcfhXkjBYFsmu3c9ispluKTpMEeD4HKJhaAHCW/0a/+KSNA1LV1a0bvefyULh1QGuCRjR8vAcYE4v3ASgacAwDytMntxdNS1Jw2CbOQNS9Peh/RrHiL5yltAoOnakvcvo+k3FqmPJGnNMI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741598037; c=relaxed/simple; bh=ua7UqOGbXfUtWDjG5OtQcf/vLDUxWuiF4ryfyYw8a+E=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=Q/ZjhOBdTsrChVdzRMbzToCZThsEJ12V0egpxlKAiVRr9ltGZ3WFjiwjc0Qm9ct3keV/qATRY6pXGxnU33uUU7hxGbF6Nr9zzTDg8rI5SiWW8Y2T2EGQOhl0stzzK8NNAnVNmL9uaQjKYyRIWpe4OVol8wWqwWHLz0Bgc/FTmTI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com; spf=pass smtp.mailfrom=live.com; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b=udF0NfEv; arc=fail smtp.client-ip=52.103.68.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=live.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b="udF0NfEv" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QD/4uiJFogSAKcKWtJsuNg4XRO584U/N3YXabhaXsyH1LAU4P4TTGxNGEBV7K3K6mvdTSj3eZ4rWAZyUb3eN2mpDsYhCby3T8J/PGUlMHVCediyO+y1cRuOiD5y8efCloRK7i0zVGnZzjiL9+ppagavX3KZqfOQUHnp7A+5G/oqduyN6dFjZVTwl3/R+eA6tS04MV1sWJ0isk2RlMCAdN4k92kKjM0bAbu0eRCk/CFD8gCg+fqFOSvwba5tyTg8nd1anRClof+ZZUz3PQCOnnPfL/EUX+aJiyGK4tdFzATVVYg8/IJHa6gZxrE+G0hz3NrJ1NgF/i6M7YGVQLBkdVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/04ZaODBq15k3NKBD3BcMjYaW2C7mTU+vyha+u7ypE8=; b=wSB6CWaELiRDGIfuWsMp0CCmug0gBKeTZhv1/aVHFYAnJeGXY2MDEogAxnCbU8V7ncdv6w7bkROn/flIpBcjAgkibP0aqaj+63rRueXdxgIOP8ECeZTeoaVMnDNo6h2QeQjErKF3TchZ4XK7eMXhoOuYQo1n8ougX3oCfcvag1Ro9yx0rAeadbAIDxcocyGkEmKIXgJrVsD9AqDwdAcBDG9HJ1WHh4l2lheADwb6mP7tZhG0OiGFTA3YgHedVrvaLXqCNL1c1BlaM/n4wwrL3e6D1/fYLwBvDJiklCBwaqeIw5koGzfLep1+eE9EgvndxPx7wgQ23mfr6+lOM35Sfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/04ZaODBq15k3NKBD3BcMjYaW2C7mTU+vyha+u7ypE8=; b=udF0NfEv6GM4RNjpyD2HrDRhUjO4QVEY8xfto0TCUxZRQfGu7Y5cdpJTMjLMnmuTiz42/rRSYcbxlZT5daG95tRJXTAFKOdnxqzF83ggpBRBqGVbbWvR0fKGpCe76B2+w2e3gCPEBgzBDYjONyj0+O3rILEXJoYrgv+2rmf4mbxAS4VUb3emahfiwcK1eNi7pDU99FTwbltq+K/z0kwg5T8fmIjv9HBgklG9s/1cDuKmIqSCUVpbSZe/ypHihso7T1yWTgZdyff99zATrju7mXeoO7JebDZohT0gDsV77bEc6eF60C/3oXtYPXElIa21b6GmTyWkhmN4W7iBgAFL9A== Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) by MAYPR01MB10587.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:159::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.26; Mon, 10 Mar 2025 09:13:51 +0000 Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77]) by PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77%7]) with mapi id 15.20.8511.025; Mon, 10 Mar 2025 09:13:51 +0000 From: Aditya Garg To: Jiri Kosina , Jiri Kosina , Benjamin Tissoires , "bentiss@kernel.org" CC: Kerem Karabay , Orlando Chamberlain , Aun-Ali Zaidi , Linux Kernel Mailing List , "linux-input@vger.kernel.org" Subject: [PATCH RESEND 4/5] HID: multitouch: specify that Apple Touch Bar is direct Thread-Topic: [PATCH RESEND 4/5] HID: multitouch: specify that Apple Touch Bar is direct Thread-Index: AQHbkZy9rKvCUya3yk2OcQDLXpf2Yg== Date: Mon, 10 Mar 2025 09:13:51 +0000 Message-ID: <89CE1782-36FD-4CE7-8BB6-F46D983DA00C@live.com> References: In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PN3PR01MB9597:EE_|MAYPR01MB10587:EE_ x-ms-office365-filtering-correlation-id: 3b707b65-d165-45ea-588e-08dd5fb3dfa0 x-microsoft-antispam: BCL:0;ARA:14566002|15080799006|19110799003|8060799006|8062599003|7092599003|461199028|102099032|3412199025|440099028; x-microsoft-antispam-message-info: loaxlwgObdQsMEE5vUWt45XOomQspAXrmvZCAjYysxfgoY0SbNFnCf3RSwGPFf9JHEi8sh9zTKMgC9Uy9SuGNxmxavyIPJ1kU3nQtm2wzB2XADqJkDZDI3turGpZQkW1FOOTOgcYtHewqxfmJMkNSVjO6OpPzbzs22yvoaKNT1hbadOX57WrR5A6C/Gg9UDDrYomZ0YZN1QQDgk5jMrHPNj9+6YbHdvN7ZHlltF+XMy2t3bGoacDrtodU3BUKeNZQG0wivADoZVp2TiwP+dAyLgl5JbvrCyaXDIJmY/nF24ZLKn5JR5wEx5S9qN3WWsY7N4WJ6TnX5QEuTvtLH8qPaFn1iJPFIoW7ijmXrUk2+c8s6f9EDVdx25ssye1Ysht4RLagLpO5iSKdApSvduhbDbKfd/U0FGcjEthoRjDnVlPGmEy34r37o36FS+1QAHXg5dbH8vGfxYdmcTORayHecLe60x1bjjEySbOUuCRzlEFsclDqhR7XrFR6KO/Y9l+Ms9sZtSl3tgbWydxroc6KHPB3u+vYZbgtN2GCDJ5Q/MJ7Q2h+RMerMG48j9i8NuA2AC6poYIQQ/P8JDh17JA0WlDSmr+Eer+o3xuy4XZtgvpIeW3p2Pda8O/UErvqrPOSAGwryjVFMTR9Rq6NpbmJSRmhWQwdPnkldan+EcVLV94P27hc9k9yz3QC7d1kQExaIwr8jHpbC+Qyni2j3oWfq+NP5T4sJ7qBDgc7BoI3l7S624Ub8yggrGG/b8K7P28BAnQQzV+hcQQrxNPBH395xCxZLgT5Ct+DrNEioPQf9dRh4WdCdYqJY7YhDlTYKxyJKpdqNaeJUUCxNI642O8y42NGIvhFLjv3X6IG7dA/smqHfzCMdmgO9v9ioJYUvpHH6byohc8KLLwxo5mHymoR5PEtqIaoMAgUKuWSlkpKoHD+6TyIW7ugOTftIMfkW6IOXBcCRePti0Ou7BmbC3LneGGlcBz8ug9RHiu+fDFfJ/EtDP8usCXP6QFxWWvcYIfIJdBa2M7JKIcvSO6IOJFd6WsLrfARH4a2o3g2yeZuRgvob5yRUXWWyri3WUra+q0x2JBk9Ev6HW64j0dK6KmQg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: g+JoKjAEwUnI410BS6qYUcnMlKaGNbhkZlLcEh0PZx8vcU5CRTnEm83hzpUsCJ82eD4l3NrbNjMhKXHV0mP/yZ95RJgHk5IXJppcRslmA/ockdFLXFyDHArAx0EUVgbCLHdMRVGplwiQH5Ru7fX4IFRyx8nerrhd8oKokdVSHc48MpVpu44AfwdeyJkuqQRjnS88QXTa1BctFp+PqbMGUH2SOjjgjbosYaXTodaOfeEzSMhW7DoOy+PnZv/sA+lW5y/sp75kUMDmpcQVeMoKjzF0jQE/3sk69i7dsA2ij4C0TeHhvEdvf1SDvUnBadLB8Cb77AsqVKaZpSQqPwrT+oZsv9YYu+V3d/IczUAJB95ujEn8MlpWIGq2POzQ8vnVKW/QEWxmgeU1qjHqVQcIVmtsVNcVc6/wVydive2r1nC57S1Oiar7cOBKDq0IBPbrE+XIC0UUUJ6W+MmzE0/VS9FKeDczpbe6FZkv+zHSzfMc5vw8Vo5mNvpnZ9m2sN7wfk52jP2RPea6HKPNbsiXOwB2Vowev2opa1HpNm/lsFzo8IIBXS0BG3XxNWzg10iwVJPE85C5sZk7fDHMKBPS/xmUdGO0Ra7Fbu7SZhudYyCJWx+X68LmkaHlJ439hSZgXvnxBcvv0Jbe8ImlL0Fu7yh4Ygk/ezZroa5GgI1bxf6hblY4TR4eKzWKhz8SAXSMC/Aq1wMlh0+iXy38Vxv9/2eCVFtBDTIDNTrtxBevdqgiqPuzJ2xCFjPnfHwpNI36PBoZqbA8yL52Ycl9ZGbVHMPvOdFcWPmNwqe4Yu+LsVuZavi9RXCJXiOA8fWU0DZikHodzYpx3rOgSLw5PzLP9+rbQFSbi3GkrFCYT/ZWR10DY/lzLcTA4NPdrd6AxTLUUaa8lrZRiWd/RrTNYxlaQPWewMc7qTrbXIGtnvRGOK3LkebudvPv5ez2YQoTpzMgcJQ2BwHhhq1Q56/Mc29+H1uM8bUcH5UYqg6c5T598KNQ/WlF8fff1cVFL16C88OkZyhNjI1yuw/6wCYyd2Ha8Fh4pPkGA5R5hvGOcCExaDExxGQiyatHeTjca4KoW1V60rTwu3XPgwXuFzSFUA7B3MqPmvKpUiPnv+HFbVXRjyOIoaqrDR3x4VZIHEnVPp0V2ss2bwpF5DC8OTIYIEyWjUFbO9AGNvolDcaPL/giBbNEOb3krsX72Z2cNiGr5oIv2HxhOPoIB3fE49rYf3ghzy3UhWtW9J/DU07UnYX1hM4h+3qIueeYwvqm3PGs0GNV Content-ID: <82B69BD6BA976046B24B38A11579120E@INDPRD01.PROD.OUTLOOK.COM> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 3b707b65-d165-45ea-588e-08dd5fb3dfa0 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Mar 2025 09:13:51.1893 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MAYPR01MB10587 From: Kerem Karabay Currently the driver determines the device type based on the application, but this value is not reliable on Apple Touch Bar, where the application is HID_DG_TOUCHPAD even though this device is direct, so add a quirk for the same. Signed-off-by: Kerem Karabay Co-developed-by: Aditya Garg Signed-off-by: Aditya Garg --- drivers/hid/hid-multitouch.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index f7fe6aab8..66e33a482 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c @@ -1349,6 +1349,13 @@ static int mt_touch_input_configured(struct hid_device *hdev, if (td->serial_maybe) mt_post_parse_default_settings(td, app); + /* + * The application for Apple Touch Bars is HID_DG_TOUCHPAD, + * but these devices are direct. + */ + if (cls->quirks & MT_QUIRK_APPLE_TOUCHBAR) + app->mt_flags |= INPUT_MT_DIRECT; + if (cls->is_indirect) app->mt_flags |= INPUT_MT_POINTER;