| Message ID | AANLkTinfLunV5viac9vrvGfOwd-Z17ryJdfro9gtp+yB@mail.gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello Benjamin, On Fri, 2011-02-18 at 21:03 +0100, Benjamin Tissoires wrote: > On Fri, Feb 18, 2011 at 17:15, Bastien Nocera <hadess@hadess.net> wrote: > > On Tue, 2011-02-08 at 15:47 +0100, Benjamin Tissoires wrote: > >> Hi Bastien, > >> > >> Can you give a try to the attached patch (it goes on top of the previous patch). > >> It would be great if you could play a little with mtdiag (or any other > >> multitouch application) and tell me if there is any problem. > > > > The patch to work well, at least for touches with a single finger. I > > launched mtdiag, but I have absolutely no idea what to test with it. > > > > Hints? > > > > > > Hi, > > If you run mtdiag as root, your multitouch panel should appear with a > button "activate". > Click on activate, and it will show up a canvas in which the different > touch you made on the panel will be represented by a circle. The > bigger circle represents the mouse emulation of the device. I finally took the time to build and test those patches you sent me, on top of the Fedora 15 kernel, and they work great. When in fullscreen, mtdiag works as expected though the roughness of touch is probably because my screen is dirty as hell :) Could you please get those pushed upstream? Thanks for the work. Cheers -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Bastien, On Thu, May 19, 2011 at 00:14, Bastien Nocera <hadess@hadess.net> wrote: > Hello Benjamin, > > On Fri, 2011-02-18 at 21:03 +0100, Benjamin Tissoires wrote: >> On Fri, Feb 18, 2011 at 17:15, Bastien Nocera <hadess@hadess.net> wrote: >> > On Tue, 2011-02-08 at 15:47 +0100, Benjamin Tissoires wrote: >> >> Hi Bastien, >> >> >> >> Can you give a try to the attached patch (it goes on top of the previous patch). >> >> It would be great if you could play a little with mtdiag (or any other >> >> multitouch application) and tell me if there is any problem. >> > >> > The patch to work well, at least for touches with a single finger. I >> > launched mtdiag, but I have absolutely no idea what to test with it. >> > >> > Hints? >> > >> > >> >> Hi, >> >> If you run mtdiag as root, your multitouch panel should appear with a >> button "activate". >> Click on activate, and it will show up a canvas in which the different >> touch you made on the panel will be represented by a circle. The >> bigger circle represents the mouse emulation of the device. > > I finally took the time to build and test those patches you sent me, on > top of the Fedora 15 kernel, and they work great. When in fullscreen, > mtdiag works as expected though the roughness of touch is probably > because my screen is dirty as hell :) Great. (not your dirty screen of course ;-D ) > > Could you please get those pushed upstream? Will do it right now. Cheers, Benjamin > > Thanks for the work. > > Cheers > > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index a721710..3b73c88 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c @@ -70,6 +70,7 @@ struct mt_class { #define MT_CLS_DUAL_INRANGE_CONTACTID 2 #define MT_CLS_DUAL_INRANGE_CONTACTNUMBER 3 #define MT_CLS_CYPRESS 4 +#define MT_CLS_DUAL_NSMU_CONTACTID 5 /* * these device-dependent functions determine what slot corresponds @@ -119,6 +120,10 @@ struct mt_class mt_classes[] = { .quirks = MT_QUIRK_NOT_SEEN_MEANS_UP | MT_QUIRK_CYPRESS, .maxcontacts = 10 }, + { .name = MT_CLS_DUAL_NSMU_CONTACTID, + .quirks = MT_QUIRK_NOT_SEEN_MEANS_UP | + MT_QUIRK_SLOT_IS_CONTACTID, + .maxcontacts = 2 }, { } }; @@ -467,7 +472,7 @@ static const struct hid_device_id mt_devices[] = { USB_DEVICE_ID_CYPRESS_TRUETOUCH) }, /* Elo TouchSystems IntelliTouch Plus panel */ - { .driver_data = MT_CLS_DEFAULT, + { .driver_data = MT_CLS_DUAL_NSMU_CONTACTID, HID_USB_DEVICE(USB_VENDOR_ID_ELO, USB_DEVICE_ID_ELO_TS2515) },