| Message ID | CADYu30-dyHvidn6z6NW0w8hEwFd6Nctf8_5Yb5LKU4MFKvwLHw@mail.gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Dear Mr. Torokhov and Linux-Input Community, Greetings of the day !! Kindly update about the below patch. Thank you, Aniroop Mathur On Sat, Nov 22, 2014 at 12:18 AM, Aniroop Mathur <aniroop.mathur@gmail.com> wrote: > > This patch initializes input_no by -1 in order to avoid extra subtraction > operation performed everytime for allocation of an input device. > > Signed-off-by: Aniroop Mathur <aniroop.mathur@gmail.com> > --- > drivers/input/input.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/input.c b/drivers/input/input.c > index 29ca0bb..01fe49e 100644 > --- a/drivers/input/input.c > +++ b/drivers/input/input.c > @@ -1774,7 +1774,7 @@ EXPORT_SYMBOL_GPL(input_class); > */ > struct input_dev *input_allocate_device(void) > { > - static atomic_t input_no = ATOMIC_INIT(0); > + static atomic_t input_no = ATOMIC_INIT(-1); > struct input_dev *dev; > > dev = kzalloc(sizeof(struct input_dev), GFP_KERNEL); > @@ -1789,7 +1789,7 @@ struct input_dev *input_allocate_device(void) > INIT_LIST_HEAD(&dev->node); > > dev_set_name(&dev->dev, "input%ld", > - (unsigned long) atomic_inc_return(&input_no) - 1); > + (unsigned long) atomic_inc_return(&input_no)); > > __module_get(THIS_MODULE); > } > -- > 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Aniroop, On Sat, Nov 22, 2014 at 12:18:39AM +0530, Aniroop Mathur wrote: > This patch initializes input_no by -1 in order to avoid extra subtraction > operation performed everytime for allocation of an input device. > > Signed-off-by: Aniroop Mathur <aniroop.mathur@gmail.com> It looks like you rmail client converted all tabs to spaces so the patch can't be applied as is. Could you please fix and resend. Thanks. > --- > drivers/input/input.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/input.c b/drivers/input/input.c > index 29ca0bb..01fe49e 100644 > --- a/drivers/input/input.c > +++ b/drivers/input/input.c > @@ -1774,7 +1774,7 @@ EXPORT_SYMBOL_GPL(input_class); > */ > struct input_dev *input_allocate_device(void) > { > - static atomic_t input_no = ATOMIC_INIT(0); > + static atomic_t input_no = ATOMIC_INIT(-1); > struct input_dev *dev; > > dev = kzalloc(sizeof(struct input_dev), GFP_KERNEL); > @@ -1789,7 +1789,7 @@ struct input_dev *input_allocate_device(void) > INIT_LIST_HEAD(&dev->node); > > dev_set_name(&dev->dev, "input%ld", > - (unsigned long) atomic_inc_return(&input_no) - 1); > + (unsigned long) atomic_inc_return(&input_no)); > > __module_get(THIS_MODULE); > } > -- > 1.9.1
diff --git a/drivers/input/input.c b/drivers/input/input.c index 29ca0bb..01fe49e 100644 --- a/drivers/input/input.c +++ b/drivers/input/input.c @@ -1774,7 +1774,7 @@ EXPORT_SYMBOL_GPL(input_class); */ struct input_dev *input_allocate_device(void) { - static atomic_t input_no = ATOMIC_INIT(0); + static atomic_t input_no = ATOMIC_INIT(-1); struct input_dev *dev; dev = kzalloc(sizeof(struct input_dev), GFP_KERNEL); @@ -1789,7 +1789,7 @@ struct input_dev *input_allocate_device(void) INIT_LIST_HEAD(&dev->node); dev_set_name(&dev->dev, "input%ld", - (unsigned long) atomic_inc_return(&input_no) - 1); + (unsigned long) atomic_inc_return(&input_no)); __module_get(THIS_MODULE); }
This patch initializes input_no by -1 in order to avoid extra subtraction operation performed everytime for allocation of an input device. Signed-off-by: Aniroop Mathur <aniroop.mathur@gmail.com> --- drivers/input/input.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)