diff mbox

hig_magicmouse HID_BATTERY_QUIRK_IGNORE

Message ID CAJxTCxxN7=fjNFQ4BJPKfU0jHY=uAQNq_g3iN_0mYhSHdc28ug@mail.gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jérémy Lal Nov. 22, 2016, 11 p.m. UTC 
Hi,
i've been using this patch for a while, as a workaround for
https://bugzilla.kernel.org/show_bug.cgi?id=103631
(mouse freeze when battery reports).



Greetings,
Jérémy

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Bastien Nocera Nov. 23, 2016, 12:24 a.m. UTC | #1 
On Wed, 2016-11-23 at 00:00 +0100, Jérémy Lal wrote:
> Hi,
> i've been using this patch for a while, as a workaround for
> https://bugzilla.kernel.org/show_bug.cgi?id=103631
> (mouse freeze when battery reports).
> 
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -321,6 +321,9 @@
>  { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
>    USB_DEVICE_ID_APPLE_ALU_WIRELESS_ANSI),
>    HID_BATTERY_QUIRK_PERCENT | HID_BATTERY_QUIRK_FEATURE },
> +  { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
> +    USB_DEVICE_ID_APPLE_MAGICMOUSE),
> +    HID_BATTERY_QUIRK_IGNORE },
>  { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_ELECOM,
>    USB_DEVICE_ID_ELECOM_BM084),
>    HID_BATTERY_QUIRK_IGNORE },

Doesn't that also stop the mouse from reporting its battery status?
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jérémy Lal Nov. 23, 2016, 12:33 a.m. UTC | #2 
2016-11-23 1:24 GMT+01:00 Bastien Nocera <hadess@hadess.net>:
> On Wed, 2016-11-23 at 00:00 +0100, Jérémy Lal wrote:
>> Hi,
>> i've been using this patch for a while, as a workaround for
>> https://bugzilla.kernel.org/show_bug.cgi?id=103631
>> (mouse freeze when battery reports).
>>
>> --- a/drivers/hid/hid-input.c
>> +++ b/drivers/hid/hid-input.c
>> @@ -321,6 +321,9 @@
>>  { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
>>    USB_DEVICE_ID_APPLE_ALU_WIRELESS_ANSI),
>>    HID_BATTERY_QUIRK_PERCENT | HID_BATTERY_QUIRK_FEATURE },
>> +  { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
>> +    USB_DEVICE_ID_APPLE_MAGICMOUSE),
>> +    HID_BATTERY_QUIRK_IGNORE },
>>  { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_ELECOM,
>>    USB_DEVICE_ID_ELECOM_BM084),
>>    HID_BATTERY_QUIRK_IGNORE },
>
> Doesn't that also stop the mouse from reporting its battery status?

Yes, it does. Still better than having it stop abruptly from time to time.

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -321,6 +321,9 @@ 
 { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
   USB_DEVICE_ID_APPLE_ALU_WIRELESS_ANSI),
   HID_BATTERY_QUIRK_PERCENT | HID_BATTERY_QUIRK_FEATURE },
+  { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
+    USB_DEVICE_ID_APPLE_MAGICMOUSE),
+    HID_BATTERY_QUIRK_IGNORE },
 { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_ELECOM,
   USB_DEVICE_ID_ELECOM_BM084),
   HID_BATTERY_QUIRK_IGNORE },