From patchwork Sat Nov 10 08:03:47 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 1723331 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id AD421DF230 for ; Sat, 10 Nov 2012 08:03:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751969Ab2KJIDs (ORCPT ); Sat, 10 Nov 2012 03:03:48 -0500 Received: from mail-ia0-f174.google.com ([209.85.210.174]:44466 "EHLO mail-ia0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751682Ab2KJIDr (ORCPT ); Sat, 10 Nov 2012 03:03:47 -0500 Received: by mail-ia0-f174.google.com with SMTP id y32so3284758iag.19 for ; Sat, 10 Nov 2012 00:03:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=AaMdx6dyxRXLsyT5nYQa7zsX2KOWxTOeTZjryjE1M3s=; b=kH9hgjDLfjfkE0gNE2pPyc3QvQFTvWDGZvBRadHJvJOqFoP5CqDcaJx8N+jshVvCUg e9rz6N8QZr8Q3c86FuqiRlC6oc+BOonyzVKKwKxfWiJdU9feQUphVO/UBGMHThUvFlCQ WCUNRGqDW+qrILmdKPxXsn2XOzbVvJ5JPcOOVPN0JrxJEr0mGt90hKzXUy6IJHhyu5Uu 7/eCUawOp8vmpeN/9yI9OQIW7IBq6yYjbjwUl7mdqY7yiL7EOxuNXd006jn0D389r8N4 ZaaA83Aj8ElBjA2OQnKG3UfmiZ4M1tPVVmAVE+rjvQiLXi0gziYttvRbH99xre0kv8Pu Nunw== MIME-Version: 1.0 Received: by 10.50.37.196 with SMTP id a4mr2911912igk.16.1352534627171; Sat, 10 Nov 2012 00:03:47 -0800 (PST) Received: by 10.64.136.210 with HTTP; Sat, 10 Nov 2012 00:03:47 -0800 (PST) In-Reply-To: <20121110080009.GA12015@core.coreip.homeip.net> References: <3d6f34ca5960203a5efb761f4d56b4e10ee24827.1352474824.git.viresh.kumar@linaro.org> <52b9fe53a8bd8dff7105209c5b1fab9da7a1510d.1352474824.git.viresh.kumar@linaro.org> <20121110080009.GA12015@core.coreip.homeip.net> Date: Sat, 10 Nov 2012 13:33:47 +0530 Message-ID: Subject: Re: [PATCH 2/3] input: stmpe-ts: Use devm_*() routines From: Viresh Kumar To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, spear-devel@list.st.com X-Gm-Message-State: ALoCoQkq8RBLCnXorNveG4evPQ2RvKErE5Nu+Qo6QjD8HHsH3YpqQMWWSWerfdLzCn/Iqnbcc3vt Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 10 November 2012 13:30, Dmitry Torokhov wrote: > Sometimes your mailer does wrap long lines, please make sure to turn it > off for patches. I am using gmail for replying on mails and this fixup was done using that. Don't know why it happened. I am doing the same step again to verify what's playing with patches. On this copy i can see that this issue isn't there till now. commit dda6d45808d65aaf8b0d4153e7a418b255365818 Author: Viresh Kumar Date: Fri Nov 9 22:28:26 2012 +0530 fixup! input: stmpe-ts: Use devm_*() routines --- drivers/input/touchscreen/stmpe-ts.c | 2 -- 1 file changed, 2 deletions(-) -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c index 9896095..f2cb15d 100644 --- a/drivers/input/touchscreen/stmpe-ts.c +++ b/drivers/input/touchscreen/stmpe-ts.c @@ -344,8 +344,6 @@ static int __devexit stmpe_ts_remove(struct platform_device *pdev) stmpe_disable(ts->stmpe, STMPE_BLOCK_TOUCHSCREEN); - input_unregister_device(ts->idev); - return 0; }