From patchwork Mon Oct 16 09:46:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mustafa Kuscu X-Patchwork-Id: 10007967 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AD6A160235 for ; Mon, 16 Oct 2017 09:46:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9C68E28417 for ; Mon, 16 Oct 2017 09:46:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9138E2841E; Mon, 16 Oct 2017 09:46:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 35B4E28417 for ; Mon, 16 Oct 2017 09:46:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751411AbdJPJqL (ORCPT ); Mon, 16 Oct 2017 05:46:11 -0400 Received: from mail-wm0-f54.google.com ([74.125.82.54]:51241 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751410AbdJPJqK (ORCPT ); Mon, 16 Oct 2017 05:46:10 -0400 Received: by mail-wm0-f54.google.com with SMTP id f4so1273406wme.0 for ; Mon, 16 Oct 2017 02:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=QOT4tzoDHWL1/a7a4FDTxZO6yynoMvxXJ5d3wV5YYn0=; b=Beh2KmAVxvGW0DOz1vx/5xdMQrQ8LNaqSjSXBdSY/9VEWdIATElsuopf+z20ngoC26 mhPz7oG9VD1gzYOpxk4RqkIFgW1+bmVDUpskHWUTtN+43VP8/xtwSLWpCuMkfPyDzS95 5gq74qc56gzrqfxYbVLCXZ322d/fVHLhhK4Njc2OVDNNwg4lYnCH+BxCSu+ndsmBzlup nvAQPgT2oSJ8XSfcSI9+ilc7I0iqVUzB4pNKZHoQcOKIoXYqM+qdCh99D2bq34k4MbG+ GqAybnuS80CNQDYsmPnopg/tJ4yTNIFHXqUR6U/OAuCW9lqzMXL2kUB9stAJN95m8oFL AuIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=QOT4tzoDHWL1/a7a4FDTxZO6yynoMvxXJ5d3wV5YYn0=; b=PnBfgTeZc7d8cO2VKvPk54vsISvIQ3QjMghQKUeiz841kymqmMTGly4bn+7X3TXYt3 UqonngjlR189u0GAz4oy0kTmsvDR8UZdrNXwZS2jyT62b/E2ozBE4ww4iMTHXsqqwpRu +uMaqtuY8kgU8S5CdII52XjD2UqKFdpI+DKEIJT/21lD2ies0hIGGMccTd2UPRmmzx5K OnwW02MsKirD8LfxwuUqhfFfvlCjqURcObl78wJTqqOq/Jru9Vr2U7ce3e7ufh/Vjzsc PHEKOaZkAiqN3OgPK15B6OrvArpKWz1Vaer6P71RuEuo1qL616D4VDvBEj1YGWsgSkxZ NiiA== X-Gm-Message-State: AMCzsaUr/4pQGOoIHmS2J0V02xyQzKHU5E0UnN5Smc1Stp1gDPb/4+JO IpJgofeZynd0DD/+4be3T87yCrvb1DdZlaiUZ89e9KOvn5s= X-Google-Smtp-Source: ABhQp+QHEHM+O5Mtzg9FQXv+RynZyWWiysGf2HeGm/DX1nsnuo4dPaFjKHfRppmzZHVQ8wzszqieNtAUxpSPS2Hipz8= X-Received: by 10.223.134.84 with SMTP id 20mr18594wrw.60.1508147169521; Mon, 16 Oct 2017 02:46:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.226.87 with HTTP; Mon, 16 Oct 2017 02:46:08 -0700 (PDT) From: Mustafa Kuscu Date: Mon, 16 Oct 2017 12:46:08 +0300 Message-ID: Subject: [PATCH] asus rog laptops GL55x keyboard backlight fix To: linux-input@vger.kernel.org Cc: trivial@kernel.org Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Dear all, Some ASUS ROG laptops have a backlit keyboard which is detected fine but Fn + F3/F4 does not work in setting up backlight level. It appears that after making the one liner change below, the backlight level can be controlled by the Fn keys. It is intended only to the following device: 0x0b05 1854, P: Vendor=0b05 ProdID=1854 Rev=03.02 S: Manufacturer=ITE Tech. Inc. S: Product=ITE Device(8910) which is already captured as HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD2), However, the QUIRK is only present for ROG KEYBOARD2. { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD1) }, { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD2), QUIRK_USE_KBD_BACKLIGHT }, It appears that the device is only used by hid-asus.c. Hope this helps to other people having the same issue. Mustafa --- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- hid-asus.c.orig 2017-10-16 12:20:14.631341280 +0300 +++ hid-asus.c 2017-10-16 12:20:24.814674504 +0300 @@ -593,7 +593,7 @@ static const struct hid_device_id asus_d { HID_I2C_DEVICE(USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_I2C_TOUCHPAD), I2C_TOUCHPAD_QUIRKS }, { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, - USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD1) }, + USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD1), QUIRK_USE_KBD_BACKLIGHT }, { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD2), QUIRK_USE_KBD_BACKLIGHT }, { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK,