From patchwork Fri Jan 12 19:33:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mustafa Kuscu X-Patchwork-Id: 10161575 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 10DE2602D8 for ; Fri, 12 Jan 2018 19:33:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F3A9E28A4B for ; Fri, 12 Jan 2018 19:33:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E740928A3A; Fri, 12 Jan 2018 19:33:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9539D28A3A for ; Fri, 12 Jan 2018 19:33:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965081AbeALTd3 (ORCPT ); Fri, 12 Jan 2018 14:33:29 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:42154 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964998AbeALTd2 (ORCPT ); Fri, 12 Jan 2018 14:33:28 -0500 Received: by mail-wm0-f67.google.com with SMTP id b141so14297975wme.1; Fri, 12 Jan 2018 11:33:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=tQUCBH65y6NEz0FNOHGnOWM+Bfi+4KN8MiGcMIEyr+M=; b=pLHqovy7do6x7eRa2I50LFsIiyqyzW919hHZLrp35RGEZmVrFZKPAT70xwCQmYr0ch WJUHEHWgndiLtWrOnBowA/9VL1zqFzPgQd3PU524NntM8YlaVevcMvK7+oYydpDQ+TB5 IBX4T6b7j/+gdQJzzZVhH2pZX3MQ4Lp1dTML8X76LY3eADrnksj1wsBHtqu6Mn9ta9dY A07zTnnSuGZm149Mk8wQb6lcWkgs9ZSv2AK4BgGKLj7Zsjsws68DUG7jR2vFLA7KOXNt zx8JF/Sif4ijlhVPe6ZbmQFs65TSmzCtn8Ns1GZEHwKY8xCFOQGMnQvl93DCGbXkCGd9 1JlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=tQUCBH65y6NEz0FNOHGnOWM+Bfi+4KN8MiGcMIEyr+M=; b=S4ZWEvh/Kw75MaOVPNqXo3e8X6lEVg2esePVk6vkIYOxA0j/1TJGOpR1r1tyuPVh/h v4gAp9LUTaiXc33N9rl+fgr6Qcf1fywvKj9sfhJQ+HQci+ECtaBiQbxhQIhKlo+vzGvZ J3rVdFHx3xlBUebc3glKG3DQwnD1zsmR0XQEaQd0PIg6SQ3EZTj/JjCATNMFosKFE621 8chaovMru7VRxcllQZawdwHnaIy2df03//YiSWRauC50KzJpxgVKWxbe+4gdfNaci/nH XTBB4WFpIt/e+EkQWgL68U7xilCs/9nxwrukWyN8ZtMn0Bq+DFjR8SupHzcO6KiQ9MGy eT9Q== X-Gm-Message-State: AKwxytdGKtOXZ9SZGBM+2FU4UXKoMnj/F7aEB0oUvbI8fTbq1U1yFLct x2giK1ssd0woRj+P2JBnjWEzqdPnH55XDVtmk7/HFiTBEFo= X-Google-Smtp-Source: ACJfBosm9OJGBphKQwH5jBymDLM3NDArE2GL4Eu5Kx3ZvaZ1RLik0VPjzg35LK/zB68yg3zsardnC+KO5Ht1LfdraWE= X-Received: by 10.28.58.196 with SMTP id h187mr5388566wma.107.1515785606441; Fri, 12 Jan 2018 11:33:26 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.154.85 with HTTP; Fri, 12 Jan 2018 11:33:25 -0800 (PST) In-Reply-To: References: <20180109012042.13947-1-drake@endlessm.com> From: Mustafa Kuscu Date: Fri, 12 Jan 2018 22:33:25 +0300 Message-ID: Subject: Re: [PATCH] HID: asus: only support backlight when it's not driven by WMI To: Andy Shevchenko Cc: Daniel Drake , Jiri Kosina , Benjamin Tissoires , linux-input , Linux Upstreaming Team , Carlo Caione , Corentin Chary , acpi4asus-user , Platform Driver Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Jan 9, 2018 at 10:58 PM, Andy Shevchenko wrote: > On Tue, Jan 9, 2018 at 9:41 PM, Daniel Drake wrote: >> On Tue, Jan 9, 2018 at 1:32 PM, Andy Shevchenko >> wrote: >>> Imagine someone who on possession of laptop where it's not needed >>> having old kernel configuration. >>> Building new kernel with old configuration will bring a regression. >>> >>> Selection is also not a solution since we don't need all crap in >>> kernel because of some particular case. >>> >>> So, NO. >> >> If I can't use depends nor select, then what options are left? What >> alternative solutions do you have in mind? > > If you would able to move code under corresponding WMI driver, make it > use any means of autodetection (it looks like you found a way via > checking return code of method call) and > then rely on distributions that they enable necessary modules > (HID_ASUS, ASUS_WMI or alike). > > -- > With Best Regards, > Andy Shevchenko > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Hi, It is interesting that the backlight buttons did not work for you. I think your keyboard (0b05:1837)is a USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD2. I also have a ROG laptop (GL553VD) whose keyboard (0b05:1854) is being identified as USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD1. Its keyboard backlight shortcuts are enabled only after applying the following patch. I am wondering why this harmless one liner did not find its way into the modules tree. It's difficult to apply the patch to every keep up with the latest. Maybe other ASUS people confirm this and help pushing it further.. Kind Regards... Signed-off-by: Mustafa C Kuscu --- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index a4a3c38bc145..39068eddc03c 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -593,7 +593,7 @@ static const struct hid_device_id asus_devices[] = { { HID_I2C_DEVICE(USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_I2C_TOUCHPAD), I2C_TOUCHPAD_QUIRKS }, { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, - USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD1) }, + USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD1), QUIRK_USE_KBD_BACKLIGHT }, { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD2), QUIRK_USE_KBD_BACKLIGHT }, { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK,