From patchwork Sun Oct 22 05:49:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mustafa Kuscu X-Patchwork-Id: 10021605 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9C56E60245 for ; Sun, 22 Oct 2017 05:49:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 77CF12862A for ; Sun, 22 Oct 2017 05:49:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6A53328732; Sun, 22 Oct 2017 05:49:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 182532862A for ; Sun, 22 Oct 2017 05:49:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751076AbdJVFtJ (ORCPT ); Sun, 22 Oct 2017 01:49:09 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:45098 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751070AbdJVFtJ (ORCPT ); Sun, 22 Oct 2017 01:49:09 -0400 Received: by mail-wr0-f195.google.com with SMTP id y9so2192136wrb.2 for ; Sat, 21 Oct 2017 22:49:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=/jQAw++lPnwWmmaL93dEfn8rZSAvtRWpx4pnmQgILKM=; b=uv6seVNLsvAyZ7THRFcJ0yK/fURJF7jpIlci+KejsPgZiEQUkf0OF0RGFe+ked+cxJ RYiFVtNYsRVY2B3DZuNn9d32bBbsWdojfD5BMhI7v8A4b+caFl4s51HoJhfEAdPJpfpz QJsljjClXx9MioW1JncdHFROzv9XXyEbh8w3TQAcZ+92RpyUqaYjhqIokAN0JKb2f7y8 c7RnaVvYLxq76L88hnL7vOpkOyBMX3XlnxkopRwbZQup/0++47aaRwGGvoQGT1CXY5M8 75aL3DbolMgW6B2XF6BMKJrZQQlvmkIsr7wz9Y6KUGJ8lTCwpV2kbofKD7/5bu55B5Pb ZYXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=/jQAw++lPnwWmmaL93dEfn8rZSAvtRWpx4pnmQgILKM=; b=Sd4g2X/bJ/OSl7PIMYpeDyqWKNRQlLEz8jr257drsngeanwA4jrVSciMdAVt+9LQpt HZiechicTbKUjCnp0npdqFatRJ5XRG0aKxayvPmrb6xw8zEAsD03YT+1ZU3ItSlF4F3v jKkglONnwAtyS0WqMZdFMgBk/lFn6gGSgcUZsh6W6laTkBlT5ckwmi09Clk2xn92bbJz ohY55VbC9eqdnJroLgsCv116eBbevBgJPXwmyMIjDY39/Nw6zEzAdw52jnNmAjE8Uoz7 luT9zWhy/2k1wAeD39QrYpBgWWPl8ico/hbv7oSWFumkXbLTFD1D3cJXxBESYykjdIt0 1ngQ== X-Gm-Message-State: AMCzsaWqy9742z3L80qAmXwaST8g3OEiF5KpU9kRjutvXHyBcQO70YiB x/u3C/LkjUQaxV58nRBMSo7rkgkZKmBakeJxVU30H4th X-Google-Smtp-Source: ABhQp+T+YO69RpSy9hy/1sDNP+nx+HFyYIo1Xb1GyaArpf5NlLV1ZRWX+/8PqZAMOlUW8lx4ezZozuxPPJXGKK13fR8= X-Received: by 10.223.189.18 with SMTP id j18mr8669950wrh.58.1508651347488; Sat, 21 Oct 2017 22:49:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.226.87 with HTTP; Sat, 21 Oct 2017 22:49:06 -0700 (PDT) From: Mustafa Kuscu Date: Sun, 22 Oct 2017 08:49:06 +0300 Message-ID: Subject: [PATCH v2] asus rog laptops GL55x keyboard backlight fix To: linux-input@vger.kernel.org Cc: jikos@kernel.org Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi All, (Updated diff path which was not a full path before, and also updated the description for clarity in this version.) Some ASUS ROG laptops have a backlit keyboard which is detected fine but Fn + F3/F4 does not work in setting up backlight level. It appears that after making the one liner change below, the backlight level can be controlled by the Fn keys. It is intended only to the following device: 0x0b05 1854, P: Vendor=0b05 ProdID=1854 Rev=03.02 S: Manufacturer=ITE Tech. Inc. S: Product=ITE Device(8910) This keyboard device can be captured as HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD1), However, the QUIRK is only present for ROG KEYBOARD2. { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD1) }, { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD2), QUIRK_USE_KBD_BACKLIGHT }, After enabling the same quirk for KEYBOARD1, it is possible to control backlight levels. It appears that the device is only used by hid-asus.c. Hope this helps to other people having the same issue. Mustafa Signed-off-by: mustafakuscu@gmail.com --- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- linux/drivers/hid/hid-asus.c.orig 2017-10-16 12:20:14.631341280 +0300 +++ linux/drivers/hid/hid-asus.c 2017-10-16 12:20:24.814674504 +0300 @@ -593,7 +593,7 @@ static const struct hid_device_id asus_d { HID_I2C_DEVICE(USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_I2C_TOUCHPAD), I2C_TOUCHPAD_QUIRKS }, { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, - USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD1) }, + USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD1), QUIRK_USE_KBD_BACKLIGHT }, { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_ROG_KEYBOARD2), QUIRK_USE_KBD_BACKLIGHT }, { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK,