From patchwork Thu Apr 11 14:17:54 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 2428871 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 645C0DF230 for ; Thu, 11 Apr 2013 14:17:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752571Ab3DKOR4 (ORCPT ); Thu, 11 Apr 2013 10:17:56 -0400 Received: from mail-vb0-f49.google.com ([209.85.212.49]:57794 "EHLO mail-vb0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752513Ab3DKOR4 (ORCPT ); Thu, 11 Apr 2013 10:17:56 -0400 Received: by mail-vb0-f49.google.com with SMTP id 11so1277477vbf.8 for ; Thu, 11 Apr 2013 07:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=Yu4aMFGMgawnvldl1R3XoOEUhiYbq3a+g5uNlNNw1vk=; b=bxNF+GNu+/YeSRis+F/06EqsDVIwe+DI2mJdrSQQrx3eo2ZgSRE4uB1qjSrOZJf26Q UUER0Wj+y9FbF0CiD/dR9K7prMnDxS3NQLYY/3QL4was44GAFvd/la0bcKezx0xeHokR fa15rxMhkyASYzJXONCy0MNcBLK2He1chKoVoDE8dxwEYqny1ge/LAXWqcXLODn0GdhO cSAMPTQKoFgX9lh2YoU0T5C98PERYjj+23zq9fHVpqsUBFVi5kqaE6Bho9UB0aexWBUB zWlDL7TIb5Ipc/ZW2MLrjY+7RcmzJ1HUm5M96/ZGf4HgTz4UnH8sdWUAyDhbuQUwmDYj RywQ== MIME-Version: 1.0 X-Received: by 10.52.66.229 with SMTP id i5mr4324359vdt.131.1365689875260; Thu, 11 Apr 2013 07:17:55 -0700 (PDT) Received: by 10.59.5.201 with HTTP; Thu, 11 Apr 2013 07:17:54 -0700 (PDT) In-Reply-To: References: <1365657360-877-1-git-send-email-festevam@gmail.com> Date: Thu, 11 Apr 2013 11:17:54 -0300 Message-ID: Subject: Re: [PATCH] Input: imx_keypad - Place SIMPLE_DEV_PM_OPS inside CONFIG_PM_SLEEP if block From: Fabio Estevam To: Dmitry Torokhov Cc: kernel@pengutronix.de, linux-input@vger.kernel.org, Fabio Estevam Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi Dmitry, On Thu, Apr 11, 2013 at 2:28 AM, Dmitry Torokhov wrote: > Fabio Estevam wrote: > >>From: Fabio Estevam >> >>SIMPLE_DEV_PM_OPS should be inside the CONFIG_PM_SLEEP 'if' block >>because >>imx_kbd_suspend and imx_kbd_resume definitions are inside this block. > > No, it does not. It compiles just fine if CONFIG_PM_SLEEP is not defined. I am not sure how to disable CONFIG_PM_SLEEP properly in the defconfig, but I did this quick test to simulate it: and then I see: CC drivers/input/keyboard/imx_keypad.o drivers/input/keyboard/imx_keypad.c:585: error: 'imx_kbd_suspend' undeclared here (not in a function) drivers/input/keyboard/imx_keypad.c:585: error: 'imx_kbd_resume' undeclared here (not in a function) make[3]: *** [drivers/input/keyboard/imx_keypad.o] Error 1 make[2]: *** [drivers/input/keyboard] Error 2 --- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/input/keyboard/imx_keypad.c +++ b/drivers/input/keyboard/imx_keypad.c @@ -536,7 +536,7 @@ static int imx_keypad_probe(struct platform_device *pdev) return 0; } -#ifdef CONFIG_PM_SLEEP +#if 0 static int imx_kbd_suspend(struct device *dev) { struct platform_device *pdev = to_platform_device(dev);