From patchwork Sun Jul 15 01:06:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John S Gruber X-Patchwork-Id: 10524927 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 401F8600D0 for ; Sun, 15 Jul 2018 01:06:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 308D1289EE for ; Sun, 15 Jul 2018 01:06:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2485B28A0D; Sun, 15 Jul 2018 01:06:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D0227289EE for ; Sun, 15 Jul 2018 01:06:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731946AbeGOB11 (ORCPT ); Sat, 14 Jul 2018 21:27:27 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:34679 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731885AbeGOB11 (ORCPT ); Sat, 14 Jul 2018 21:27:27 -0400 Received: by mail-oi0-f68.google.com with SMTP id 13-v6so68756189ois.1 for ; Sat, 14 Jul 2018 18:06:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:in-reply-to:references:date:message-id:subject:to; bh=KkAbw+Mw09t7cvlydwjLaLcheYiualng8Isu+fZqHhs=; b=fd6tNKtFDwXgXARs33GTcqeyo+SUxB/kSa5hfcq92QsId8WHimC4eGLvkk8Ia9kcJW yD/F+tPMofaOaKIWiGIfa/FuEnYvSrKrfv2MIv+eJqDs/OR59k29fP6BGlkPlXoiU17Y JzgeYCXC/qT7P64D9S5AbyIctMjqNjXb5/leEi17pBi/HVxWXCmF6cVLjjUpuZ90iu35 4r7XGzABQmGMXiHuuhS1GzmC6A9a+GENpVuBm3lHmqftZaBWNi/Qn/rjfWFpTMM0Nz9I q8sdntuBQnCC69RwvVPlbLs8lUS3dYRvZCSUvrMRjU6fuOfpxH9Nf636wtN1kCWYJDGS KoyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:in-reply-to:references:date :message-id:subject:to; bh=KkAbw+Mw09t7cvlydwjLaLcheYiualng8Isu+fZqHhs=; b=F4jKFbfe1mJXWD7xB1gQRbq7CKgOtMDhzMJqW/Iie1BkG44WQCJXU1P2E5w7vkvV3x zrcoB1ar6roZlteG1vDAm0kF0rsd0mDKWTLHRsA2fPyuXT0VyVxS4fYHAMQXEzfIHRnl /Dq4Ph0ByeV4zO2ahiDEux5fWb58v3KNC3ao6WcJra51h113AjNgXy6tdRhpGjISSr3h QGLnq54UD3nOOdKECL5wzxTalx1vulOFQ3jFMK28Z7JEOiQ5nwc5ULnjCiuC9b3iTHfg 8lQTrJyt+geAVgiXzA0l8cYM2V36n04Y56yb9mbtG3+1JtdxBcLLHuQd9wXhDdfvKrYd nIdA== X-Gm-Message-State: AOUpUlFa5jMLtORygLuE9Z6eHc5SByaEwhiHSvFqJ1bKxyi62xTtUHfd BgXqB9NCxHpwPgvAzZG32jqfGiA8cGVSXEVBw2Q= X-Google-Smtp-Source: AAOMgpcK3BDzk5BcjBZiFcjdQjiTQfbGou25egPHX9CRqbOuewEgN0YEzxXyveGpk4m5egnwLSdFyVkmEaio7TC0yuU= MIME-Version: 1.0 X-Received: by 2002:aca:ce0f:: with SMTP id e15-v6mr13455737oig.13.1531616789826; Sat, 14 Jul 2018 18:06:29 -0700 (PDT) Received: from 329980741037 named unknown by gmailapi.google.com with HTTPREST; Sat, 14 Jul 2018 18:06:29 -0700 From: John S Gruber X-Mailer: git-send-email 1.9.1 In-Reply-To: <1531616776-7401-1-git-send-email-JohnSGruber@gmail.com> References: <1531616776-7401-1-git-send-email-JohnSGruber@gmail.com> Date: Sat, 14 Jul 2018 18:06:29 -0700 Message-ID: Subject: [PATCH 1/2] HID: redragon: Fix regression in non-Redragon keyboard due to this new driver To: Jiri Kosina , Robert Munteanu , linux-input@vger.kernel.org, benjamin.tissoires@redhat.com, JohnSGruber@gmail.com Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The Redragon keyboard uses the second device being presented, but other devices with the same vendor_id/device_id pair (0x0c45:760b) use the first. Don't cause its deletion. Problem introduced in commit 85455dd906d5 ("HID: redragon: Fix modifier keys for Redragon Asura Keyboard") Fixes: 85455dd906d5 Signed-off-by: John S Gruber --- drivers/hid/hid-redragon.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/hid/hid-redragon.c b/drivers/hid/hid-redragon.c index daf5957..85a5fbb 100644 --- a/drivers/hid/hid-redragon.c +++ b/drivers/hid/hid-redragon.c @@ -55,10 +55,6 @@ static int redragon_probe(struct hid_device *dev, return ret; } - /* do not register unused input device */ - if (dev->maxapplication == 1) - return 0; - ret = hid_hw_start(dev, HID_CONNECT_DEFAULT); if (ret) { hid_err(dev, "hw start failed\n");