| Message ID | SEZPR06MB56080820EE51CBAE9C6B6B3E9E9FA@SEZPR06MB5608.apcprd06.prod.outlook.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add HX83102j driver for HIMAX HID touchscreen | expand |
Hi Allen_Lin,
kernel test robot noticed the following build warnings:
[auto build test WARNING on hid/for-next]
[also build test WARNING on dtor-input/next dtor-input/for-linus robh/for-next linus/master v6.7-rc7 next-20231222]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Allen_Lin/Input-Add-Himax-HX83102J-touchscreen-driver/20231227-133817
base: https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-next
patch link: https://lore.kernel.org/r/SEZPR06MB56080820EE51CBAE9C6B6B3E9E9FA%40SEZPR06MB5608.apcprd06.prod.outlook.com
patch subject: [PATCH v3 1/2] dt-bindings: input: Add Himax HX83102J touchscreen
:::::: branch date: 19 hours ago
:::::: commit date: 19 hours ago
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231228/202312280837.b2PFmd9W-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202312280837.b2PFmd9W-lkp@intel.com/
dtcheck warnings: (new ones prefixed by >>)
>> Documentation/devicetree/bindings/input/himax,hx83102j.yaml:1:58: [error] wrong new line character: expected \n (new-lines)
vim +1 Documentation/devicetree/bindings/input/himax,hx83102j.yaml
b6f7a8833439cc Allen_Lin 2023-12-27 @1 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
On 27/12/2023 06:35, Allen_Lin wrote: > Add the HX83102j touchscreen device tree bindings documents. > > Signed-off-by: Allen_Lin <allencl_lin@hotmail.com> > --- Where is the changelog? There is no cover letter attached, so changelog is supposed to be here. There were several comments, so does it mean you ignored them? > .../bindings/input/himax,hx83102j.yaml | 65 +++++++++++++++++++ > MAINTAINERS | 6 ++ > 2 files changed, 71 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/himax,hx83102j.yaml > > diff --git a/Documentation/devicetree/bindings/input/himax,hx83102j.yaml b/Documentation/devicetree/bindings/input/himax,hx83102j.yaml > new file mode 100644 > index 000000000000..872b478c5753 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/himax,hx83102j.yaml > @@ -0,0 +1,65 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/himax,hx83102j.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Himax hx83102j touchscreen > + ... > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + hid-himax-spi@0 { Still not the name I asked - it should be generic, like touchscreen. Best regards, Krzysztof
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 於 2023年12月28日 週四 下午6:36寫道： > > On 27/12/2023 06:35, Allen_Lin wrote: > > Add the HX83102j touchscreen device tree bindings documents. > > > > Signed-off-by: Allen_Lin <allencl_lin@hotmail.com> > > --- > > Where is the changelog? There is no cover letter attached, so changelog > is supposed to be here. There were several comments, so does it mean you > ignored them? > Cover letter is not in this mail but in the mail with this title "[PATCH v3 0/2] Add HX83102j driver for HIMAX HID touchscreen" Hi, This driver implements for Himax HID touchscreen HX83102j. Using SPI interface to receive/send HID packets. Patchs notes as below 1. Add the Maintainer and devicetree bindings document for driver 2. Add the driver code and modify Kconfig/Makefile to support the driver change in v2 : - Fix kernel test robot build warnings. change in v3 : - Modify code according to review suggesions. Thanks. Allen_Lin (2): dt-bindings: input: Add Himax HX83102J touchscreen Input: Add Himax HX83102J touchscreen driver .../bindings/input/himax,hx83102j.yaml | 65 + MAINTAINERS | 7 + drivers/hid/Kconfig | 8 + drivers/hid/Makefile | 2 + drivers/hid/hid-himax-83102j.c | 1096 +++++++++++++++++ drivers/hid/hid-himax-83102j.h | 202 +++ 6 files changed, 1380 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/himax,hx83102j.yaml create mode 100644 drivers/hid/hid-himax-83102j.c create mode 100644 drivers/hid/hid-himax-83102j.h -- 2.34.1 > > > .../bindings/input/himax,hx83102j.yaml | 65 +++++++++++++++++++ > > MAINTAINERS | 6 ++ > > 2 files changed, 71 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/input/himax,hx83102j.yaml > > > > diff --git a/Documentation/devicetree/bindings/input/himax,hx83102j.yaml b/Documentation/devicetree/bindings/input/himax,hx83102j.yaml > > new file mode 100644 > > index 000000000000..872b478c5753 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/input/himax,hx83102j.yaml > > @@ -0,0 +1,65 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/input/himax,hx83102j.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Himax hx83102j touchscreen > > + > > ... > > > +examples: > > + - | > > + #include <dt-bindings/gpio/gpio.h> > > + #include <dt-bindings/interrupt-controller/irq.h> > > + spi { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + hid-himax-spi@0 { > > Still not the name I asked - it should be generic, like touchscreen. > I will fix it, thanks for your review. if driver code needs to be modified, i will fix it together. > Best regards, > Krzysztof > Best regards Allen
On 29/12/2023 10:08, Allen Lin wrote: > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 於 2023年12月28日 週四 下午6:36寫道： >> >> On 27/12/2023 06:35, Allen_Lin wrote: >>> Add the HX83102j touchscreen device tree bindings documents. >>> >>> Signed-off-by: Allen_Lin <allencl_lin@hotmail.com> >>> --- >> >> Where is the changelog? There is no cover letter attached, so changelog >> is supposed to be here. There were several comments, so does it mean you >> ignored them? >> > Cover letter is not in this mail but in the mail with this title > "[PATCH v3 0/2] Add HX83102j driver for HIMAX HID touchscreen" There was no cover letter attached to this thread. Don't send cover letters in separate threads. > > Hi, > This driver implements for Himax HID touchscreen HX83102j. > > Using SPI interface to receive/send HID packets. > > Patchs notes as below > 1. Add the Maintainer and devicetree bindings document for driver > 2. Add the driver code and modify Kconfig/Makefile to support the driver > > change in v2 : > - Fix kernel test robot build warnings. > change in v3 : > - Modify code according to review suggesions. Not detailed enough. What did you change exactly? Best regards, Krzysztof
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 於 2023年12月30日 週六 下午10:19寫道： > > On 29/12/2023 10:08, Allen Lin wrote: > > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 於 2023年12月28日 週四 下午6:36寫道： > >> > >> On 27/12/2023 06:35, Allen_Lin wrote: > >>> Add the HX83102j touchscreen device tree bindings documents. > >>> > >>> Signed-off-by: Allen_Lin <allencl_lin@hotmail.com> > >>> --- > >> > >> Where is the changelog? There is no cover letter attached, so changelog > >> is supposed to be here. There were several comments, so does it mean you > >> ignored them? > >> > > Cover letter is not in this mail but in the mail with this title > > "[PATCH v3 0/2] Add HX83102j driver for HIMAX HID touchscreen" > > There was no cover letter attached to this thread. Don't send cover > letters in separate threads. > > > > > Hi, > > This driver implements for Himax HID touchscreen HX83102j. > > > > Using SPI interface to receive/send HID packets. > > > > Patchs notes as below > > 1. Add the Maintainer and devicetree bindings document for driver > > 2. Add the driver code and modify Kconfig/Makefile to support the driver > > > > change in v2 : > > - Fix kernel test robot build warnings. > > change in v3 : > > - Modify code according to review suggesions. > > Not detailed enough. What did you change exactly? > 1. Remove function pointer coding style 2. Remove unused code/variable/structure 3. Use devm_kzalloc() to allocate memory 4. Use gpio descriptors to control gpio 5. All functions are changed to static 6. Drop all global variables. > > Best regards, > Krzysztof > Best regards Allen
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 於 2023年12月30日 週六 下午10:19寫道： > > On 29/12/2023 10:08, Allen Lin wrote: > > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 於 2023年12月28日 週四 下午6:36寫道： > >> > >> On 27/12/2023 06:35, Allen_Lin wrote: > >>> Add the HX83102j touchscreen device tree bindings documents. > >>> > >>> Signed-off-by: Allen_Lin <allencl_lin@hotmail.com> > >>> --- > >> > >> Where is the changelog? There is no cover letter attached, so changelog > >> is supposed to be here. There were several comments, so does it mean you > >> ignored them? > >> > > Cover letter is not in this mail but in the mail with this title > > "[PATCH v3 0/2] Add HX83102j driver for HIMAX HID touchscreen" > > There was no cover letter attached to this thread. Don't send cover > letters in separate threads. > > > > > Hi, > > This driver implements for Himax HID touchscreen HX83102j. > > > > Using SPI interface to receive/send HID packets. > > > > Patchs notes as below > > 1. Add the Maintainer and devicetree bindings document for driver > > 2. Add the driver code and modify Kconfig/Makefile to support the driver > > > > change in v2 : > > - Fix kernel test robot build warnings. > > change in v3 : > > - Modify code according to review suggesions. > > Not detailed enough. What did you change exactly? > 1. Remove function pointer coding style 2. Remove unused code/variable/structure 3. Use devm_kzalloc() to allocate memory 4. Use gpio descriptors to control gpio 5. All functions are changed to static 6. Drop all global variables. > > Best regards, > Krzysztof > Best regards Allen
diff --git a/Documentation/devicetree/bindings/input/himax,hx83102j.yaml b/Documentation/devicetree/bindings/input/himax,hx83102j.yaml new file mode 100644 index 000000000000..872b478c5753 --- /dev/null +++ b/Documentation/devicetree/bindings/input/himax,hx83102j.yaml @@ -0,0 +1,65 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/himax,hx83102j.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Himax hx83102j touchscreen + +maintainers: + - Allen Lin <allencl_lin@hotmail.com> + +description: + This Himax hx83102j touchscreen uses the spi-hid protocol. + +allOf: + - $ref: /schemas/input/touchscreen/touchscreen.yaml# + - $ref: /schemas/spi/spi-peripheral-props.yaml# + +properties: + compatible: + enum: + - himax,hx83102j + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + reset-gpios: + maxItems: 1 + + spi-cpha: true + + spi-cpol: true + + spi-max-frequency: true + +required: + - compatible + - reg + - interrupts + - reset-gpios + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/interrupt-controller/irq.h> + spi { + #address-cells = <1>; + #size-cells = <0>; + hid-himax-spi@0 { + compatible = "himax,hx83102j"; + reg = <0>; + pinctrl-names = "default"; + pinctrl-0 = <&touch_int0 &touch_reset>; + reset-gpios = <&gpio1 8 GPIO_ACTIVE_LOW>; + spi-cpha; + spi-cpol; + interrupt-parent = <&gpio1>; + interrupts = <7 IRQ_TYPE_LEVEL_LOW>; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 012df8ccf34e..6a92e40d126d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9502,6 +9502,12 @@ L: linux-kernel@vger.kernel.org S: Maintained F: drivers/misc/hisi_hikey_usb.c +HIMAX HID HX83102J TOUCHSCREEN +M: Allen Lin <allencl_lin@hotmail.com> +L: linux-input@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/input/himax,hx83102j.yaml + HIMAX HX83112B TOUCHSCREEN SUPPORT M: Job Noorman <job@noorman.info> L: linux-input@vger.kernel.org
Add the HX83102j touchscreen device tree bindings documents. Signed-off-by: Allen_Lin <allencl_lin@hotmail.com> --- .../bindings/input/himax,hx83102j.yaml | 65 +++++++++++++++++++ MAINTAINERS | 6 ++ 2 files changed, 71 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/himax,hx83102j.yaml