PATCH [1/6] HID: lg4ff - Move handling of Logitech wheels to lg4ff driver

Commit Message

Jiri Kosina Aug. 10, 2011, 12:33 p.m. UTC

On Tue, 9 Aug 2011, [e-mail] wrote:

> Hi Jiri,
> Saw that this is in the latest git grab, but I also noticed that (the new)
> option 'LOGIWHEELS_FF' is not automatically selected if I grab an old
> kernel config (say 2.6.38 on my ubuntu box) and do 'make oldconfig' with
> the enter key held down.
> 
> Did Michal/myself miss something, or is it preferable to not enable by
> default?
> 
> The down side is that the FF on these wheels will stop working (compared
> to 3.0) if kernel builder does not enable this....
> 
> I can spin a patch if you'd like to point me the right direction.

We normally don't do 'default y' for newly added HID options (I had quite 
some argument about this with Linus several times already :) ).

This one could be different, as it's a split-off from an option that has 
existed before.

But ... what's now LOGIWHEELS_FF used to be LOGITECH_FF, which isn't 
'default y' either.

So something along the lines of patch below would be fine for you guys?




From: Jiri Kosina <[e-mail]>
Subject: [PATCH] HID: make CONFIG_LOGIWHEELS_FF default to CONFIG_LOGITECH_FF

Do this for backwards compatibility reasons (LOGIWHEELS_FF has
been split-off from LOGITECH_FF), so that users don't have
regressions with 'default' kernel configs.

Reported-by: [e-mail]
Signed-off-by: Jiri Kosina <[e-mail]>
---
 drivers/hid/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

[e-mail] Aug. 10, 2011, 3:09 p.m. UTC | #1

> But ... what's now LOGIWHEELS_FF used to be LOGITECH_FF, which isn't
> 'default y' either.
>
> So something along the lines of patch below would be fine for you guys?
>

Yep, that makes sense and works for me...
Thanks,
Simon.

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Jiri Kosina Aug. 10, 2011, 4:11 p.m. UTC | #2

On Wed, 10 Aug 2011, [e-mail] wrote:

> > But ... what's now LOGIWHEELS_FF used to be LOGITECH_FF, which isn't
> > 'default y' either.
> >
> > So something along the lines of patch below would be fine for you guys?
> >
> Yep, that makes sense and works for me...
> Thanks,
> Simon.

Okay, applied, thanks for testing.

Patch

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 6ae234f..410eaa9 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -282,6 +282,7 @@  config LOGIWHEELS_FF
 	bool "Logitech wheels configuration and force feedback support"
 	depends on HID_LOGITECH
 	select INPUT_FF_MEMLESS
+	default LOGITECH_FF
 	help
 	  Say Y here if you want to enable force feedback and range setting
 	  support for following Logitech wheels: