From patchwork Sat Nov 18 10:55:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 10064753 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A3C4660352 for ; Sat, 18 Nov 2017 10:56:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9D0662A683 for ; Sat, 18 Nov 2017 10:56:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 91E3D2A6C6; Sat, 18 Nov 2017 10:56:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3B8922A683 for ; Sat, 18 Nov 2017 10:56:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946818AbdKRK4P (ORCPT ); Sat, 18 Nov 2017 05:56:15 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:38184 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422816AbdKRKzy (ORCPT ); Sat, 18 Nov 2017 05:55:54 -0500 Received: by mail-pg0-f65.google.com with SMTP id s11so3843961pgc.5; Sat, 18 Nov 2017 02:55:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=jXcAT4LBoZ1poUz2PsU7kEMCBwo6iH1cbOKdB49TH54=; b=TqP9qoPcpKMF+k8ITr08fHBaW/RnFlOpZwgJtQVTiP/UngD0R5WReH00aM6ewl7N3p wpyl1Slk2AEMCa6A3GSRJL2YEtX0Pwq3uab800fdT/6VWnbDy8vl/RcwjYP/f0Lm248l 4WKjuhk0G4qiBeXGPSxMhzNFNIVR2nkzD6v9/aMtpeR/+HpEGdKM/f75cdyO6x1Pspv/ ZILFltzmwGUsjK53tihl+II50BfYtKVuAQICZDBMAJ0HUINhVUOF8fQJ8Y8e4mwXfA6i TJTTAY7YDt2/zPbDHTwwfWm/O45o1fDMvUbXId0dmvB3BA4FW2dGdy7KirYvLtOmZYUq 6AbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=jXcAT4LBoZ1poUz2PsU7kEMCBwo6iH1cbOKdB49TH54=; b=sZIWlE4QWuLa/n8VhnFm0NG1cL9xejr6h4p26uwwx6siu3GFgwnkXMiG4y5y8xmLos w3ASmFZNCRdQKoCLK1vyCIOlV72QARLk0ruzPxQZ47iucosGCZfneVbhFkey0jQKyXbC MYdVkncnwsV2L/JLTBurGjl4AsV5aNdprZNB+4W7M50I1l32WbuV+cOGoWGLDyITecGU Ra4iv/pscRHtUt8cbJSSxPa1+px2H6MYwTIDxxQ+sbAIkY0G/tNoYWRFbSwp5ngkX/NP lsgQsVzeERUwpW1G9aSDeT71qAcd3eJvPjAfCXOrJ1b7Z2BYBhRWH5iKXK0cu1J/L51e QX0g== X-Gm-Message-State: AJaThX6aqCw05BZdRoNE1isRf/KK7OS2wMkiHqdqrsvIaZ9WYgO/t/Oo HJDiA+00jdkHo28INvfWOzqLjgPt X-Google-Smtp-Source: AGs4zMb3UKFCykJk8VM5ssfrkWQiVVnj3TXAJACZLZD3gJy4eHSOoge7tG++z/CA22myfvdPOdl61w== X-Received: by 10.159.230.13 with SMTP id u13mr7728512plq.293.1511002553747; Sat, 18 Nov 2017 02:55:53 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id g7sm12321513pfj.13.2017.11.18.02.55.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 18 Nov 2017 02:55:53 -0800 (PST) From: Arvind Yadav To: dmitry.torokhov@gmail.com, maxime.ripard@free-electrons.com, wens@csie.org, mcuos.com@gmail.com, linux@roeck-us.net, linux@armlinux.org.uk, lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 08/10 v3] Input: twl4030-pwrbutton: Handle return value of platform_get_irq Date: Sat, 18 Nov 2017 16:25:15 +0530 Message-Id: X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: <76d6a73ba51e1a8a86d8d9a1d0bbbf7723d5153a.1510999334.git.arvind.yadav.cs@gmail.com> References: <76d6a73ba51e1a8a86d8d9a1d0bbbf7723d5153a.1510999334.git.arvind.yadav.cs@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- changes in v2 : return irq instead of -ENODEV. changes in v3 : Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid. drivers/input/misc/twl4030-pwrbutton.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c index b307cca..0dcf311 100644 --- a/drivers/input/misc/twl4030-pwrbutton.c +++ b/drivers/input/misc/twl4030-pwrbutton.c @@ -58,6 +58,9 @@ static int twl4030_pwrbutton_probe(struct platform_device *pdev) int irq = platform_get_irq(pdev, 0); int err; + if (irq <= 0) + return irq; + pwr = devm_input_allocate_device(&pdev->dev); if (!pwr) { dev_err(&pdev->dev, "Can't allocate power button\n");