From patchwork Thu Apr 21 11:43:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H. Nikolaus Schaller" X-Patchwork-Id: 8899671 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 2F6F4BF29F for ; Thu, 21 Apr 2016 11:45:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5B75820211 for ; Thu, 21 Apr 2016 11:45:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5AB7C2025B for ; Thu, 21 Apr 2016 11:45:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752371AbcDULoL (ORCPT ); Thu, 21 Apr 2016 07:44:11 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.161]:41269 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752353AbcDULoH (ORCPT ); Thu, 21 Apr 2016 07:44:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1461239044; l=1052; s=domk; d=goldelico.com; h=References:In-Reply-To:References:In-Reply-To:Date:Subject:Cc:To: From; bh=uosx2YP7aAQHURbkKnF7Kp4S1ldY97JKPipibXtCAH8=; b=JM278NKUzQ4CAZQO5DgFF+yNJsoOAv3ZjhJsthkuzchxy4fIbZAxaNIU3ZPV6mzPll4 viBEdHTWe37twU+FeAOp+Kx4HAiFKKK9m3D5L+ZkIoCrt0yaQ7EGnf5h/NXT2fNqn4WHV HHHZUmBJ3WCT5nhcAax838O35GfXG8Jx1tw= X-RZG-AUTH: :JGIXVUS7cutRB/49FwqZ7WcecEarQROEYabkiUo6mSAGQ+qKIDcoIFI= X-RZG-CLASS-ID: mo00 Received: from localhost.localdomain (p57AE0902.dip0.t-ipconnect.de [87.174.9.2]) by smtp.strato.de (RZmta 37.24 DYNA|AUTH) with ESMTPA id I03fe7s3LBhtEgA; Thu, 21 Apr 2016 13:43:55 +0200 (CEST) From: "H. Nikolaus Schaller" To: Dmitry Torokhov , Fabio Estevam , Peter Ujfalusi , "H. Nikolaus Schaller" Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pyra-handheld.com, letux-kernel@openphoenux.org Subject: [PATCH v2 1/4] input: twl6040-vibra: fix DT node memory management Date: Thu, 21 Apr 2016 13:43:47 +0200 Message-Id: X-Mailer: git-send-email 2.7.3 In-Reply-To: References: In-Reply-To: References: Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP commit e7ec014a47e4 ("Input: twl6040-vibra - update for device tree support") made the separate vibra DT node to a subnode of the twl6040. It now calls of_find_node_by_name() to locate the "vibra" subnode. This function has a side effect to call of_node_put on() for the twl6040 parent node passed in as a parameter. This causes trouble later on. Solution: we must call of_node_get() before of_find_node_by_name() Signed-off-by: H. Nikolaus Schaller --- drivers/input/misc/twl6040-vibra.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/misc/twl6040-vibra.c b/drivers/input/misc/twl6040-vibra.c index 0c853c2..ad15498 100644 --- a/drivers/input/misc/twl6040-vibra.c +++ b/drivers/input/misc/twl6040-vibra.c @@ -257,6 +257,7 @@ static int twl6040_vibra_probe(struct platform_device *pdev) int vddvibr_uV = 0; int error; + of_node_get(twl6040_core_dev->of_node); twl6040_core_node = of_find_node_by_name(twl6040_core_dev->of_node, "vibra"); if (!twl6040_core_node) {