diff mbox

hid: hid-led: fix Delcom support on big endian systems

Message ID c65d7daa-e057-8aab-7e3e-2e88bf896061@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Heiner Kallweit July 8, 2016, 4:58 a.m. UTC 
Properly handle this __le16 value on big endian systems.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/hid/hid-led.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jiri Kosina July 8, 2016, 10:38 a.m. UTC | #1 
On Fri, 8 Jul 2016, Heiner Kallweit wrote:

> Properly handle this __le16 value on big endian systems.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
>  drivers/hid/hid-led.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-led.c b/drivers/hid/hid-led.c
> index 4c43ef8..d8d55f3 100644
> --- a/drivers/hid/hid-led.c
> +++ b/drivers/hid/hid-led.c
> @@ -327,7 +327,7 @@ static int delcom_init(struct hidled_device *ldev)
>  	 * Several Delcom devices share the same USB VID/PID
>  	 * Check for family id 2 for Visual Signal Indicator
>  	 */
> -	return dp.fw.family_code == 2 ? 0 : -ENODEV;
> +	return le16_to_cpu(dp.fw.family_code) == 2 ? 0 : -ENODEV;
>  }

Applied to for-4.8/hid-led. Thanks,
diff mbox

Patch

diff --git a/drivers/hid/hid-led.c b/drivers/hid/hid-led.c
index 4c43ef8..d8d55f3 100644
--- a/drivers/hid/hid-led.c
+++ b/drivers/hid/hid-led.c
@@ -327,7 +327,7 @@  static int delcom_init(struct hidled_device *ldev)
 	 * Several Delcom devices share the same USB VID/PID
 	 * Check for family id 2 for Visual Signal Indicator
 	 */
-	return dp.fw.family_code == 2 ? 0 : -ENODEV;
+	return le16_to_cpu(dp.fw.family_code) == 2 ? 0 : -ENODEV;
 }
 
 static int luxafor_write(struct led_classdev *cdev, enum led_brightness br)