| Message ID | db40a35b-992c-8bef-171c-7d7f52957dbc@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, May 27, 2018 at 11:28 PM, Heiner Kallweit <hkallweit1@gmail.com> wrote: > Delcom offers different types of products sharing the same USB VID/PID > as the Visual Signal Indicator. Other products need to be handled by > HID Generic what's not possible currently because USB VID/PID are > listed in hid_have_special_driver[]. > > After e04a0442d33b ("HID: core: remove the absolute need of > hid_have_special_driver[]") we can now remove the Delcom entry. > > If a Visual Signal Indicator device is plugged-in, HID core > will start a reprobe if hid-led driver is available. > If another device with same USB VID/PID is plugged-in, then hid-led > can be blacklisted and HID Generic handles the device. > > Thanks to Delcom for providing test devices. > > Reported-by: Douglas Lovett <dlovett@delcomproducts.com> > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > --- Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Cheers, Benjamin > drivers/hid/hid-quirks.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c > index 587e2681a..249d49b6b 100644 > --- a/drivers/hid/hid-quirks.c > +++ b/drivers/hid/hid-quirks.c > @@ -416,7 +416,6 @@ static const struct hid_device_id hid_have_special_driver[] = { > { HID_USB_DEVICE(USB_VENDOR_ID_LCPOWER, USB_DEVICE_ID_LCPOWER_LC1000) }, > #endif > #if IS_ENABLED(CONFIG_HID_LED) > - { HID_USB_DEVICE(USB_VENDOR_ID_DELCOM, USB_DEVICE_ID_DELCOM_VISUAL_IND) }, > { HID_USB_DEVICE(USB_VENDOR_ID_DREAM_CHEEKY, USB_DEVICE_ID_DREAM_CHEEKY_WN) }, > { HID_USB_DEVICE(USB_VENDOR_ID_DREAM_CHEEKY, USB_DEVICE_ID_DREAM_CHEEKY_FA) }, > { HID_USB_DEVICE(USB_VENDOR_ID_MICROCHIP, USB_DEVICE_ID_LUXAFOR) }, > -- > 2.17.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, 27 May 2018, Heiner Kallweit wrote: > Delcom offers different types of products sharing the same USB VID/PID > as the Visual Signal Indicator. Other products need to be handled by > HID Generic what's not possible currently because USB VID/PID are > listed in hid_have_special_driver[]. > > After e04a0442d33b ("HID: core: remove the absolute need of > hid_have_special_driver[]") we can now remove the Delcom entry. > > If a Visual Signal Indicator device is plugged-in, HID core > will start a reprobe if hid-led driver is available. > If another device with same USB VID/PID is plugged-in, then hid-led > can be blacklisted and HID Generic handles the device. > > Thanks to Delcom for providing test devices. > > Reported-by: Douglas Lovett <dlovett@delcomproducts.com> > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Applied, thanks.
diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c index 587e2681a..249d49b6b 100644 --- a/drivers/hid/hid-quirks.c +++ b/drivers/hid/hid-quirks.c @@ -416,7 +416,6 @@ static const struct hid_device_id hid_have_special_driver[] = { { HID_USB_DEVICE(USB_VENDOR_ID_LCPOWER, USB_DEVICE_ID_LCPOWER_LC1000) }, #endif #if IS_ENABLED(CONFIG_HID_LED) - { HID_USB_DEVICE(USB_VENDOR_ID_DELCOM, USB_DEVICE_ID_DELCOM_VISUAL_IND) }, { HID_USB_DEVICE(USB_VENDOR_ID_DREAM_CHEEKY, USB_DEVICE_ID_DREAM_CHEEKY_WN) }, { HID_USB_DEVICE(USB_VENDOR_ID_DREAM_CHEEKY, USB_DEVICE_ID_DREAM_CHEEKY_FA) }, { HID_USB_DEVICE(USB_VENDOR_ID_MICROCHIP, USB_DEVICE_ID_LUXAFOR) },
Delcom offers different types of products sharing the same USB VID/PID as the Visual Signal Indicator. Other products need to be handled by HID Generic what's not possible currently because USB VID/PID are listed in hid_have_special_driver[]. After e04a0442d33b ("HID: core: remove the absolute need of hid_have_special_driver[]") we can now remove the Delcom entry. If a Visual Signal Indicator device is plugged-in, HID core will start a reprobe if hid-led driver is available. If another device with same USB VID/PID is plugged-in, then hid-led can be blacklisted and HID Generic handles the device. Thanks to Delcom for providing test devices. Reported-by: Douglas Lovett <dlovett@delcomproducts.com> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/hid/hid-quirks.c | 1 - 1 file changed, 1 deletion(-)