From patchwork Sun May 27 21:28:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 10429561 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 69C5B60327 for ; Sun, 27 May 2018 21:29:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5381328887 for ; Sun, 27 May 2018 21:29:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 31A36289BB; Sun, 27 May 2018 21:29:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B5F2828887 for ; Sun, 27 May 2018 21:29:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751548AbeE0V3F (ORCPT ); Sun, 27 May 2018 17:29:05 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:43804 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751544AbeE0V3F (ORCPT ); Sun, 27 May 2018 17:29:05 -0400 Received: by mail-wr0-f195.google.com with SMTP id d2-v6so1716702wrm.10 for ; Sun, 27 May 2018 14:29:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:cc:message-id:date:user-agent:mime-version :content-transfer-encoding; bh=ECXDgaztpgqZyUAojSn9aF1/MW4oiFGxsYLV8sZNhck=; b=sm1UPZsFOGp5vKt9BlxhbFpJ14OeTEnJDMtHNePhniRNFhL/w4KaCjBzX3h6HGuczb C12a2pFHpbXN1+zNLYhr+3BwofGg6W5G/8toh/72dJws4y6yra5cJseIED5EJUqZgfnN Fm55vB/4NQCM9lvkaB8jx1TJZoaC4xV/hnLDPeExf7xYdtVCQemwT1zmxM1H2Dg1Lmhw COJuG69w6/lNQIpK7Lr3ZZHr9Larna4pMDqcnDyiRxmglPLZphTzRS1YFU6/Ov+H6ifw GnrfPYG8MAHubJDO9Zz/G9jT27rr6J5YN6N1rD+q6SG8JwWvlmvNA6QnqGmC+MmvhmAf e34Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:cc:message-id:date:user-agent :mime-version:content-transfer-encoding; bh=ECXDgaztpgqZyUAojSn9aF1/MW4oiFGxsYLV8sZNhck=; b=cu58midu97FauNmjQ9cLVxaGfauhwD1QCntVDgsGjiIiYtkmiwc+UnCsOrJqxPDh0v iNSRt4gJEY5VBWHguoykjAV1DvQlAOMwlYsQeWnWoD0NnXt6uwHKOxI8kSjjaRZ30zgf fM+rV+IsPRVAyv5jajDOghkkDjea6kgNCHm43uorytuMKzVORuxMndDNLMfMowYAhUKT 7LIiyB06vTIfc9DLeVTll/AkFOBV3cETvMqr/mLUjjtyQwZN30rHPiUJXUyHSV4SovNc bnI/KYg6D6xX5epvc4b7mY4+iyHH6gDtpxnOfau541ku734E463ihpvgRoAhooRe6Ve3 EybA== X-Gm-Message-State: ALKqPwf4M3FXD2teVW0Jt6FxROcOw20Lm1vSu5q+yMrHb/o1Tpm50K2u GbQa7ADK20L7Bd8a2mgRyJwF3Q== X-Google-Smtp-Source: ADUXVKLITRJbk6wvJLeSkqPPnq5lGC+kw8FAY+WdWSfoZqucww+DKsvp4Z2eI5eOqag4ZCvLYJ0fzA== X-Received: by 2002:adf:9045:: with SMTP id h63-v6mr1830297wrh.188.1527456544034; Sun, 27 May 2018 14:29:04 -0700 (PDT) Received: from ?IPv6:2003:ea:8bd4:d600:a11c:be93:3206:3c8d? (p200300EA8BD4D600A11CBE9332063C8D.dip0.t-ipconnect.de. [2003:ea:8bd4:d600:a11c:be93:3206:3c8d]) by smtp.googlemail.com with ESMTPSA id 19-v6sm36916507wrz.7.2018.05.27.14.29.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 27 May 2018 14:29:03 -0700 (PDT) To: Jiri Kosina , Benjamin Tissoires From: Heiner Kallweit Subject: [PATCH] HID: quirks: remove Delcom Visual Signal Indicator from hid_have_special_driver[] Cc: "open list:HID CORE LAYER" , Douglas Lovett Message-ID: Date: Sun, 27 May 2018 23:28:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Delcom offers different types of products sharing the same USB VID/PID as the Visual Signal Indicator. Other products need to be handled by HID Generic what's not possible currently because USB VID/PID are listed in hid_have_special_driver[]. After e04a0442d33b ("HID: core: remove the absolute need of hid_have_special_driver[]") we can now remove the Delcom entry. If a Visual Signal Indicator device is plugged-in, HID core will start a reprobe if hid-led driver is available. If another device with same USB VID/PID is plugged-in, then hid-led can be blacklisted and HID Generic handles the device. Thanks to Delcom for providing test devices. Reported-by: Douglas Lovett Signed-off-by: Heiner Kallweit Acked-by: Benjamin Tissoires --- drivers/hid/hid-quirks.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c index 587e2681a..249d49b6b 100644 --- a/drivers/hid/hid-quirks.c +++ b/drivers/hid/hid-quirks.c @@ -416,7 +416,6 @@ static const struct hid_device_id hid_have_special_driver[] = { { HID_USB_DEVICE(USB_VENDOR_ID_LCPOWER, USB_DEVICE_ID_LCPOWER_LC1000) }, #endif #if IS_ENABLED(CONFIG_HID_LED) - { HID_USB_DEVICE(USB_VENDOR_ID_DELCOM, USB_DEVICE_ID_DELCOM_VISUAL_IND) }, { HID_USB_DEVICE(USB_VENDOR_ID_DREAM_CHEEKY, USB_DEVICE_ID_DREAM_CHEEKY_WN) }, { HID_USB_DEVICE(USB_VENDOR_ID_DREAM_CHEEKY, USB_DEVICE_ID_DREAM_CHEEKY_FA) }, { HID_USB_DEVICE(USB_VENDOR_ID_MICROCHIP, USB_DEVICE_ID_LUXAFOR) },