diff mbox

[V1,1/2] mfd: da9063: Linkages for ONKEY support in core files

Message ID f5a169e00565134fa856a3daa615b17253ce844e.1394468644.git.stwiss.opensource@diasemi.com (mailing list archive)
State New, archived
Headers show

Commit Message

Steve Twiss March 10, 2014, 4:24 p.m. UTC
From: Opensource [Steve Twiss] <stwiss.opensource@diasemi.com>

This change adds the name field "ONKEY" to the properties of the 
the OnKey IORESOURCE_IRQ resource structure (part of the mfd_cell
Onkey resource).

The addition of bool key_power which will be passed to the onkey
driver and allow KEY_POWER support to be turned on/off as a
driver configuration option.


Signed-off-by: Opensource [Steve Twiss] <stwiss.opensource@diasemi.com>
---
Checks performed with linux-next/next-20140307/scripts/checkpatch.pl
 da9063-core.c             total: 0 errors, 0 warnings, 189 lines checked
 pdata.h                   total: 0 errors, 0 warnings, 112 lines checked

This change is a dependency for the new DA9063 OnKey driver which
forms the remainder of this patch set.
This patch applies against kernel linux-next next-20140307

Regards,
Steve Twiss, Dialog Semiconductor Ltd.



 drivers/mfd/da9063-core.c        | 1 +
 include/linux/mfd/da9063/pdata.h | 1 +
 2 files changed, 2 insertions(+)

Comments

Lee Jones March 10, 2014, 4:40 p.m. UTC | #1
> From: Opensource [Steve Twiss] <stwiss.opensource@diasemi.com>
> 
> This change adds the name field "ONKEY" to the properties of the 
> the OnKey IORESOURCE_IRQ resource structure (part of the mfd_cell
> Onkey resource).
> 
> The addition of bool key_power which will be passed to the onkey
> driver and allow KEY_POWER support to be turned on/off as a
> driver configuration option.
> 
> 
> Signed-off-by: Opensource [Steve Twiss] <stwiss.opensource@diasemi.com>
> ---
> Checks performed with linux-next/next-20140307/scripts/checkpatch.pl
>  da9063-core.c             total: 0 errors, 0 warnings, 189 lines checked
>  pdata.h                   total: 0 errors, 0 warnings, 112 lines checked
> 
> This change is a dependency for the new DA9063 OnKey driver which
> forms the remainder of this patch set.
> This patch applies against kernel linux-next next-20140307
> 
> Regards,
> Steve Twiss, Dialog Semiconductor Ltd.
> 
> 
> 
>  drivers/mfd/da9063-core.c        | 1 +
>  include/linux/mfd/da9063/pdata.h | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/mfd/da9063-core.c b/drivers/mfd/da9063-core.c
> index e70ae31..b410a14 100644
> --- a/drivers/mfd/da9063-core.c
> +++ b/drivers/mfd/da9063-core.c
> @@ -60,6 +60,7 @@ static struct resource da9063_rtc_resources[] = {
>  
>  static struct resource da9063_onkey_resources[] = {
>  	{
> +		.name	= "ONKEY",
>  		.start	= DA9063_IRQ_ONKEY,
>  		.end	= DA9063_IRQ_ONKEY,
>  		.flags	= IORESOURCE_IRQ,
> diff --git a/include/linux/mfd/da9063/pdata.h b/include/linux/mfd/da9063/pdata.h
> index 95c8742..612383b 100644
> --- a/include/linux/mfd/da9063/pdata.h
> +++ b/include/linux/mfd/da9063/pdata.h
> @@ -103,6 +103,7 @@ struct da9063;
>  struct da9063_pdata {
>  	int				(*init)(struct da9063 *da9063);
>  	int				irq_base;
> +	bool				key_power;
>  	unsigned			flags;
>  	struct da9063_regulators_pdata	*regulators_pdata;
>  	struct led_platform_data	*leds_pdata;

I'd like this change to be added by the first patch which makes use of
it.
Steve Twiss March 10, 2014, 5:16 p.m. UTC | #2
On 10 March 2014 16:40, Lee Jones wrote:

>> From: Opensource [Steve Twiss] <stwiss.opensource@diasemi.com>

>>

>> This change adds the name field "ONKEY" to the properties of the

>> the OnKey IORESOURCE_IRQ resource structure (part of the mfd_cell

>> Onkey resource).

>>

>> The addition of bool key_power which will be passed to the onkey

>> driver and allow KEY_POWER support to be turned on/off as a

>> driver configuration option.

>>

>>

>> Signed-off-by: Opensource [Steve Twiss] <stwiss.opensource@diasemi.com>

>> ---

>> Checks performed with linux-next/next-20140307/scripts/checkpatch.pl

>>  da9063-core.c             total: 0 errors, 0 warnings, 189 lines checked

>>  pdata.h                   total: 0 errors, 0 warnings, 112 lines checked

>>

>> This change is a dependency for the new DA9063 OnKey driver which

>> forms the remainder of this patch set.

>> This patch applies against kernel linux-next next-20140307

>>

>> Regards,

>> Steve Twiss, Dialog Semiconductor Ltd.

>>

>>

>>

>>  drivers/mfd/da9063-core.c        | 1 +

>>  include/linux/mfd/da9063/pdata.h | 1 +

>>  2 files changed, 2 insertions(+)

>>

>> diff --git a/drivers/mfd/da9063-core.c b/drivers/mfd/da9063-core.c

>> index e70ae31..b410a14 100644

>> --- a/drivers/mfd/da9063-core.c

>> +++ b/drivers/mfd/da9063-core.c

>> @@ -60,6 +60,7 @@ static struct resource da9063_rtc_resources[] = {

>>

>>  static struct resource da9063_onkey_resources[] = {

>>  	{

>> +		.name	= "ONKEY",

>>  		.start	= DA9063_IRQ_ONKEY,

>>  		.end	= DA9063_IRQ_ONKEY,

>>  		.flags	= IORESOURCE_IRQ,

>> diff --git a/include/linux/mfd/da9063/pdata.h

>b/include/linux/mfd/da9063/pdata.h

>> index 95c8742..612383b 100644

>> --- a/include/linux/mfd/da9063/pdata.h

>> +++ b/include/linux/mfd/da9063/pdata.h

>> @@ -103,6 +103,7 @@ struct da9063;

>>  struct da9063_pdata {

>>  	int				(*init)(struct da9063 *da9063);

>>  	int				irq_base;

>> +	bool				key_power;

>>  	unsigned			flags;

>>  	struct da9063_regulators_pdata	*regulators_pdata;

>>  	struct led_platform_data	*leds_pdata;

>

>I'd like this change to be added by the first patch which makes use of

>it.

>


No problem,
I'll resent it as PATCH V2...

Regards,
Steve
diff mbox

Patch

diff --git a/drivers/mfd/da9063-core.c b/drivers/mfd/da9063-core.c
index e70ae31..b410a14 100644
--- a/drivers/mfd/da9063-core.c
+++ b/drivers/mfd/da9063-core.c
@@ -60,6 +60,7 @@  static struct resource da9063_rtc_resources[] = {
 
 static struct resource da9063_onkey_resources[] = {
 	{
+		.name	= "ONKEY",
 		.start	= DA9063_IRQ_ONKEY,
 		.end	= DA9063_IRQ_ONKEY,
 		.flags	= IORESOURCE_IRQ,
diff --git a/include/linux/mfd/da9063/pdata.h b/include/linux/mfd/da9063/pdata.h
index 95c8742..612383b 100644
--- a/include/linux/mfd/da9063/pdata.h
+++ b/include/linux/mfd/da9063/pdata.h
@@ -103,6 +103,7 @@  struct da9063;
 struct da9063_pdata {
 	int				(*init)(struct da9063 *da9063);
 	int				irq_base;
+	bool				key_power;
 	unsigned			flags;
 	struct da9063_regulators_pdata	*regulators_pdata;
 	struct led_platform_data	*leds_pdata;