mbox series

[RFC,0/1] tpm: don't return bool from update_timeouts

Message ID 20190129174145.1482-1-jsnitsel@redhat.com (mailing list archive)
Headers show
Series tpm: don't return bool from update_timeouts | expand

Message

Jerry Snitselaar Jan. 29, 2019, 5:41 p.m. UTC 
Sorry, I've been tied up tracking down some iommu issues. I just took
a quick stab at this. It looks like the only failure case is the tpm
read of the did/vid failing for the spi driver. My question is do we
want to fail the probe in that case, spit out a message, or just
continue on? Thoughts?

Regards,
Jerry

Comments

Jarkko Sakkinen Jan. 29, 2019, 6:31 p.m. UTC | #1 
On Tue, Jan 29, 2019 at 10:41:44AM -0700, Jerry Snitselaar wrote:
> Sorry, I've been tied up tracking down some iommu issues. I just took
> a quick stab at this. It looks like the only failure case is the tpm
> read of the did/vid failing for the spi driver. My question is do we
> want to fail the probe in that case, spit out a message, or just
> continue on? Thoughts?
> 
> Regards,
> Jerry

Probably printing warning would be enough. I mean do selftests and
everything.

/Jarkko