[v4,0/5] ima-avm-utils: Convert sign v2 from RSA to EVP_PKEY API

Message

Vitaly Chikunov June 14, 2019, 1:54 a.m. UTC

Changes since v3:
- As suggested by Mimi Zohar this is v3 splitted into several patches to
  simplify review. No code changes.

Changes since v2:
- Just rebase over newer commits.

Changes since v1:
- More key neutral code in calc_keyid_v1().
- Fix uninitialized sigsize for EVP_PKEY_sign().
- Fix memory leaks for openssl types.

Vitaly Chikunov (5):
  ima-avm-utils: Make sure sig buffer is always MAX_SIGNATURE_SIZE
  ima-avm-utils: Change read_pub_key to use EVP_PKEY API
  ima-avm-utils: Change read_priv_key to use EVP_PKEY API
  ima-evm-utils: Convert sign v2 from RSA to EVP_PKEY API
  ima-avm-utils: Remove RSA_ASN1_templates

 src/evmctl.c    |  29 +++---
 src/imaevm.h    |   4 +-
 src/libimaevm.c | 269 ++++++++++++++++++++++++++------------------------------
 3 files changed, 146 insertions(+), 156 deletions(-)

Comments

Vitaly Chikunov June 14, 2019, 1:59 a.m. UTC | #1

Mimi,

Sorry for the typo in `ima-avm-utils` instead of `ima-evm-utils`. Would
you correct it if you going to apply the patches, or I can resend.

Thanks,

On Fri, Jun 14, 2019 at 04:54:05AM +0300, Vitaly Chikunov wrote:
> Changes since v3:
> - As suggested by Mimi Zohar this is v3 splitted into several patches to
>   simplify review. No code changes.
> 
> Changes since v2:
> - Just rebase over newer commits.
> 
> Changes since v1:
> - More key neutral code in calc_keyid_v1().
> - Fix uninitialized sigsize for EVP_PKEY_sign().
> - Fix memory leaks for openssl types.
> 
> Vitaly Chikunov (5):
>   ima-avm-utils: Make sure sig buffer is always MAX_SIGNATURE_SIZE
>   ima-avm-utils: Change read_pub_key to use EVP_PKEY API
>   ima-avm-utils: Change read_priv_key to use EVP_PKEY API
>   ima-evm-utils: Convert sign v2 from RSA to EVP_PKEY API
>   ima-avm-utils: Remove RSA_ASN1_templates
> 
>  src/evmctl.c    |  29 +++---
>  src/imaevm.h    |   4 +-
>  src/libimaevm.c | 269 ++++++++++++++++++++++++++------------------------------
>  3 files changed, 146 insertions(+), 156 deletions(-)
> 
> -- 
> 2.11.0