| Message ID | 20200327042515.22315-1-vt@altlinux.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | ima-evm-utils: Add some tests for evmctl | expand |
On 3/30/20 9:16 AM, Lakshmi Ramasubramanian wrote: > On 3/26/20 9:25 PM, Vitaly Chikunov wrote: >> This series adds simple evmctl tests for hash, sign, and verify >> operations. > > Could you please add the steps to initialize, configure, and run the > tests in cover letter? > > thanks, > -lakshmi Sorry - forgot to reply-all.
On Mon, 2020-03-30 at 09:28 -0700, Lakshmi Ramasubramanian wrote: > On 3/30/20 9:16 AM, Lakshmi Ramasubramanian wrote: > > > On 3/26/20 9:25 PM, Vitaly Chikunov wrote: > > > This series adds simple evmctl tests for hash, sign, and verify > > > operations. > > > > Could you please add the steps to initialize, configure, and run > > the tests in cover letter? > > > > thanks, > > -lakshmi > > Sorry - forgot to reply-all. It looks like it's the standard autoreconf -fiv; ./configure; make; make check? That's basically the universal autoconf way of running tests ... I'm not really sure documenting how to do this is a necessary requirement for the series. James
This series adds simple evmctl tests for hash, sign, and verify operations. Signed-off-by: Vitaly Chikunov <vt@altlinux.org> --- Changelog since v7: - Absence of key file cause test skip instead of fail. - Mono patch is split into two by Mimi Zohar request. Changelog since v6: - ima_hash.test: Compare generated hashes with known values. I found that on power8 qemu with default -cpu calculates hashes wrongly. For exmaple: `openssl dgst -sha224 -hex /dev/null' results in 83b2514951547ee00c7062fa3eb42079ff19f280ec81eedbdb0e3997 instead of d14a028c2a3a2bc9476102bb288234c415a2b01f828ea62ac5b3e42f. - Make `_keyid' use temporary files to not rely on presence of `/des/stdout'. - evm sign: add `--generation 0' option. I found that on overlay fs (with ext4 over 9p) FS_IOC_GETVERSION does not work. - gen-keys.sh: allows `force' argument to regenerate all test keys. Changelog since v5: - Fix tests if gost-engine is not present. Thx to Mimi Zohar for testing on Xenial. Changelog since v4: - Fix bugs found by Mimi Zohar: - Fix typos in variable names - Fix `-out -' in asn1parse for openssl 1.0.x Changelog since v3: - Apply changes based on some suggestions from Petr Vorel, such as - Add .gitignore - Do not color output if stdout is not tty. - Fix blkid error with --uuid option. - Remove or change some comments - Replace ENGINE with EVMCTL_ENGINE and OPENSSL_ENGINE. - All tests pass over next branch. Changelog since v2: - ima_sign.test and ima_verify.test merged into sign_verify.test which is also able to test evm signatures. - Apply Mimi Zohar suggestions regarding commenting, variable renaming, code rearranging, etc. with intent to simplify the code and review. Changelog since v1: - Apply suggestions by Petr Vorel: - Rename function names and variables to be more understandable. - Rename tests/functions to tests/functions.sh. - Define exit codes (77, 99, ...) as variables. - Added more comments and remove single letter variables (for Mimi Zohar). - Move getfattr check into function. - Move evmctl run and check into single function. - Add sign/verify tests for v1 signatures. - Minor improvements. - Since I still edit all 5 files I did not split the patch into multiple commits to separate the files, otherwise editing will become too complicated, as I ought to continuously rebase and edit different commits. This was really non-productive suggestion. Vitaly Chikunov (2): ima-evm-utils: Add some tests for evmctl ima-evm-utils: Add sign/verify tests for evmctl .gitignore | 2 +- Makefile.am | 2 +- configure.ac | 1 + tests/.gitignore | 16 +++ tests/Makefile.am | 12 ++ tests/functions.sh | 272 ++++++++++++++++++++++++++++++++++++ tests/gen-keys.sh | 97 +++++++++++++ tests/ima_hash.test | 80 +++++++++++ tests/sign_verify.test | 364 +++++++++++++++++++++++++++++++++++++++++++++++++ 9 files changed, 844 insertions(+), 2 deletions(-) create mode 100644 tests/.gitignore create mode 100644 tests/Makefile.am create mode 100755 tests/functions.sh create mode 100755 tests/gen-keys.sh create mode 100755 tests/ima_hash.test create mode 100755 tests/sign_verify.test