[ima-evm-utils,v3,00/14] Enable shellcheck and fix some issues

Message

Stefan Berger Dec. 1, 2023, 1:31 p.m. UTC

Enable shellcheck for the bash scripts in the tests directory. Fix issues
on the way that are found when particular checks are enabled. In the end
all shellcheck v0.9 checks are enabled and shellcheck passes without any
issues.

Shellcheck can be run using the following command:

   make shellcheck

Apart from style issues two real issues are detected by SC2003 and SC2295.

Regards,
   Stefan

v3:
 - Replace read with readarray

v2:
 - Rebased on latest next-testing branch
 - 1/14: Use ${var:+${var}} pattern for variables that hold multiple
         arguments like "--foo bar" which would become one argument
         if passed with "${var}"; fixed a build issue
 - 4/14: remove $new_policy file in success and failure cases


Stefan Berger (14):
  tests: Address issues raised by shellcheck SC2086 & enable shellcheck
  tests: Address issues raised by shellcheck SC2181
  tests: Address issues raised by shellcheck SC2046
  tests: Address issues raised by shellcheck SC2320
  tests: Address issues raised by shellcheck SC2317
  tests: Address issues raised by shellcheck SC2034
  tests: Address issues raised by shellcheck SC2164
  tests: Address issues raised by shellcheck SC2166
  tests: Address issues raised by shellcheck SC2294
  tests: Address issues raised by shellcheck SC2206
  tests: Address issues raised by shellcheck SC2196
  tests: Address issues raised by shellcheck SC2043
  tests: Address issues raised by shellcheck SC2295
  tests: Address issues raised by shellcheck SC2003

 Makefile.am                     |  5 ++-
 tests/Makefile.am               | 11 ++++++-
 tests/boot_aggregate.test       | 29 +++++++----------
 tests/fsverity.test             | 22 +++++++------
 tests/functions.sh              | 36 ++++++++++----------
 tests/gen-keys.sh               |  8 +++--
 tests/ima_hash.test             |  4 +--
 tests/install-fsverity.sh       |  4 +--
 tests/install-mount-idmapped.sh |  2 +-
 tests/install-openssl3.sh       | 14 ++++----
 tests/install-swtpm.sh          |  9 ++---
 tests/install-tss.sh            |  2 +-
 tests/mmap_check.test           | 10 +++---
 tests/portable_signatures.test  | 11 +++----
 tests/sign_verify.test          | 15 ++++-----
 tests/softhsm_setup             | 58 ++++++++++++++-------------------
 16 files changed, 119 insertions(+), 121 deletions(-)

Comments

Mimi Zohar Dec. 6, 2023, 7:33 p.m. UTC | #1

On Fri, 2023-12-01 at 08:31 -0500, Stefan Berger wrote:
> Enable shellcheck for the bash scripts in the tests directory. Fix issues
> on the way that are found when particular checks are enabled. In the end
> all shellcheck v0.9 checks are enabled and shellcheck passes without any
> issues.
> 
> Shellcheck can be run using the following command:
> 
>    make shellcheck
> 
> Apart from style issues two real issues are detected by SC2003 and SC2295.
> 
> Regards,
>    Stefan
> 
> v3:
>  - Replace read with readarray
> 
> v2:
>  - Rebased on latest next-testing branch
>  - 1/14: Use ${var:+${var}} pattern for variables that hold multiple
>          arguments like "--foo bar" which would become one argument
>          if passed with "${var}"; fixed a build issue
>  - 4/14: remove $new_policy file in success and failure cases

Thanks, Stefan.  Other than modifying 1/14 as discussed, it looks good.
The patch set is now queued in next-testing.

Mimi