| Message ID | 20240921120811.1264985-1-jarkko@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Lazy flush for the auth session | expand |
Dear Jarkko, Thank you for working on this and your patches. Am 21.09.24 um 14:08 schrieb Jarkko Sakkinen: > This patch set aims to fix: > https://bugzilla.kernel.org/show_bug.cgi?id=219229. If I am not mistaken this is about reducing the boot time, right? It’d be great if you documented the numbers in the commit messages. Kind regards, Paul
On Sat Sep 21, 2024 at 3:36 PM EEST, Paul Menzel wrote: > Dear Jarkko, > > > Thank you for working on this and your patches. > > Am 21.09.24 um 14:08 schrieb Jarkko Sakkinen: > > This patch set aims to fix: > > https://bugzilla.kernel.org/show_bug.cgi?id=219229. > > If I am not mistaken this is about reducing the boot time, right? It’d > be great if you documented the numbers in the commit messages. So what you're asking is already documented by: 1. https://bugzilla.kernel.org/show_bug.cgi?id=219229 2. Tested-by I added lore link to the bugzilla bug, in order to address your comment. I don't think my "QEMU numbers" will bring any value here tbh. BR, Jarkko
On Sat Sep 21, 2024 at 4:13 PM EEST, Jarkko Sakkinen wrote: > On Sat Sep 21, 2024 at 3:36 PM EEST, Paul Menzel wrote: > > Dear Jarkko, > > > > > > Thank you for working on this and your patches. > > > > Am 21.09.24 um 14:08 schrieb Jarkko Sakkinen: > > > This patch set aims to fix: > > > https://bugzilla.kernel.org/show_bug.cgi?id=219229. > > > > If I am not mistaken this is about reducing the boot time, right? It’d > > be great if you documented the numbers in the commit messages. > > So what you're asking is already documented by: > > 1. https://bugzilla.kernel.org/show_bug.cgi?id=219229 > 2. Tested-by > > I added lore link to the bugzilla bug, in order to address your comment. ... to the email which contains the figures. 20 s -> 8.7 s BR, Jarkko
On Sat Sep 21, 2024 at 3:08 PM EEST, Jarkko Sakkinen wrote: > This patch set aims to fix: > https://bugzilla.kernel.org/show_bug.cgi?id=219229. > > The baseline for the series is the v6.11 tag. > > v4: > https://lore.kernel.org/linux-integrity/20240918203559.192605-1-jarkko@kernel.org/ > v3: > https://lore.kernel.org/linux-integrity/20240917154444.702370-1-jarkko@kernel.org/ > v2: > https://lore.kernel.org/linux-integrity/20240916110714.1396407-1-jarkko@kernel.org/ > v1: > https://lore.kernel.org/linux-integrity/20240915180448.2030115-1-jarkko@kernel.org/ > > Jarkko Sakkinen (5): > tpm: Return on tpm2_create_null_primary() failure > tpm: Implement tpm2_load_null() rollback > tpm: flush the null key only when /dev/tpm0 is accessed > tpm: Allocate chip->auth in tpm2_start_auth_session() > tpm: flush the auth session only when /dev/tpm0 is open > > drivers/char/tpm/tpm-chip.c | 14 ++++ > drivers/char/tpm/tpm-dev-common.c | 8 +++ > drivers/char/tpm/tpm-interface.c | 10 ++- > drivers/char/tpm/tpm2-cmd.c | 3 + > drivers/char/tpm/tpm2-sessions.c | 109 ++++++++++++++++++------------ > include/linux/tpm.h | 2 + > 6 files changed, 102 insertions(+), 44 deletions(-) Roberto, James, speaking of digest cache. This patch set has no aim to fix those issues but I do believe that it should improve also that feature. If I don't get soon patch reviews for the patch set, I'll pick the 2nd best option: disable bus encryption on all architectures including x86 and ARM64 (being by default on). It's a force majeure situation. I know this would sort out the issue but I really cannot send these as a pull request with zero reviewe-by's. I expect this to be closed by tomorrow. BR, Jarkko