| Message ID | 1516213631-8974-1-git-send-email-rppt@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jan 17, 2018 at 08:27:11PM +0200, Mike Rapoport wrote: > The switch to uuid_t invereted the logic of verfication that &entry->fsuuid > is zero during parsing of "fsuuid=" rule. Instead of making sure the > &entry->fsuuid field is not attempted to be overwriten, we bail out for > perfectly correct rule. > > Fixes: 787d8c530af7 ("ima/policy: switch to use uuid_t") > > Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com> > --- > security/integrity/ima/ima_policy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) <formletter> This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. </formletter>
On Wed, 2018-01-17 at 20:27 +0200, Mike Rapoport wrote: > The switch to uuid_t invereted the logic of verfication that &entry->fsuuid > is zero during parsing of "fsuuid=" rule. Instead of making sure the > &entry->fsuuid field is not attempted to be overwriten, we bail out for > perfectly correct rule. > > Fixes: 787d8c530af7 ("ima/policy: switch to use uuid_t") > > Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com> Thanks, Mike. > --- > security/integrity/ima/ima_policy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/integrity/ima/ima_policy.c b/security/integrity/ima/ima_policy.c > index ee4613fa5840..f19f4841a97a 100644 > --- a/security/integrity/ima/ima_policy.c > +++ b/security/integrity/ima/ima_policy.c > @@ -743,7 +743,7 @@ static int ima_parse_rule(char *rule, struct ima_rule_entry *entry) > case Opt_fsuuid: > ima_log_string(ab, "fsuuid", args[0].from); > > - if (uuid_is_null(&entry->fsuuid)) { > + if (!uuid_is_null(&entry->fsuuid)) { > result = -EINVAL; > break; > }
diff --git a/security/integrity/ima/ima_policy.c b/security/integrity/ima/ima_policy.c index ee4613fa5840..f19f4841a97a 100644 --- a/security/integrity/ima/ima_policy.c +++ b/security/integrity/ima/ima_policy.c @@ -743,7 +743,7 @@ static int ima_parse_rule(char *rule, struct ima_rule_entry *entry) case Opt_fsuuid: ima_log_string(ab, "fsuuid", args[0].from); - if (uuid_is_null(&entry->fsuuid)) { + if (!uuid_is_null(&entry->fsuuid)) { result = -EINVAL; break; }
The switch to uuid_t invereted the logic of verfication that &entry->fsuuid is zero during parsing of "fsuuid=" rule. Instead of making sure the &entry->fsuuid field is not attempted to be overwriten, we bail out for perfectly correct rule. Fixes: 787d8c530af7 ("ima/policy: switch to use uuid_t") Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com> --- security/integrity/ima/ima_policy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)