mbox series

[GIT,PULL] tpmdd fixes for Linux v5.5-rc6

Message ID 20200106174328.GA16364@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series [GIT,PULL] tpmdd fixes for Linux v5.5-rc6 | expand

Pull-request

git://git.infradead.org/users/jjs/linux-tpmdd.git tags/tpmdd-next-20200106

Message

Jarkko Sakkinen Jan. 6, 2020, 5:43 p.m. UTC
There has been a bunch of reports (e.g. [*]) reporting that when this
commit is applied it causes on some machines boot freezes.

Unfortunately hardware where this commit causes a failure is not widely
available (only one I'm aware is Lenovo T490), which means we cannot
predict yet how long it will take to properly fix tpm_tis interrupt
probing.

Thus, the least worst short term action is to revert the code to the
state before this commit. In long term we need fix the tpm_tis probing
code to work on machines that Stefan's patches were supposed to fix.

With these patches reverted nothing fatal happens, TPM is fallbacked
to be used in polling mode (which is not in the end too bad because
there are no high throughput workloads for TPM).

[*] https://bugzilla.kernel.org/show_bug.cgi?id=205935

/Jarkko

The following changes since commit c79f46a282390e0f5b306007bf7b11a46d529538:

  Linux 5.5-rc5 (2020-01-05 14:23:27 -0800)

are available in the Git repository at:

  git://git.infradead.org/users/jjs/linux-tpmdd.git tags/tpmdd-next-20200106

for you to fetch changes up to aa4a63dd981682b1742baa01237036e48bc11923:

  tpm: Revert "tpm_tis_core: Turn on the TPM before probing IRQ's" (2020-01-06 19:36:09 +0200)

----------------------------------------------------------------
tpmdd fixes for Linux v5.5-rc6

----------------------------------------------------------------
Jarkko Sakkinen (1):
      tpm: Revert "tpm_tis: reserve chip for duration of tpm_tis_core_init"

Stefan Berger (2):
      tpm: Revert "tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for interrupts"
      tpm: Revert "tpm_tis_core: Turn on the TPM before probing IRQ's"

 drivers/char/tpm/tpm_tis_core.c | 34 +++++++++++++++-------------------
 1 file changed, 15 insertions(+), 19 deletions(-)

Comments

pr-tracker-bot@kernel.org Jan. 6, 2020, 11 p.m. UTC | #1
The pull request you sent on Mon, 6 Jan 2020 19:43:28 +0200:

> git://git.infradead.org/users/jjs/linux-tpmdd.git tags/tpmdd-next-20200106

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/7ae564122f75337d84c41b3963a6e25e8665dfac

Thank you!