diff mbox series

[v1] tpm: use %*ph to print small buffer

Message ID 20200730161613.41607-1-andriy.shevchenko@linux.intel.com (mailing list archive)
State New
Headers show
Series [v1] tpm: use %*ph to print small buffer | expand

Commit Message

Andy Shevchenko July 30, 2020, 4:16 p.m. UTC
Use %*ph format to print small buffer as hex string.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/char/tpm/tpm-sysfs.c | 31 ++++++++++---------------------
 1 file changed, 10 insertions(+), 21 deletions(-)

Comments

Petr Vorel July 31, 2020, 8:43 p.m. UTC | #1
Hi,

> Use %*ph format to print small buffer as hex string.
Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr
Jarkko Sakkinen Aug. 18, 2020, 5:33 a.m. UTC | #2
On Thu, Jul 30, 2020 at 07:16:13PM +0300, Andy Shevchenko wrote:
> Use %*ph format to print small buffer as hex string.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Oh, this is handy, thanks.

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

/Jarkko
Jarkko Sakkinen Aug. 18, 2020, 5:35 a.m. UTC | #3
On Fri, Jul 31, 2020 at 10:43:08PM +0200, Petr Vorel wrote:
> Hi,
> 
> > Use %*ph format to print small buffer as hex string.
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> 
> Kind regards,
> Petr

Thanks, I'll add this to the commit.

/Jarkko
Andy Shevchenko Sept. 14, 2020, 4:10 p.m. UTC | #4
On Tue, Aug 18, 2020 at 08:33:51AM +0300, Jarkko Sakkinen wrote:
> On Thu, Jul 30, 2020 at 07:16:13PM +0300, Andy Shevchenko wrote:
> > Use %*ph format to print small buffer as hex string.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Oh, this is handy, thanks.
> 
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

Thanks!

Anybody to push this?
Jarkko Sakkinen Sept. 15, 2020, 9:43 a.m. UTC | #5
On Mon, Sep 14, 2020 at 07:10:33PM +0300, Andy Shevchenko wrote:
> On Tue, Aug 18, 2020 at 08:33:51AM +0300, Jarkko Sakkinen wrote:
> > On Thu, Jul 30, 2020 at 07:16:13PM +0300, Andy Shevchenko wrote:
> > > Use %*ph format to print small buffer as hex string.
> > > 
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > 
> > Oh, this is handy, thanks.
> > 
> > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> 
> Thanks!
> 
> Anybody to push this?

It's in my tree git://git.infradead.org/users/jjs/linux-tpmdd.git

So next I'll put it to the next PR.

/Jarkko
Andy Shevchenko Sept. 15, 2020, 12:04 p.m. UTC | #6
On Tue, Sep 15, 2020 at 12:43:32PM +0300, Jarkko Sakkinen wrote:
> On Mon, Sep 14, 2020 at 07:10:33PM +0300, Andy Shevchenko wrote:
> > On Tue, Aug 18, 2020 at 08:33:51AM +0300, Jarkko Sakkinen wrote:
> > > On Thu, Jul 30, 2020 at 07:16:13PM +0300, Andy Shevchenko wrote:
> > > > Use %*ph format to print small buffer as hex string.
> > > > 
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > 
> > > Oh, this is handy, thanks.
> > > 
> > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > 
> > Thanks!
> > 
> > Anybody to push this?
> 
> It's in my tree git://git.infradead.org/users/jjs/linux-tpmdd.git
> 
> So next I'll put it to the next PR.

Thanks!

P.S. I don't see your tree connected to Linux Next, perhaps you can ask Stephen
to add it?
Jarkko Sakkinen Sept. 16, 2020, 3:35 p.m. UTC | #7
On Tue, Sep 15, 2020 at 03:04:11PM +0300, Andy Shevchenko wrote:
> On Tue, Sep 15, 2020 at 12:43:32PM +0300, Jarkko Sakkinen wrote:
> > On Mon, Sep 14, 2020 at 07:10:33PM +0300, Andy Shevchenko wrote:
> > > On Tue, Aug 18, 2020 at 08:33:51AM +0300, Jarkko Sakkinen wrote:
> > > > On Thu, Jul 30, 2020 at 07:16:13PM +0300, Andy Shevchenko wrote:
> > > > > Use %*ph format to print small buffer as hex string.
> > > > > 
> > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > > 
> > > > Oh, this is handy, thanks.
> > > > 
> > > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > > 
> > > Thanks!
> > > 
> > > Anybody to push this?
> > 
> > It's in my tree git://git.infradead.org/users/jjs/linux-tpmdd.git
> > 
> > So next I'll put it to the next PR.
> 
> Thanks!
> 
> P.S. I don't see your tree connected to Linux Next, perhaps you can ask Stephen
> to add it?

The next branch is connected to the linux-next. I've just forgot to
rebase that branch (will do now).

> -- 
> With Best Regards,
> Andy Shevchenko

/Jarkko
diff mbox series

Patch

diff --git a/drivers/char/tpm/tpm-sysfs.c b/drivers/char/tpm/tpm-sysfs.c
index d52bf4df0bca..e2ff0b273a0f 100644
--- a/drivers/char/tpm/tpm-sysfs.c
+++ b/drivers/char/tpm/tpm-sysfs.c
@@ -56,31 +56,20 @@  static ssize_t pubek_show(struct device *dev, struct device_attribute *attr,
 	out = (struct tpm_readpubek_out *)&tpm_buf.data[10];
 	str +=
 	    sprintf(str,
-		    "Algorithm: %02X %02X %02X %02X\n"
-		    "Encscheme: %02X %02X\n"
-		    "Sigscheme: %02X %02X\n"
-		    "Parameters: %02X %02X %02X %02X "
-		    "%02X %02X %02X %02X "
-		    "%02X %02X %02X %02X\n"
+		    "Algorithm: %4ph\n"
+		    "Encscheme: %2ph\n"
+		    "Sigscheme: %2ph\n"
+		    "Parameters: %12ph\n"
 		    "Modulus length: %d\n"
 		    "Modulus:\n",
-		    out->algorithm[0], out->algorithm[1], out->algorithm[2],
-		    out->algorithm[3],
-		    out->encscheme[0], out->encscheme[1],
-		    out->sigscheme[0], out->sigscheme[1],
-		    out->parameters[0], out->parameters[1],
-		    out->parameters[2], out->parameters[3],
-		    out->parameters[4], out->parameters[5],
-		    out->parameters[6], out->parameters[7],
-		    out->parameters[8], out->parameters[9],
-		    out->parameters[10], out->parameters[11],
+		    out->algorithm,
+		    out->encscheme,
+		    out->sigscheme,
+		    out->parameters,
 		    be32_to_cpu(out->keysize));
 
-	for (i = 0; i < 256; i++) {
-		str += sprintf(str, "%02X ", out->modulus[i]);
-		if ((i + 1) % 16 == 0)
-			str += sprintf(str, "\n");
-	}
+	for (i = 0; i < 256; i += 16)
+		str += sprintf(str, "%16ph\n", &out->modulus[i]);
 
 out_buf:
 	tpm_buf_destroy(&tpm_buf);