diff mbox series

[-next] char/tpm: simplify the return expression of tpm_tis_synquacer_module_init()

Message ID 20201210135515.1310-1-zhengyongjun3@huawei.com (mailing list archive)
State New, archived
Headers show
Series [-next] char/tpm: simplify the return expression of tpm_tis_synquacer_module_init() | expand

Commit Message

Zheng Yongjun Dec. 10, 2020, 1:55 p.m. UTC
Simplify the return expression.

Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
 drivers/char/tpm/tpm_tis_synquacer.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Jarkko Sakkinen Dec. 11, 2020, 10:53 a.m. UTC | #1
On Thu, Dec 10, 2020 at 09:55:15PM +0800, Zheng Yongjun wrote:
> Simplify the return expression.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>

I don't see how this would be meaningful change as the existing
code is according to the coding style.

> ---
>  drivers/char/tpm/tpm_tis_synquacer.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/char/tpm/tpm_tis_synquacer.c b/drivers/char/tpm/tpm_tis_synquacer.c
> index e47bdd272704..3b4ae2f23f09 100644
> --- a/drivers/char/tpm/tpm_tis_synquacer.c
> +++ b/drivers/char/tpm/tpm_tis_synquacer.c
> @@ -188,13 +188,8 @@ static struct platform_driver tis_synquacer_drv = {
>  
>  static int __init tpm_tis_synquacer_module_init(void)
>  {
> -	int rc;
>  
> -	rc = platform_driver_register(&tis_synquacer_drv);
> -	if (rc)
> -		return rc;
> -
> -	return 0;
> +	return platform_driver_register(&tis_synquacer_drv);
>  }
>  
>  static void __exit tpm_tis_synquacer_module_exit(void)
> -- 
> 2.22.0
> 
> 

/Jarkko
diff mbox series

Patch

diff --git a/drivers/char/tpm/tpm_tis_synquacer.c b/drivers/char/tpm/tpm_tis_synquacer.c
index e47bdd272704..3b4ae2f23f09 100644
--- a/drivers/char/tpm/tpm_tis_synquacer.c
+++ b/drivers/char/tpm/tpm_tis_synquacer.c
@@ -188,13 +188,8 @@  static struct platform_driver tis_synquacer_drv = {
 
 static int __init tpm_tis_synquacer_module_init(void)
 {
-	int rc;
 
-	rc = platform_driver_register(&tis_synquacer_drv);
-	if (rc)
-		return rc;
-
-	return 0;
+	return platform_driver_register(&tis_synquacer_drv);
 }
 
 static void __exit tpm_tis_synquacer_module_exit(void)