| Message ID | 20210520121347.3467794-9-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Rid W=1 warnings from Char | expand |
On Thu, May 20, 2021 at 01:13:39PM +0100, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/char/tpm/tpm_ftpm_tee.c:218: warning: Function parameter or member 'dev' not described in 'ftpm_tee_probe' > drivers/char/tpm/tpm_ftpm_tee.c:218: warning: Excess function parameter 'pdev' description in 'ftpm_tee_probe' > drivers/char/tpm/tpm_ftpm_tee.c:314: warning: Function parameter or member 'dev' not described in 'ftpm_tee_remove' > drivers/char/tpm/tpm_ftpm_tee.c:314: warning: Excess function parameter 'pdev' description in 'ftpm_tee_remove' > drivers/char/tpm/tpm_ftpm_tee.c:349: warning: expecting prototype for ftpm_tee_shutdown(). Prototype was for ftpm_plat_tee_shutdown() instead > > Cc: Peter Huewe <peterhuewe@gmx.de> > Cc: Jarkko Sakkinen <jarkko@kernel.org> > Cc: Jason Gunthorpe <jgg@ziepe.ca> > Cc: Thirupathaiah Annapureddy <thiruan@microsoft.com> > Cc: linux-integrity@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> /Jarkko > --- > drivers/char/tpm/tpm_ftpm_tee.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_tee.c > index 2ccdf8ac69948..2d9c0ecd43f0a 100644 > --- a/drivers/char/tpm/tpm_ftpm_tee.c > +++ b/drivers/char/tpm/tpm_ftpm_tee.c > @@ -209,7 +209,7 @@ static int ftpm_tee_match(struct tee_ioctl_version_data *ver, const void *data) > > /** > * ftpm_tee_probe() - initialize the fTPM > - * @pdev: the platform_device description. > + * @dev: the platform_device description. > * > * Return: > * On success, 0. On failure, -errno. > @@ -305,7 +305,7 @@ static int ftpm_plat_tee_probe(struct platform_device *pdev) > > /** > * ftpm_tee_remove() - remove the TPM device > - * @pdev: the platform_device description. > + * @dev: the platform_device description. > * > * Return: > * 0 always. > @@ -342,7 +342,7 @@ static int ftpm_plat_tee_remove(struct platform_device *pdev) > } > > /** > - * ftpm_tee_shutdown() - shutdown the TPM device > + * ftpm_plat_tee_shutdown() - shutdown the TPM device > * @pdev: the platform_device description. > */ > static void ftpm_plat_tee_shutdown(struct platform_device *pdev) > -- > 2.31.1 > >
diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_tee.c index 2ccdf8ac69948..2d9c0ecd43f0a 100644 --- a/drivers/char/tpm/tpm_ftpm_tee.c +++ b/drivers/char/tpm/tpm_ftpm_tee.c @@ -209,7 +209,7 @@ static int ftpm_tee_match(struct tee_ioctl_version_data *ver, const void *data) /** * ftpm_tee_probe() - initialize the fTPM - * @pdev: the platform_device description. + * @dev: the platform_device description. * * Return: * On success, 0. On failure, -errno. @@ -305,7 +305,7 @@ static int ftpm_plat_tee_probe(struct platform_device *pdev) /** * ftpm_tee_remove() - remove the TPM device - * @pdev: the platform_device description. + * @dev: the platform_device description. * * Return: * 0 always. @@ -342,7 +342,7 @@ static int ftpm_plat_tee_remove(struct platform_device *pdev) } /** - * ftpm_tee_shutdown() - shutdown the TPM device + * ftpm_plat_tee_shutdown() - shutdown the TPM device * @pdev: the platform_device description. */ static void ftpm_plat_tee_shutdown(struct platform_device *pdev)
Fixes the following W=1 kernel build warning(s): drivers/char/tpm/tpm_ftpm_tee.c:218: warning: Function parameter or member 'dev' not described in 'ftpm_tee_probe' drivers/char/tpm/tpm_ftpm_tee.c:218: warning: Excess function parameter 'pdev' description in 'ftpm_tee_probe' drivers/char/tpm/tpm_ftpm_tee.c:314: warning: Function parameter or member 'dev' not described in 'ftpm_tee_remove' drivers/char/tpm/tpm_ftpm_tee.c:314: warning: Excess function parameter 'pdev' description in 'ftpm_tee_remove' drivers/char/tpm/tpm_ftpm_tee.c:349: warning: expecting prototype for ftpm_tee_shutdown(). Prototype was for ftpm_plat_tee_shutdown() instead Cc: Peter Huewe <peterhuewe@gmx.de> Cc: Jarkko Sakkinen <jarkko@kernel.org> Cc: Jason Gunthorpe <jgg@ziepe.ca> Cc: Thirupathaiah Annapureddy <thiruan@microsoft.com> Cc: linux-integrity@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/char/tpm/tpm_ftpm_tee.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)