diff mbox series

[1/2] char: tpm: Kconfig: remove bad i2c cr50 select

Message ID 20210723184150.2596604-1-adrian.ratiu@collabora.com (mailing list archive)
State New, archived
Headers show
Series [1/2] char: tpm: Kconfig: remove bad i2c cr50 select | expand

Commit Message

Adrian Ratiu July 23, 2021, 6:41 p.m. UTC
This fixes a minor bug which went unnoticed during the initial
driver upstreaming review: TCG_CR50 does not exist in mainline
kernels, so remove it.

Fixes: 3a253caaad11 ("char: tpm: add i2c driver for cr50")
Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
---
 drivers/char/tpm/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

jarkko@kernel.org July 27, 2021, 3:06 a.m. UTC | #1
On Fri, Jul 23, 2021 at 09:41:49PM +0300, Adrian Ratiu wrote:
> This fixes a minor bug which went unnoticed during the initial
> driver upstreaming review: TCG_CR50 does not exist in mainline
> kernels, so remove it.
> 
> Fixes: 3a253caaad11 ("char: tpm: add i2c driver for cr50")
> Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>



Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

Also, for this I'd add:

Cc: stable@vger.kernel.org

?

/Jarkko
diff mbox series

Patch

diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
index 4308f9ca7a43..d6ba644f6b00 100644
--- a/drivers/char/tpm/Kconfig
+++ b/drivers/char/tpm/Kconfig
@@ -89,7 +89,6 @@  config TCG_TIS_SYNQUACER
 config TCG_TIS_I2C_CR50
 	tristate "TPM Interface Specification 2.0 Interface (I2C - CR50)"
 	depends on I2C
-	select TCG_CR50
 	help
 	  This is a driver for the Google cr50 I2C TPM interface which is a
 	  custom microcontroller and requires a custom i2c protocol interface