| Message ID | 20210816151600.24850-1-bmeneg@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,ima-evm-utils] evmctl: fix memory leak in get_password | expand |
diff --git a/src/evmctl.c b/src/evmctl.c index a8065bbe124a..ab7173723095 100644 --- a/src/evmctl.c +++ b/src/evmctl.c @@ -2625,7 +2625,12 @@ static char *get_password(void) return NULL; } - return pwd; + if (pwd == NULL) { + free(password); + return NULL; + } + + return password; } int main(int argc, char *argv[])
The variable "password" is not freed nor returned in case get_password() succeeds. Return it instead of the intermediary variable "pwd". Issue found by Coverity scan tool. src/evmctl.c:2565: leaked_storage: Variable "password" going out of scope leaks the storage it points to. Signed-off-by: Bruno Meneguele <bmeneg@redhat.com> --- Changelog: v1: instead of removing the 'pwd' var, return 'password' (Mimi) src/evmctl.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)