| Message ID | 20220712011037.2328591-1-niejianglei2021@163.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] ima/evm: Fix potential memory leak in ima_init_crypto() | expand |
On Tue, 2022-07-12 at 09:10 +0800, Jianglei Nie wrote: > On failure to allocate the SHA1 tfm, IMA fails to initialize and exits > without freeing the ima_algo_array. Add the missing kfree() for > ima_algo_array to avoid the potential memory leak. > > Signed-off-by: Jianglei Nie <niejianglei2021@163.com> Thanks, Jianglei. This patch is now queued in next-integrity/next- integrity-testing. Mimi
diff --git a/security/integrity/ima/ima_crypto.c b/security/integrity/ima/ima_crypto.c index a7206cc1d7d1..64499056648a 100644 --- a/security/integrity/ima/ima_crypto.c +++ b/security/integrity/ima/ima_crypto.c @@ -205,6 +205,7 @@ int __init ima_init_crypto(void) crypto_free_shash(ima_algo_array[i].tfm); } + kfree(ima_algo_array); out: crypto_free_shash(ima_shash_tfm); return rc;
On failure to allocate the SHA1 tfm, IMA fails to initialize and exits without freeing the ima_algo_array. Add the missing kfree() for ima_algo_array to avoid the potential memory leak. Signed-off-by: Jianglei Nie <niejianglei2021@163.com> --- security/integrity/ima/ima_crypto.c | 1 + 1 file changed, 1 insertion(+)