| Message ID | 20230620-flo-lenovo-l590-tpm-fix-v1-1-16032a8b5a1d@bezdeka.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tpm/tpm_tis: Disable interrupts for Lenovo L590 devices | expand |
Hi, On 6/20/23 13:11, Florian Bezdeka wrote: > The Lenovo L590 suffers from an irq storm issue like the T490, T490s > and P360 Tiny, so add an entry for it to tpm_tis_dmi_table and force > polling. > > Link: https://bugzilla.redhat.com/show_bug.cgi?id=2214069#c0 > Fixes: e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test") > Signed-off-by: Florian Bezdeka <florian@bezdeka.de> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/char/tpm/tpm_tis.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c > index 7db3593941ea..2771abb5628f 100644 > --- a/drivers/char/tpm/tpm_tis.c > +++ b/drivers/char/tpm/tpm_tis.c > @@ -138,6 +138,14 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = { > DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L490"), > }, > }, > + { > + .callback = tpm_tis_disable_irq, > + .ident = "ThinkPad L590", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L590"), > + }, > + }, > { > .callback = tpm_tis_disable_irq, > .ident = "UPX-TGL", > > --- > base-commit: 9561de3a55bed6bdd44a12820ba81ec416e705a7 > change-id: 20230620-flo-lenovo-l590-tpm-fix-4aeb6aa25667 > > Best regards,
On Tue, Jun 20, 2023 at 01:11:01PM +0200, Florian Bezdeka wrote: > The Lenovo L590 suffers from an irq storm issue like the T490, T490s > and P360 Tiny, so add an entry for it to tpm_tis_dmi_table and force > polling. > > Link: https://bugzilla.redhat.com/show_bug.cgi?id=2214069#c0 > Fixes: e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test") > Signed-off-by: Florian Bezdeka <florian@bezdeka.de> Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com> > --- > drivers/char/tpm/tpm_tis.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c > index 7db3593941ea..2771abb5628f 100644 > --- a/drivers/char/tpm/tpm_tis.c > +++ b/drivers/char/tpm/tpm_tis.c > @@ -138,6 +138,14 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = { > DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L490"), > }, > }, > + { > + .callback = tpm_tis_disable_irq, > + .ident = "ThinkPad L590", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L590"), > + }, > + }, > { > .callback = tpm_tis_disable_irq, > .ident = "UPX-TGL", > > --- > base-commit: 9561de3a55bed6bdd44a12820ba81ec416e705a7 > change-id: 20230620-flo-lenovo-l590-tpm-fix-4aeb6aa25667 > > Best regards, > -- > Florian Bezdeka <florian@bezdeka.de> >
On Tue Jun 20, 2023 at 2:11 PM EEST, Florian Bezdeka wrote: > The Lenovo L590 suffers from an irq storm issue like the T490, T490s > and P360 Tiny, so add an entry for it to tpm_tis_dmi_table and force > polling. > > Link: https://bugzilla.redhat.com/show_bug.cgi?id=2214069#c0 > Fixes: e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test") > Signed-off-by: Florian Bezdeka <florian@bezdeka.de> > --- > drivers/char/tpm/tpm_tis.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c > index 7db3593941ea..2771abb5628f 100644 > --- a/drivers/char/tpm/tpm_tis.c > +++ b/drivers/char/tpm/tpm_tis.c > @@ -138,6 +138,14 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = { > DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L490"), > }, > }, > + { > + .callback = tpm_tis_disable_irq, > + .ident = "ThinkPad L590", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L590"), > + }, > + }, > { > .callback = tpm_tis_disable_irq, > .ident = "UPX-TGL", > > --- > base-commit: 9561de3a55bed6bdd44a12820ba81ec416e705a7 > change-id: 20230620-flo-lenovo-l590-tpm-fix-4aeb6aa25667 > > Best regards, > -- > Florian Bezdeka <florian@bezdeka.de> Thanks, applied. BR, Jarkko
diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c index 7db3593941ea..2771abb5628f 100644 --- a/drivers/char/tpm/tpm_tis.c +++ b/drivers/char/tpm/tpm_tis.c @@ -138,6 +138,14 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L490"), }, }, + { + .callback = tpm_tis_disable_irq, + .ident = "ThinkPad L590", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L590"), + }, + }, { .callback = tpm_tis_disable_irq, .ident = "UPX-TGL",
The Lenovo L590 suffers from an irq storm issue like the T490, T490s and P360 Tiny, so add an entry for it to tpm_tis_dmi_table and force polling. Link: https://bugzilla.redhat.com/show_bug.cgi?id=2214069#c0 Fixes: e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test") Signed-off-by: Florian Bezdeka <florian@bezdeka.de> --- drivers/char/tpm/tpm_tis.c | 8 ++++++++ 1 file changed, 8 insertions(+) --- base-commit: 9561de3a55bed6bdd44a12820ba81ec416e705a7 change-id: 20230620-flo-lenovo-l590-tpm-fix-4aeb6aa25667 Best regards,