| Message ID | 20231119165043.46960-6-zohar@linux.ibm.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Address non concurrency-safe libimaevm global variables | expand |
On 11/19/23 11:50, Mimi Zohar wrote: > Update the static verify_ima() fucntion definition to include "public_keys". > -> function > Replace calling init_public_keys() with the init_public_keys2() version. > Similarly replace ima_verify_signature() with the ima_verify_signature2() > version. > > Free the local public keys list. > > Signed-off-by: Mimi Zohar <zohar@linux.ibm.com> > --- > src/evmctl.c | 23 +++++++++++++---------- > 1 file changed, 13 insertions(+), 10 deletions(-) > > diff --git a/src/evmctl.c b/src/evmctl.c > index 4190913f0295..bf1f8f07e9ca 100644 > --- a/src/evmctl.c > +++ b/src/evmctl.c > @@ -972,7 +972,7 @@ static int cmd_verify_evm(struct command *cmd) > return err; > } > > -static int verify_ima(const char *file) > +static int verify_ima(void *public_keys, const char *file) > { > unsigned char sig[MAX_SIGNATURE_SIZE]; > int len; > @@ -999,34 +999,37 @@ static int verify_ima(const char *file) > } > } > > - return ima_verify_signature(file, sig, len, NULL, 0); > + return ima_verify_signature2(public_keys, file, sig, len, NULL, 0); > } > > static int cmd_verify_ima(struct command *cmd) > { > char *file = g_argv[optind++]; > + void *public_keys = NULL; > int err, fails = 0; > > - if (imaevm_params.x509) { > - if (imaevm_params.keyfile) /* Support multiple public keys */ > - init_public_keys(imaevm_params.keyfile); > - else /* assume read pubkey from x509 cert */ > - init_public_keys("/etc/keys/x509_evm.der"); > - } > - > if (!file) { > log_err("Parameters missing\n"); > print_usage(cmd); > return -1; > } > > + if (imaevm_params.x509) { > + if (imaevm_params.keyfile) /* Support multiple public keys */ > + init_public_keys2(imaevm_params.keyfile, &public_keys); > + else /* assume read pubkey from x509 cert */ > + init_public_keys2("/etc/keys/x509_evm.der", &public_keys); You should probably check the return code of this function. > + } > + > do { > - err = verify_ima(file); > + err = verify_ima(public_keys, file); > if (err) > fails++; > if (!err && imaevm_params.verbose >= LOG_INFO) > log_info("%s: verification is OK\n", file); > } while ((file = g_argv[optind++])); > + > + free_public_keys(public_keys); > return fails > 0; > } >
diff --git a/src/evmctl.c b/src/evmctl.c index 4190913f0295..bf1f8f07e9ca 100644 --- a/src/evmctl.c +++ b/src/evmctl.c @@ -972,7 +972,7 @@ static int cmd_verify_evm(struct command *cmd) return err; } -static int verify_ima(const char *file) +static int verify_ima(void *public_keys, const char *file) { unsigned char sig[MAX_SIGNATURE_SIZE]; int len; @@ -999,34 +999,37 @@ static int verify_ima(const char *file) } } - return ima_verify_signature(file, sig, len, NULL, 0); + return ima_verify_signature2(public_keys, file, sig, len, NULL, 0); } static int cmd_verify_ima(struct command *cmd) { char *file = g_argv[optind++]; + void *public_keys = NULL; int err, fails = 0; - if (imaevm_params.x509) { - if (imaevm_params.keyfile) /* Support multiple public keys */ - init_public_keys(imaevm_params.keyfile); - else /* assume read pubkey from x509 cert */ - init_public_keys("/etc/keys/x509_evm.der"); - } - if (!file) { log_err("Parameters missing\n"); print_usage(cmd); return -1; } + if (imaevm_params.x509) { + if (imaevm_params.keyfile) /* Support multiple public keys */ + init_public_keys2(imaevm_params.keyfile, &public_keys); + else /* assume read pubkey from x509 cert */ + init_public_keys2("/etc/keys/x509_evm.der", &public_keys); + } + do { - err = verify_ima(file); + err = verify_ima(public_keys, file); if (err) fails++; if (!err && imaevm_params.verbose >= LOG_INFO) log_info("%s: verification is OK\n", file); } while ((file = g_argv[optind++])); + + free_public_keys(public_keys); return fails > 0; }
Update the static verify_ima() fucntion definition to include "public_keys". Replace calling init_public_keys() with the init_public_keys2() version. Similarly replace ima_verify_signature() with the ima_verify_signature2() version. Free the local public keys list. Signed-off-by: Mimi Zohar <zohar@linux.ibm.com> --- src/evmctl.c | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-)