mbox series

[0/3] checkkconfigsymbols.py: Fix various bugs

Message ID 20210822192205.43210-1-arielmarcovitch@gmail.com (mailing list archive)
Headers show
Series checkkconfigsymbols.py: Fix various bugs | expand

Message

Ariel Marcovitch Aug. 22, 2021, 7:22 p.m. UTC 
Hi!

This series fixes some issues in the checkkconfigsymbols.py script.

The first patch fixes a bug in the --ignore option that makes the
script check only the files matching the pattern instead of ignoring
them.

The second patch fixes a parsing error in the Kconfig files parser
that makes it ignore 'if' statements after 'help' sections.

The third patch prevents the user from using 'HEAD' refs in the
 --commit option, because it doesn't really work.

Thanks!

-Ariel

Ariel Marcovitch (3):
  checkkconfigsymbols.py: Fix the '--ignore' option
  checkkconfigsymbols.py: Fix Kconfig parsing to find 'if' lines
  checkkconfigsymbols.py: Forbid passing 'HEAD' to --commit

 scripts/checkkconfigsymbols.py | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)


base-commit: 36a21d51725af2ce0700c6ebcb6b9594aac658a6

Comments

Masahiro Yamada Aug. 24, 2021, 1:23 p.m. UTC | #1 
On Mon, Aug 23, 2021 at 4:22 AM Ariel Marcovitch
<arielmarcovitch@gmail.com> wrote:
>
> Hi!
>
> This series fixes some issues in the checkkconfigsymbols.py script.
>
> The first patch fixes a bug in the --ignore option that makes the
> script check only the files matching the pattern instead of ignoring
> them.
>
> The second patch fixes a parsing error in the Kconfig files parser
> that makes it ignore 'if' statements after 'help' sections.
>
> The third patch prevents the user from using 'HEAD' refs in the
>  --commit option, because it doesn't really work.

Honestly, I didn't even know this script.

I added Valentin Rothberg, the main contributor
to this script.




> Thanks!
>
> -Ariel
>
> Ariel Marcovitch (3):
>   checkkconfigsymbols.py: Fix the '--ignore' option
>   checkkconfigsymbols.py: Fix Kconfig parsing to find 'if' lines
>   checkkconfigsymbols.py: Forbid passing 'HEAD' to --commit
>
>  scripts/checkkconfigsymbols.py | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
>
>
> base-commit: 36a21d51725af2ce0700c6ebcb6b9594aac658a6
> --
> 2.25.1
>