[PATCHv4,0/1] kbuild: deb-pkg: allow hooks also in /usr/share/kernel

Message

Johannes Schauer Marin Rodrigues Dec. 3, 2024, 4:17 p.m. UTC

Quoting Masahiro Yamada (2024-12-03 15:24:10)
> > Unless I'm misunderstanding the old code, the existing script *does* create 
> > /etc/kernel/*.d/ (That's the "- mkdir -p" line above) so I wanted to
> > preserve this behaviour even with more than one directory in KDEB_HOOKDIR.
> > Do I misunderstand something?
>█
> Right. The existing code does create empty directories, which
> are unnecessary.

Okay. I had assumed that their creation was intentional.

> > Are you saying that with this change, no
> > /etc/kernel/*.d/ should be created anymore? Why?
>█
> The 'mkdir' is unnecessary regardless of your patch,
> unless I am misunderstanding the code.

Yes, the mkdir is not necessary as far as I can see. Packages that do
install hooks will take care of creating these. It doesn't have to be
the linux kernel image package that takes care of creating them.

> Judging from your cautious approach and verbose changes, I
> assume you are trying to avoid any risks (a common trait
> among many contributors).

That is correct. I hope that such an approach is considered desirable?

> That said, I understand you are not motivated to strive for
> clean code at all costs. Once you commit the run-parts
> changes, you may feel your work is done. However, as the
> maintainer, I must manage this code for many years,
> so I aim to proactively remove unneeded code.

I understand. I don't see a problem changing the patch in a way such that you
feel that you can take responsibility for it in the long term. Thank you for
taking the time to explain this to me. It is really much appreciated and I know
that you don't have to. Thank you!

That being said, please do reach out to me if there are problems with my
contributions later on. I am also the contributor of the new functionality in
run-parts, so should there be issues with debianutils, you can also contact me
about problems with using run-parts on multiple directories as well.

> I have decided to take responsibility for cleaning up this
> single line myself:
>█
> https://lore.kernel.org/linux-kbuild/CAK7LNARU=[e-mail]/T/#t
>█
> If something breaks due to missing directories,
> it will be my fault, not yours.

Thank you. My new patch (v4) in the next mail now is on top of your
change above.

> Now that the dummy directories are gone from the linux-image
> package, please prepare the next version without the
> "pre-create the first hook directory" stuff.
>█
> A few more requests.
>█
> Please add the version number (the next patch will be v4?) like others do.
> And "kbuild: deb-pkg:" as the patch subject.  ('git log
> script/package/buildeb' to see examples)

I think I have taken care of these issues now.

Thank you!

cheers, josch


Johannes Schauer Marin Rodrigues (1):
  kbuild: deb-pkg: allow hooks also in /usr/share/kernel

 scripts/package/builddeb | 23 +++++++++++++++++------
 1 file changed, 17 insertions(+), 6 deletions(-)