From patchwork Sun Jul 5 18:17:34 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: maximilian attems X-Patchwork-Id: 34168 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n65IHheL009670 for ; Sun, 5 Jul 2009 18:17:53 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753228AbZGESRs (ORCPT ); Sun, 5 Jul 2009 14:17:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753363AbZGESRs (ORCPT ); Sun, 5 Jul 2009 14:17:48 -0400 Received: from baikonur.stro.at ([213.239.196.228]:47673 "EHLO baikonur.stro.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753228AbZGESRs (ORCPT ); Sun, 5 Jul 2009 14:17:48 -0400 Received: from dual (chello062178065236.22.11.wu-wien.teleweb.at [62.178.65.236]) by baikonur.stro.at (Postfix) with ESMTP id 166B65C001; Sun, 5 Jul 2009 20:13:45 +0200 (CEST) Received: by dual (Postfix, from userid 1000) id 43B732408E; Sun, 5 Jul 2009 20:17:39 +0200 (CEST) From: maximilian attems To: linux-kbuild@vger.kernel.org Cc: sam@ravnborg.org, maximilian attems , Frans Pop , Andres Salomon Subject: [PATCH] kbuild: deb-pkg fix install scripts for posix sh Date: Sun, 5 Jul 2009 20:17:34 +0200 Message-Id: <1246817854-27396-1-git-send-email-max@stro.at> X-Mailer: git-send-email 1.6.3.3 X-Virus-Scanned: by Amavis (ClamAV) at stro.at Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org bash versus dash and posh disagree on expanding $@ within double quotes: export x="$@" see http://bugs.debian.org/381091 for details just use the arglist with $*. dpkg: error processing linux-image-2.6.31-rc1_2.6.31-rc1-18_i386.deb (--install): subprocess pre-installation script returned error exit status 2 export: 6: 2.6.31-rc1-18: bad variable name fixes http://bugzilla.kernel.org/show_bug.cgi?id=13567 seen on Ubuntu as there dash is the default sh, versus bash on Debian. Reported-by: Pauli Cc: Frans Pop Cc: Andres Salomon Signed-off-by: maximilian attems Acked-by: Frans Pop Acked-By: Andres Salomon --- scripts/package/builddeb | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/package/builddeb b/scripts/package/builddeb index b19f1f4..8b357b0 100644 --- a/scripts/package/builddeb +++ b/scripts/package/builddeb @@ -89,7 +89,7 @@ for script in postinst postrm preinst prerm ; do set -e # Pass maintainer script parameters to hook scripts -export DEB_MAINT_PARAMS="\$@" +export DEB_MAINT_PARAMS="\$*" test -d $debhookdir/$script.d && run-parts --arg="$version" $debhookdir/$script.d exit 0